From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:17643 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750871AbcAUA3Q (ORCPT ); Wed, 20 Jan 2016 19:29:16 -0500 Subject: Re: [PATCH v3 4/4] clk: s2mps11: remove redundant code To: Andi Shyti , linux-samsung-soc@vger.kernel.org References: <1453284864-8082-1-git-send-email-andi.shyti@samsung.com> <1453284864-8082-5-git-send-email-andi.shyti@samsung.com> Cc: Sangbeom Kim , Michael Turquette , Stephen Boyd , linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, Andi Shyti , Yadwinder Singh Brar , Jaehoon Chung From: Krzysztof Kozlowski Message-id: <56A0265A.2000307@samsung.com> Date: Thu, 21 Jan 2016 09:29:14 +0900 MIME-version: 1.0 In-reply-to: <1453284864-8082-5-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Sender: linux-clk-owner@vger.kernel.org List-ID: On 20.01.2016 19:14, Andi Shyti wrote: > The definition of s2mps11_name is meant to resolve the name of a > given clock. Remove it because the clocks have the same name we > can get it directly from the s2mps11_clks_init structure. > > While in the probe function the s2mps11_clks is used only to > iterate through the s2mps11_clks. The naming itself brings > confusion and the readability does not improve much. > > Signed-off-by: Andi Shyti > --- > drivers/clk/clk-s2mps11.c | 36 ++++++++++++++++-------------------- > 1 file changed, 16 insertions(+), 20 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof