From: Jeremy Kerr <jk@ozlabs.org>
To: openbmc@lists.ozlabs.org
Cc: "Milton D. Miller II" <miltonm@us.ibm.com>
Subject: Re: [PATCH openbmc 1/6] create obmc-phosphor-initfs
Date: Thu, 21 Jan 2016 14:10:47 +0800 [thread overview]
Message-ID: <56A07667.8020800@ozlabs.org> (raw)
In-Reply-To: <1453331420-6524-2-git-send-email-openbmc-patches@stwcx.xyz>
Hi Milton,
Looks good to me. One suggestion:
> + echo Please mount the rw file system on $rwdir from this shell
> + while ! sulogin && ! test -f /takeover
> + do
> + echo getty failed, retrying
> + done
Can we make this message a little more descriptive? Something like:
cat <<EOF
Failed to mount read/write filesystem (mtdblock${rwfs#mtd})
Please manually mount it on $rwdir from this shell, or
exit the shell to continue without a rw filesystem.
EOF
> diff --git a/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-shutdown.sh b/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-shutdown.sh
> new file mode 100644
> index 0000000..85fd1e9
> --- /dev/null
> +++ b/meta-phosphor/common/recipes-phosphor/obmc-phosphor-initfs/files/obmc-shutdown.sh
> @@ -0,0 +1,55 @@
Just to clarify: this shutdown script is completely separate from the
update mechanism, right? In what situations do you see it being used?
Cheers,
Jeremy
next prev parent reply other threads:[~2016-01-21 6:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 23:10 [PATCH openbmc 0/6] Persistent 1 OpenBMC Patches
2016-01-20 23:10 ` [PATCH openbmc 1/6] create obmc-phosphor-initfs OpenBMC Patches
2016-01-21 6:10 ` Jeremy Kerr [this message]
2016-01-20 23:10 ` [PATCH openbmc 2/6] phosphor: modify use obmc-phosphor-initfs OpenBMC Patches
2016-01-20 23:10 ` [PATCH openbmc 3/6] linux-obmc: apply the aspeed-spi-nor controller patchset OpenBMC Patches
2016-01-21 5:40 ` Jeremy Kerr
2016-01-21 16:06 ` Milton Miller II
2016-01-25 1:08 ` Andrew Donnellan
2016-01-20 23:10 ` [PATCH openbmc 4/6] u-boot : switch to repro, add fw_env.config OpenBMC Patches
2016-01-21 6:14 ` Jeremy Kerr
2016-01-21 23:17 ` Milton Miller II
2016-01-20 23:10 ` [PATCH openbmc 5/6] create u-boot-fw-utils for our u-boot version OpenBMC Patches
2016-01-25 0:42 ` Andrew Jeffery
2016-01-20 23:10 ` [PATCH openbmc 6/6] phosphor: Create image class image-overlay and move phosphor to use it OpenBMC Patches
2016-01-25 0:22 ` Andrew Jeffery
2016-01-22 2:16 ` [PATCH openbmc 0/6] Persistent 1 Stewart Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A07667.8020800@ozlabs.org \
--to=jk@ozlabs.org \
--cc=miltonm@us.ibm.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.