From: "Michel Dänzer" <michel@daenzer.net>
To: Mario Kleiner <mario.kleiner.de@gmail.com>
Cc: alexander.deucher@amd.com, daniel.vetter@ffwll.ch,
vbabka@suse.cz, dri-devel@lists.freedesktop.org,
christian.koenig@amd.com
Subject: Re: [PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble.
Date: Thu, 21 Jan 2016 17:25:11 +0900 [thread overview]
Message-ID: <56A095E7.8030303@daenzer.net> (raw)
In-Reply-To: <1453364174-11248-1-git-send-email-mario.kleiner.de@gmail.com>
On 21.01.2016 17:16, Mario Kleiner wrote:
>
> This patch replaces calls to drm_vblank_pre/post_modeset in the
> drivers dpms code with calls to drm_vblank_off/on, as recommended
> for drivers with hw counters that reset to zero during modeset.
Sounds like you fell for the drm_vblank_on/off propaganda. :( This was
working fine with drm_vblank_pre/post_modeset, that it broke is simply a
regression.
I'm not against switching to drm_vblank_on/off for 4.6, but it's not a
solution for older kernels.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-21 8:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 8:16 [PATCH 1/2] drm/radeon: Use drm_vblank_off/on to fix vblank counter trouble Mario Kleiner
2016-01-21 8:25 ` Michel Dänzer [this message]
2016-01-21 9:16 ` Mario Kleiner
2016-01-21 20:12 ` Ville Syrjälä
2016-01-22 3:17 ` Michel Dänzer
2016-01-22 17:08 ` Mario Kleiner
2016-02-07 11:05 ` Vlastimil Babka
2016-02-07 11:59 ` Mario Kleiner
2016-02-08 1:58 ` Mario Kleiner
2016-02-08 10:10 ` Vlastimil Babka
2016-01-21 10:24 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A095E7.8030303@daenzer.net \
--to=michel@daenzer.net \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=mario.kleiner.de@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.