From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vlastimil Babka Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Date: Thu, 21 Jan 2016 10:15:52 +0100 Message-ID: <56A0A1C8.40207@suse.cz> References: <5698CB20.9050602@suse.cz> <20160115122629.GC23290@intel.com> <5699C5E5.90702@gmail.com> <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A096B1.4060203@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D8B96EA4F for ; Thu, 21 Jan 2016 01:15:57 -0800 (PST) In-Reply-To: <56A096B1.4060203@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mario Kleiner , =?UTF-8?Q?Michel_D=c3=a4nzer?= , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= Cc: Daniel Vetter , LKML , dri-devel@lists.freedesktop.org, mgraesslin@kde.org, kwin@kde.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= List-Id: dri-devel@lists.freedesktop.org T24gMDEvMjEvMjAxNiAwOToyOCBBTSwgTWFyaW8gS2xlaW5lciB3cm90ZToKPj4gLi4uIGp1c3Qg bGlrZSBkcm1fdmJsYW5rX3ByZS9wb3N0X21vZGVzZXQuIFRoYXQgdGhvc2Ugd2VyZSBicm9rZW4g aXMgYQo+PiByZWdyZXNzaW9uIHdoaWNoIG5lZWRzIHRvIGJlIGZpeGVkIGFueXdheS4gSSBkb24n dCB0aGluayBzd2l0Y2hpbmcgdG8KPj4gZHJtX3ZibGFua19vbi9vZmYgaXMgc3VpdGFibGUgZm9y IHN0YWJsZSB0cmVlcy4KPj4KPj4gTG9va2luZyBhdCBWbGFzdGltaWwncyBvcmlnaW5hbCBwb3N0 IGFnYWluLCBJJ2Qgc2F5IHRoZSBtb3N0IGxpa2VseQo+PiBjdWxwcml0IGlzIDRkZmQ2NDg2ICgi ZHJtOiBVc2UgdmJsYW5rIHRpbWVzdGFtcHMgdG8gZ3Vlc3N0aW1hdGUgaG93IG1hbnkKPj4gdmJs YW5rcyB3ZXJlIG1pc3NlZCIpLgo+PgoKWWVhaCwgdGhpcyBpcyB3aGF0IEkgYmlzZWN0ZWQgdG8u Cgo+IFllcywgaSB0aGluayByZXZlcnRpbmcgdGhhdCBvbmUgYWxvbmUgd291bGQgbGlrZWx5IGZp eCBpdCBieSByZXZlcnRpbmcKPiB0byB0aGUgb2xkIHZibGFuayB1cGRhdGUgbG9naWMuCgpZZXAg SSBzYWlkIGluIHRoZSBvcmlnaW5hbCBtYWlsIHRoYXQgcmV2ZXJ0aW5nIG9uIHRvcCBvZiA0LjQg Zml4ZWQgaXQuIApXZWxsIG5vdCBqdXN0IHRoaXMgc2luZ2xlIGNvbW1pdCwgYnV0IGFsc28gc29t ZSBwYXRjaGVzIG9uIHRvcCAoZS5nLiAKcmFkZW9uIGFuZCBhbWRncHUgYWRhcHRhdGlvbnMgdG8g dGhhdCBjb21taXQsIElJUkMgaXQgd291bGRuJ3QgaGF2ZSAKY29tcGlsZWQgb3RoZXJ3aXNlKS4K Cj4+Cj4+PiBPbmNlIGRybV92Ymxhbmtfb2ZmIGlzIGNhbGxlZCwgZHJtX3ZibGFua19nZXQgd2ls bCBuby1vcCBhbmQgcmV0dXJuIGFuCj4+PiBlcnJvciwgc28gY2xpZW50cyBjYW4ndCBlbmFibGUg dmJsYW5rIGlycXMgZHVyaW5nIHRoZSBtb2Rlc2V0IC0gcGFnZWZsaXAKPj4+IGlvY3RsIGFuZCB3 YWl0dmJsYW5rIGlvY3RsIHdvdWxkIGZhaWwgd2hpbGUgYSBtb2Rlc2V0IGhhcHBlbnMgLQo+Pj4g aG9wZWZ1bGx5IHVzZXJzcGFjZSBoYW5kbGVzIHRoaXMgY29ycmVjdGx5IGV2ZXJ5d2hlcmUuCj4+ Cj4+IFdlJ3ZlIGZpeGVkIHhmODYtdmlkZW8tYXRpIGZvciB0aGlzLgo+Pgo+Pgo+Pj4gSSdsbCBo YWNrIHVwIGEgcGF0Y2ggZm9yIGRlbW9uc3RyYXRpb24gbm93Lgo+Pgo+PiBZb3UncmUgYSBiaXQg bGF0ZSB0byB0aGF0IHBhcnR5LiA6KQo+Pgo+PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE1LU1heS8wODM2MTQuaHRtbAo+PiBodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL2FyY2hpdmVzL2RyaS1kZXZlbC8yMDE1LUp1bHkvMDg2NDUxLmh0bWwK Pj4KPj4KPgo+IE9vcHMuIEp1c3Qgc2VudCBvdXQgbXkgbGl0dGxlIChzbyBmYXIgdW50ZXN0ZWQp IGNyZWF0aW9ucy4gWWVzLCB0aGV5IGFyZQo+IGVzc2VudGlhbGx5IHRoZSBzYW1lIGFzIERhbmll bCdzIHBhdGNoZXMuIFRoZSBvbmx5IGFkZGl0aW9uIGlzIHRvIGFsc28KPiBmaXggdGhhdCBvdGhl ciBwb3RlbnRpYWwgc21hbGwgcmFjZSBpIGRlc2NyaWJlIGJ5IHNsaWdodGx5IG1vdmluZyB0aGUK PiB4eHhfcG1fY29tcHV0ZV9jbG9ja3MoKSBjYWxscyBhcm91bmQuIEFuZCBhIGZpeCBmb3IgZHJt X3ZibGFua19nZXQvcHV0Cj4gaW1iYWxhbmNlIGluIHJhZGVvbl9wbSBpZiB2Ymxhbmtfb24vb2Zm IHdvdWxkIGJlIHVzZWQuCgpUaGFua3MsIEknbGwgdGVzdC4KCj4KPiAtbWFyaW8KPgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVl ZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759112AbcAUJQJ (ORCPT ); Thu, 21 Jan 2016 04:16:09 -0500 Received: from mx2.suse.de ([195.135.220.15]:54292 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbcAUJQA (ORCPT ); Thu, 21 Jan 2016 04:16:00 -0500 Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon To: Mario Kleiner , =?UTF-8?Q?Michel_D=c3=a4nzer?= , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= References: <5698CB20.9050602@suse.cz> <20160115122629.GC23290@intel.com> <5699C5E5.90702@gmail.com> <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A096B1.4060203@gmail.com> Cc: Daniel Vetter , LKML , dri-devel@lists.freedesktop.org, mgraesslin@kde.org, kwin@kde.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= From: Vlastimil Babka Message-ID: <56A0A1C8.40207@suse.cz> Date: Thu, 21 Jan 2016 10:15:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56A096B1.4060203@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2016 09:28 AM, Mario Kleiner wrote: >> ... just like drm_vblank_pre/post_modeset. That those were broken is a >> regression which needs to be fixed anyway. I don't think switching to >> drm_vblank_on/off is suitable for stable trees. >> >> Looking at Vlastimil's original post again, I'd say the most likely >> culprit is 4dfd6486 ("drm: Use vblank timestamps to guesstimate how many >> vblanks were missed"). >> Yeah, this is what I bisected to. > Yes, i think reverting that one alone would likely fix it by reverting > to the old vblank update logic. Yep I said in the original mail that reverting on top of 4.4 fixed it. Well not just this single commit, but also some patches on top (e.g. radeon and amdgpu adaptations to that commit, IIRC it wouldn't have compiled otherwise). >> >>> Once drm_vblank_off is called, drm_vblank_get will no-op and return an >>> error, so clients can't enable vblank irqs during the modeset - pageflip >>> ioctl and waitvblank ioctl would fail while a modeset happens - >>> hopefully userspace handles this correctly everywhere. >> >> We've fixed xf86-video-ati for this. >> >> >>> I'll hack up a patch for demonstration now. >> >> You're a bit late to that party. :) >> >> http://lists.freedesktop.org/archives/dri-devel/2015-May/083614.html >> http://lists.freedesktop.org/archives/dri-devel/2015-July/086451.html >> >> > > Oops. Just sent out my little (so far untested) creations. Yes, they are > essentially the same as Daniel's patches. The only addition is to also > fix that other potential small race i describe by slightly moving the > xxx_pm_compute_clocks() calls around. And a fix for drm_vblank_get/put > imbalance in radeon_pm if vblank_on/off would be used. Thanks, I'll test. > > -mario >