From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1759279AbcAUKd0 (ORCPT <rfc822;w@1wt.eu>);
	Thu, 21 Jan 2016 05:33:26 -0500
Received: from szxga03-in.huawei.com ([119.145.14.66]:25110 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1759165AbcAUKdW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 21 Jan 2016 05:33:22 -0500
Subject: Re: [PATCH v6 5/5] hisilicon/dts: Add hi655x pmic dts node
To: Mark Brown <broonie@kernel.org>
References: <1453185124-30809-1-git-send-email-puck.chen@hisilicon.com>
 <1453185124-30809-6-git-send-email-puck.chen@hisilicon.com>
 <20160120130813.GD6588@sirena.org.uk>
CC: <lee.jones@linaro.org>, <lgirdwood@gmail.com>,
        <linux-kernel@vger.kernel.org>, <yudongbin@hisilicon.com>,
        <saberlily.xia@hisilicon.com>, <suzhuangluan@hisilicon.com>,
        <kong.kongxinwei@hisilicon.com>, <xuyiping@hisilicon.com>,
        <z.liuxinliang@hisilicon.com>, <weidong2@hisilicon.com>,
        <w.f@huawei.com>, <puck.chen@foxmail.com>, <shimingxing@hisilicon.com>,
        <oliver.fu@hisilicon.com>, <albert.lubing@hisilicon.com>,
        <chenxiang9@huawei.com>, <liuzixing@huawei.com>,
        <haojian.zhuang@linaro.org>, <qijiwen@hisilicon.com>,
        <peter.panshilin@hisilicon.com>, <dan.zhao@hisilicon.com>,
        <linuxarm@huawei.com>, <dev@lists.96boards.org>
From: chenfeng <puck.chen@hisilicon.com>
Message-ID: <56A0B3C0.8030702@hisilicon.com>
Date: Thu, 21 Jan 2016 18:32:32 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <20160120130813.GD6588@sirena.org.uk>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.142.192.172]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020204.56A0B3F0.0046,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: dfe4aa1f0b0253f14b3253938f5363fa
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Mark,
On 2016/1/20 21:08, Mark Brown wrote:
> On Tue, Jan 19, 2016 at 02:32:04PM +0800, Chen Feng wrote:
> 
>> index 82d2488..6de9881 100644
>> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
>> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> 
>> +		regulators {
>> +			ldo2: ldo2@a21 {
>> +				regulator-compatible = "LDO2";
> 

I will change it like this:
                regulators {
                        ldo2: LDO2@a21 {
                                regulator-name = "ldo2";
                                regulator-min-microvolt = <2500000>;
                                regulator-max-microvolt = <3200000>;
                                regulator-valid-modes-mask = <0x02>;
                                regulator-enable-ramp-delay = <120>;
                        };

> Why are you using the legacy regulator-compatible property?  No new
> bindings should use this.
> 
>> +				regulator-min-microvolt = <2500000>;
>> +				regulator-max-microvolt = <3200000>;
> 
> This is broken as it misunderstands the purpose of specifying
> constraints.  The constraints are there to say what the safe and
> supported configuration is on a given board, it is not possible to
> provide this information safely in a general include that is used by all
> systems using the PMIC.  Specifying the maximum voltage range for the
> regulators is almost guaranteed to result in at least some
> configurations being enabled which will not work, in the worst case this
> may include configurations which could physically damage the system.
> 
> In general it is very unusual to include the regulators in a .dtsi since
> essentially all the configuration for them should be board specific.
> 
Do you mean that I should move this into dts and enable it by default?