From: Panu Matilainen <pmatilai@redhat.com>
To: wojciechx.andralojc@intel.com
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH v3] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR)...
Date: Thu, 21 Jan 2016 12:38:43 +0200 [thread overview]
Message-ID: <56A0B533.5060201@redhat.com> (raw)
In-Reply-To: <1453364287-37283-1-git-send-email-wojciechx.andralojc@intel.com>
On 01/21/2016 10:18 AM, Wojciech Andralojc wrote:
> Patch reworked.
>
> Signed-off-by: Wojciech Andralojc <wojciechx.andralojc@intel.com>
> ---
> lib/librte_eal/common/include/arch/x86/rte_msr.h | 88 +++++++++++++++++
> lib/librte_eal/linuxapp/eal/Makefile | 1 +
> lib/librte_eal/linuxapp/eal/arch/x86/rte_msr.c | 116 +++++++++++++++++++++++
> 3 files changed, 205 insertions(+)
> create mode 100644 lib/librte_eal/common/include/arch/x86/rte_msr.h
> create mode 100644 lib/librte_eal/linuxapp/eal/arch/x86/rte_msr.c
This creates a new arch-specific public API, with rte_msr.h installed as
a public header and implementation in the library (as opposed to
inline), and so the new functions would have to be added to
rte_eal_version.map.
However that is a bit of a problem since it only exists on IA
architectures, so it'd mean dummy entries in the version map for all
other architectures. All the other arch-specific APIs are inline code so
this is the first of its kind.
Jerin Jacob suggested [1] adding these as internal (inline) functions
which to me looks like a more sensible approach, arch-specific APIs tend
to be problematic.
[1] http://dpdk.org/ml/archives/dev/2016-January/031095.html
- Panu -
next prev parent reply other threads:[~2016-01-21 10:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-17 12:12 [PATCH] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR), rte_msr_read and rte_msr_write functions Wojciech Andralojc
2016-01-06 11:47 ` Andralojc, WojciechX
2016-01-06 17:33 ` Jerin Jacob
2016-01-20 10:56 ` [PATCH v2] Patch introducing API to read/write Intel Architecture Model Specific Registers (MSR) Wojciech Andralojc
2016-01-20 11:25 ` Ananyev, Konstantin
2016-01-21 8:18 ` [PATCH v3] " Wojciech Andralojc
2016-01-21 9:34 ` Thomas Monjalon
2016-01-21 10:38 ` Panu Matilainen [this message]
2016-01-21 10:51 ` Ananyev, Konstantin
2016-01-22 10:05 ` Panu Matilainen
2016-01-22 11:05 ` Ananyev, Konstantin
2016-01-22 11:37 ` Andralojc, WojciechX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A0B533.5060201@redhat.com \
--to=pmatilai@redhat.com \
--cc=dev@dpdk.org \
--cc=wojciechx.andralojc@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.