From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org (lists.s-osg.org. [54.187.51.154]) by gmr-mx.google.com with ESMTP id ui7si191458pab.0.2016.01.21.06.52.30 for ; Thu, 21 Jan 2016 06:52:30 -0800 (PST) Subject: [rtc-linux] Re: [PATCH 2/8] rtc: max77686: Use usleep_range() instead of msleep() To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org References: <1453310088-29985-1-git-send-email-javier@osg.samsung.com> <1453310088-29985-3-git-send-email-javier@osg.samsung.com> <56A02845.3010008@samsung.com> Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org From: Javier Martinez Canillas Message-ID: <56A0F0AA.6080202@osg.samsung.com> Date: Thu, 21 Jan 2016 11:52:26 -0300 MIME-Version: 1.0 In-Reply-To: <56A02845.3010008@samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , Hello Krzysztof, On 01/20/2016 09:37 PM, Krzysztof Kozlowski wrote: > On 21.01.2016 02:14, Javier Martinez Canillas wrote: >> Documentation/timers/timers-howto.txt suggest to use usleep_range() >> instead of msleep() for small msec (1ms - 20ms) since msleep() will >> often sleep for 20ms for any value in that range. >> >> This is fine in this case since 16ms is the _minimum_ delay required >> by max77686 for an RTC update but by using usleep_range() instead of >> msleep(), the driver can support other RTC IP blocks with a shorter >> minium delay (i.e: in the range of usecs insted of msecs). > > s/minium/minimum/ > s/insted/instead/ > Fixed. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> drivers/rtc/rtc-max77686.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > Reviewed-by: Krzysztof Kozlowski > Thanks a lot for your review. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Javier Martinez Canillas Subject: Re: [PATCH 2/8] rtc: max77686: Use usleep_range() instead of msleep() Date: Thu, 21 Jan 2016 11:52:26 -0300 Message-ID: <56A0F0AA.6080202@osg.samsung.com> References: <1453310088-29985-1-git-send-email-javier@osg.samsung.com> <1453310088-29985-3-git-send-email-javier@osg.samsung.com> <56A02845.3010008@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from lists.s-osg.org ([54.187.51.154]:33001 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965293AbcAUOwb (ORCPT ); Thu, 21 Jan 2016 09:52:31 -0500 In-Reply-To: <56A02845.3010008@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Laxman Dewangan , linux-samsung-soc@vger.kernel.org Hello Krzysztof, On 01/20/2016 09:37 PM, Krzysztof Kozlowski wrote: > On 21.01.2016 02:14, Javier Martinez Canillas wrote: >> Documentation/timers/timers-howto.txt suggest to use usleep_range() >> instead of msleep() for small msec (1ms - 20ms) since msleep() will >> often sleep for 20ms for any value in that range. >> >> This is fine in this case since 16ms is the _minimum_ delay required >> by max77686 for an RTC update but by using usleep_range() instead of >> msleep(), the driver can support other RTC IP blocks with a shorter >> minium delay (i.e: in the range of usecs insted of msecs). > > s/minium/minimum/ > s/insted/instead/ > Fixed. >> >> Signed-off-by: Javier Martinez Canillas >> --- >> >> drivers/rtc/rtc-max77686.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > Reviewed-by: Krzysztof Kozlowski > Thanks a lot for your review. > Best regards, > Krzysztof > Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America