From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57756) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMJF1-00049A-1L for qemu-devel@nongnu.org; Thu, 21 Jan 2016 12:41:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMJF0-0003cl-0H for qemu-devel@nongnu.org; Thu, 21 Jan 2016 12:41:50 -0500 References: <1453272694-17106-1-git-send-email-jsnow@redhat.com> <1453272694-17106-13-git-send-email-jsnow@redhat.com> From: Eric Blake Message-ID: <56A11854.40105@redhat.com> Date: Thu, 21 Jan 2016 10:41:40 -0700 MIME-Version: 1.0 In-Reply-To: <1453272694-17106-13-git-send-email-jsnow@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="qs3rDbrThNOgAil4roHWlrvvd1L98qqQs" Subject: Re: [Qemu-devel] [PATCH v4 12/12] fdc: change auto fallback drive for ISA FDC to 288 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --qs3rDbrThNOgAil4roHWlrvvd1L98qqQs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/19/2016 11:51 PM, John Snow wrote: > The 2.88 drive is more suitable as a default because > it can still read 1.44 images correctly, but the reverse > is not true. >=20 > Since there exist virtio-win drivers that are shipped on > 2.88 floppy images, this patch will allow VMs booted without > a floppy disk inserted to later insert a 2.88MB floppy and > have that work. >=20 > This patch has been tested with msdos, freedos, fedora, > windows 8 and windows 10 without issue: if problems do > arise for certain guests being unable to cope with 2.88MB > drives as the default, they are in the minority and can use > type=3D144 as needed (or insert a proper boot medium and omit > type=3D144/288 or use type=3Dauto) to obtain different drive types. >=20 > As icing, the default will remain auto/144 for any pre-2.6 > machine types, hopefully minimizing the impact of this change > in legacy hw to basically zero. >=20 > Signed-off-by: John Snow > --- > hw/block/fdc.c | 2 +- > include/hw/compat.h | 4 ++++ > 2 files changed, 5 insertions(+), 1 deletion(-) >=20 Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --qs3rDbrThNOgAil4roHWlrvvd1L98qqQs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWoRhUAAoJEKeha0olJ0Nq8pcIAJCOcFRQiS8kd9YpHf39AgqR FVuVb7HoiIe9amM/dkRCHUb8VWvvBx3t7qyZYHqkXkt9SATqpUXtyTCkdJ7TkFLh J9yFiMuJOMeJEMJoktnNoWtht5gluTohz8j/sGrkrqDLjnusfr6QISRQ7Yl0TkRO mziT8ReTWZSQ04uuGeDLq7x1hPrGWz5uwTqPt45OmHIv7hpEdKrP6deogtLq/3pa QWBMiM7qj7052AjKh+gLCpAxx3SKLCG/iLAiIUzW6QmrEIUlyrXOmlugeRHPFfeq lfeuk27sCQ1a+2KEFR4y4Qexmnl2GadZLztGljFv4Bh04Uj/COlwMFA5MjySjbE= =mkDQ -----END PGP SIGNATURE----- --qs3rDbrThNOgAil4roHWlrvvd1L98qqQs--