From: Sarah Newman <srn@prgmr.com>
To: Karel Zak <kzak@redhat.com>
Cc: "Wayne R. Roth" <wayneroth42@gmail.com>, util-linux@vger.kernel.org
Subject: Re: Re: [PATCH] mkswap: Add warnings for insecure device permissions/owners
Date: Thu, 21 Jan 2016 14:19:24 -0800 [thread overview]
Message-ID: <56A1596C.3060507@prgmr.com> (raw)
In-Reply-To: <20160120103042.clphjleuiesjrl52@ws.net.home>
On 01/20/2016 02:30 AM, Karel Zak wrote:
> On Tue, Jan 19, 2016 at 10:37:06AM -0800, Wayne R. Roth wrote:
>> Logic copied from sys-utils/swapon.c
>
> Why? I think swapon is the right place for this check.
>
> Karel
>
Hi Karel,
Warnings are probably best put in *both* mkswap and swapon for the following two reasons:
1. The person(s) reviewing the output for swapon may not be the same person(s) reviewing the output for mkswap. For example, this might happen with a
company with a separate development and quality assurance department.
2. To my best knowledge the release of mkswap and swapon do not have to match. An example of when this might happen is the build process for an
embedded device or virtual machine. I am pretty sure busybox does not warn on world readable swap right now.
This patch does not break any existing behavior. The worst case possibility from accepting this patch is it will annoy some people, and best case it
will save millions of devices from being shipped with insecure permissions.
Thanks, Sarah
next prev parent reply other threads:[~2016-01-21 22:28 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-19 18:37 [PATCH] mkswap: Add warnings for insecure device permissions/owners Wayne R. Roth
2016-01-19 19:44 ` Mike Frysinger
2016-01-20 4:17 ` [PATCH] mkswap: Add warnings for insecure device permissions/owners Logic modified from sys-utils/swapon.c Wayne R. Roth
2016-01-20 4:58 ` Mike Frysinger
2016-01-20 6:09 ` [PATCH] mkswap: add " Wayne R. Roth
2016-01-26 10:35 ` Karel Zak
2016-01-20 9:39 ` [PATCH] mkswap: Add warnings for insecure device permissions/owners Sami Kerola
2016-01-20 10:30 ` Karel Zak
2016-01-21 22:19 ` Sarah Newman [this message]
2016-01-22 16:01 ` Tilman Schmidt
2016-01-22 19:14 ` Sarah Newman
2016-01-22 22:03 ` Sami Kerola
2016-01-23 16:22 ` Karel Zak
2016-01-24 11:09 ` Sami Kerola
2016-01-25 19:55 ` Sami Kerola
2016-01-26 10:42 ` Karel Zak
2016-01-26 16:28 ` Sarah Newman
2016-01-25 21:39 ` Sarah Newman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A1596C.3060507@prgmr.com \
--to=srn@prgmr.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
--cc=wayneroth42@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.