From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v12.1 07/17] drm: rockchip: dp: add rockchip platform dp driver Date: Fri, 22 Jan 2016 09:37:08 +0800 Message-ID: <56A187C4.2030100@rock-chips.com> References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> <1453197893-13413-1-git-send-email-ykk@rock-chips.com> <7132332.jmLRiUjx3U@phil> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <7132332.jmLRiUjx3U@phil> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Heiko Stuebner Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Russell King , Ian Campbell , Jingoo Han , emil.l.velikov@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Kishon Vijay Abraham I , javier@osg.samsung.com, Kyungmin Park , Rob Herring , linux-rockchip@lists.infradead.org, Andy Yan , Thierry Reding , Gustavo Padovan , linux-arm-kernel@lists.infradead.org List-Id: linux-rockchip.vger.kernel.org SGkgSGVpa28sCgpPbiAwMS8yMi8yMDE2IDAzOjExIEFNLCBIZWlrbyBTdHVlYm5lciB3cm90ZToK PiBIaSBZYWtpciwKPgo+IEFtIERpZW5zdGFnLCAxOS4gSmFudWFyIDIwMTYsIDE4OjA0OjUzIHNj aHJpZWIgWWFraXIgWWFuZzoKPj4gUm9ja2NoaXAgaGF2ZSB0aHJlZSBjbG9ja3MgZm9yIGRwIGNv bnRyb2xsZXIsIHdlIGxlYXZlIHBjbGtfZWRwCj4+IHRvIGFuYWxvZ2l4X2RwIGRyaXZlciBjb250 cm9sLCBhbmQga2VlcCB0aGUgc2Nsa19lZHBfMjRtIGFuZAo+PiBzY2xrX2VkcCBpbiBwbGF0Zm9y bSBkcml2ZXIuCj4+Cj4+IFNpZ25lZC1vZmYtYnk6IFlha2lyIFlhbmcgPHlra0Byb2NrLWNoaXBz LmNvbT4KPj4gVGVzdGVkLWJ5OiBKYXZpZXIgTWFydGluZXogQ2FuaWxsYXMgPGphdmllckBvc2cu c2Ftc3VuZy5jb20+Cj4+IC0tLQo+IFsuLi5dCj4KPj4gK3N0YXRpYyBpbnQgcm9ja2NoaXBfZHBf ZHJtX2NyZWF0ZV9lbmNvZGVyKHN0cnVjdCByb2NrY2hpcF9kcF9kZXZpY2UgKmRwKQo+PiArewo+ PiArCXN0cnVjdCBkcm1fZW5jb2RlciAqZW5jb2RlciA9ICZkcC0+ZW5jb2RlcjsKPj4gKwlzdHJ1 Y3QgZHJtX2RldmljZSAqZHJtX2RldiA9IGRwLT5kcm1fZGV2Owo+PiArCXN0cnVjdCBkZXZpY2Ug KmRldiA9IGRwLT5kZXY7Cj4+ICsJaW50IHJldDsKPj4gKwo+PiArCWVuY29kZXItPnBvc3NpYmxl X2NydGNzID0gZHJtX29mX2ZpbmRfcG9zc2libGVfY3J0Y3MoZHJtX2RldiwKPj4gKwkJCQkJCQkg ICAgIGRldi0+b2Zfbm9kZSk7Cj4+ICsJRFJNX0RFQlVHX0tNUygicG9zc2libGVfY3J0Y3MgPSAw eCV4XG4iLCBlbmNvZGVyLT5wb3NzaWJsZV9jcnRjcyk7Cj4+ICsKPj4gKwlyZXQgPSBkcm1fZW5j b2Rlcl9pbml0KGRybV9kZXYsIGVuY29kZXIsICZyb2NrY2hpcF9kcF9lbmNvZGVyX2Z1bmNzLAo+ PiArCQkJICAgICAgIERSTV9NT0RFX0VOQ09ERVJfVE1EUyk7Cj4gc2hvdWxkIGJlCj4gKwkJCSAg ICAgICBEUk1fTU9ERV9FTkNPREVSX1RNRFMsIE5VTEwpOwoKT3BzLCAgOi18Cgo+IEV4eW5vcy1z aWRlIHNlZW1zIHRvIGJlIG9rIHRob3VnaC4KPgo+IFdpdGggdGhlIGFkYXB0ZWQgdjEyLjEgcGF0 Y2hlcyBpdCBhcHBsaWVzIGNsZWFubHkgYW5kIGRpc3BsYXkgaXMgd29ya2luZyBhcwo+IHdlbGwu IFNvIHdpdGggdGhlIHRoaW5nIGFib3ZlIGZpeGVkLCB5b3UgY291bGQgcmVzdWJtaXQgYSBmdWxs IHYxMywKPiBlc3BlY2lhbGx5IGFzIHlvdSB3YW50IHRvIGRyb3AgcGF0Y2ggMTYgYXMgZGlzY3Vz c2VkIHRoZXJlLgoKR290IGl0IDopCgpUaGFua3MsCllha2lyCj4KPiBIZWlrbwo+Cj4KPgoKCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBt YWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMu ZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Fri, 22 Jan 2016 09:37:08 +0800 Subject: [PATCH v12.1 07/17] drm: rockchip: dp: add rockchip platform dp driver In-Reply-To: <7132332.jmLRiUjx3U@phil> References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> <1453197893-13413-1-git-send-email-ykk@rock-chips.com> <7132332.jmLRiUjx3U@phil> Message-ID: <56A187C4.2030100@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Heiko, On 01/22/2016 03:11 AM, Heiko Stuebner wrote: > Hi Yakir, > > Am Dienstag, 19. Januar 2016, 18:04:53 schrieb Yakir Yang: >> Rockchip have three clocks for dp controller, we leave pclk_edp >> to analogix_dp driver control, and keep the sclk_edp_24m and >> sclk_edp in platform driver. >> >> Signed-off-by: Yakir Yang >> Tested-by: Javier Martinez Canillas >> --- > [...] > >> +static int rockchip_dp_drm_create_encoder(struct rockchip_dp_device *dp) >> +{ >> + struct drm_encoder *encoder = &dp->encoder; >> + struct drm_device *drm_dev = dp->drm_dev; >> + struct device *dev = dp->dev; >> + int ret; >> + >> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm_dev, >> + dev->of_node); >> + DRM_DEBUG_KMS("possible_crtcs = 0x%x\n", encoder->possible_crtcs); >> + >> + ret = drm_encoder_init(drm_dev, encoder, &rockchip_dp_encoder_funcs, >> + DRM_MODE_ENCODER_TMDS); > should be > + DRM_MODE_ENCODER_TMDS, NULL); Ops, :-| > Exynos-side seems to be ok though. > > With the adapted v12.1 patches it applies cleanly and display is working as > well. So with the thing above fixed, you could resubmit a full v13, > especially as you want to drop patch 16 as discussed there. Got it :) Thanks, Yakir > > Heiko > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751531AbcAVBh1 (ORCPT ); Thu, 21 Jan 2016 20:37:27 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:35944 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750951AbcAVBhS (ORCPT ); Thu, 21 Jan 2016 20:37:18 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <30e0b645cca95a27bd3ad358d36870be> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v12.1 07/17] drm: rockchip: dp: add rockchip platform dp driver To: Heiko Stuebner References: <1450873538-18304-1-git-send-email-ykk@rock-chips.com> <1453197893-13413-1-git-send-email-ykk@rock-chips.com> <7132332.jmLRiUjx3U@phil> Cc: Inki Dae , Kyungmin Park , Jingoo Han , Thierry Reding , Krzysztof Kozlowski , Rob Herring , Mark Yao , Russell King , emil.l.velikov@gmail.com, Ian Campbell , Gustavo Padovan , Kishon Vijay Abraham I , javier@osg.samsung.com, Andy Yan , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <56A187C4.2030100@rock-chips.com> Date: Fri, 22 Jan 2016 09:37:08 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <7132332.jmLRiUjx3U@phil> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On 01/22/2016 03:11 AM, Heiko Stuebner wrote: > Hi Yakir, > > Am Dienstag, 19. Januar 2016, 18:04:53 schrieb Yakir Yang: >> Rockchip have three clocks for dp controller, we leave pclk_edp >> to analogix_dp driver control, and keep the sclk_edp_24m and >> sclk_edp in platform driver. >> >> Signed-off-by: Yakir Yang >> Tested-by: Javier Martinez Canillas >> --- > [...] > >> +static int rockchip_dp_drm_create_encoder(struct rockchip_dp_device *dp) >> +{ >> + struct drm_encoder *encoder = &dp->encoder; >> + struct drm_device *drm_dev = dp->drm_dev; >> + struct device *dev = dp->dev; >> + int ret; >> + >> + encoder->possible_crtcs = drm_of_find_possible_crtcs(drm_dev, >> + dev->of_node); >> + DRM_DEBUG_KMS("possible_crtcs = 0x%x\n", encoder->possible_crtcs); >> + >> + ret = drm_encoder_init(drm_dev, encoder, &rockchip_dp_encoder_funcs, >> + DRM_MODE_ENCODER_TMDS); > should be > + DRM_MODE_ENCODER_TMDS, NULL); Ops, :-| > Exynos-side seems to be ok though. > > With the adapted v12.1 patches it applies cleanly and display is working as > well. So with the thing above fixed, you could resubmit a full v13, > especially as you want to drop patch 16 as discussed there. Got it :) Thanks, Yakir > > Heiko > > >