From: "Michel Dänzer" <michel@daenzer.net>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH 2/3] drm/radeon: Switch to drm_vblank_on/off
Date: Fri, 22 Jan 2016 12:20:42 +0900 [thread overview]
Message-ID: <56A1A00A.7040807@daenzer.net> (raw)
In-Reply-To: <1453370938-5464-2-git-send-email-daniel.vetter@ffwll.ch>
On 21.01.2016 19:08, Daniel Vetter wrote:
> These should be functionally equivalent to the older per/post modeset
> functions, except that they block out drm_vblank_get right away.
> There's only the clock adjusting code (outside of pageflips) in
> readone which uses drm_vblank_get. But that code doesn't synchronize
> against concurrent modesets and instead handles any such races by
> waiting for the right vblank to arrive with a short timetout.
>
> The longer-term plan here is to switch all kms drivers to
> drm_vblank_on/off so that common code like pending event cleanup can
> be done there, while drm_vblank_pre/post_modeset will be purely
> drm internal for the old UMS ioctl.
>
> Note that with this patch Michel uncovered a bug in the dri3
> implementation of the DDX (it does vblank waits when the pipe is off),
> which had to be fixed first.
>
> Cc: Michel Dänzer <michel.daenzer@amd.com>
> Acked-and-tested-by: Michel Dänzer <michel.daenzer@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Note that this should be rebased onto Mario's PM fixes, but those might
go to 4.5 / stable anyway.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-01-22 3:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 10:08 [PATCH 1/3] drm/nouveau: Use drm_vblank_on/off consistently Daniel Vetter
2016-01-21 10:08 ` [PATCH 2/3] drm/radeon: Switch to drm_vblank_on/off Daniel Vetter
2016-01-22 3:20 ` Michel Dänzer [this message]
2016-01-21 10:08 ` [PATCH 3/3] drm/amdgpu: " Daniel Vetter
2016-01-22 3:23 ` Michel Dänzer
2016-01-22 2:14 ` [PATCH 1/3] drm/nouveau: Use drm_vblank_on/off consistently Michel Dänzer
-- strict thread matches above, loose matches on Subject: below --
2015-05-27 9:04 Daniel Vetter
2015-05-27 9:04 ` [PATCH 2/3] drm/radeon: Switch to drm_vblank_on/off Daniel Vetter
2015-05-27 9:21 ` Michel Dänzer
2015-05-27 9:41 ` Daniel Vetter
2015-05-28 7:11 ` Michel Dänzer
2015-05-28 8:38 ` Daniel Vetter
2015-05-28 9:03 ` Michel Dänzer
2015-07-14 8:13 ` Michel Dänzer
2015-08-07 7:26 ` Michel Dänzer
2015-08-07 7:52 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A1A00A.7040807@daenzer.net \
--to=michel@daenzer.net \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.