From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752833AbcAVIAu (ORCPT ); Fri, 22 Jan 2016 03:00:50 -0500 Received: from mail-pf0-f196.google.com ([209.85.192.196]:34445 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752748AbcAVIAl (ORCPT ); Fri, 22 Jan 2016 03:00:41 -0500 Subject: Re: [PATCH v13 05/23] perf config: Document variables for 'help' section in man page To: Arnaldo Carvalho de Melo References: <1452253193-30502-1-git-send-email-treeze.taeung@gmail.com> <1452253193-30502-6-git-send-email-treeze.taeung@gmail.com> <20160121144641.GB4034@kernel.org> Cc: linux-kernel@vger.kernel.org, Jiri Olsa , Namhyung Kim , Ingo Molnar From: Taeung Song Message-ID: <56A1E1A5.8090109@gmail.com> Date: Fri, 22 Jan 2016 17:00:37 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160121144641.GB4034@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/21/2016 11:46 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Jan 08, 2016 at 08:39:35PM +0900, Taeung Song escreveu: >> Explain 'help.format' variables. >> >> Cc: Namhyung Kim >> Cc: Jiri Olsa >> Signed-off-by: Taeung Song >> --- >> tools/perf/Documentation/perf-config.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt >> index 85b811f..aaf1791 100644 >> --- a/tools/perf/Documentation/perf-config.txt >> +++ b/tools/perf/Documentation/perf-config.txt >> @@ -278,6 +278,10 @@ annotate.*:: >> >> 99.93 │ mov %eax,%eax >> >> +help.*:: >> + help.format:: >> + A format of manual page can be 'man' that is default. >> + > > Huh? If this is the case, i.e. we have something that is configurable > but admits only one option, maybe we should trow this alltogether and > remove the need to document it? :-) > Hum.. I think so. I tested config variables 'help.format' and 'man.viewer', again. Selecting which manual page viewer can be done by both this config variables. So IMHO I think even if 'help.format' is removed, it hasn't problem because this functionality is duplicated. And I think it seems to be tidy that the whole 'help' section is removed or just don't document it on perf-config doc. Would I keep working on perf-config patchkit excluding 'help' section ? Thanks, Taeung