From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhongkaihua@huawei.com (Zhong Kaihua) Date: Fri, 22 Jan 2016 16:59:01 +0800 Subject: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes In-Reply-To: <569E3C0F.3040603@arm.com> References: <1453200681-26406-1-git-send-email-zhongkaihua@huawei.com> <569E3C0F.3040603@arm.com> Message-ID: <56A1EF55.5000909@huawei.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 2016/1/19 21:37, Sudeep Holla wrote: > > > On 19/01/16 10:51, Zhong Kaihua wrote: >> arm64: dts: Add Hi6220 gpio configuration nodes >> >> Signed-off-by: Zhong Kaihua >> Kong Xinwei >> >> Acked-by: Rob Herring >> --- >> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 + >> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 259 +++++++++ >> arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi | 607 +++++++++++++++++++++ >> 4 files changed, 890 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> new file mode 100644 >> index 0000000..a9cbf21 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> @@ -0,0 +1,23 @@ >> +Hisilicon Hi6220 GPIO controller bindings >> + >> +Required properties: >> + - compatible: "arm,pl061","arm,primecell" >> + - gpio-controller: Marks the device node as a GPIO controller. >> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a >> + description of the cells format. >> + - interrupt-controller: Mark the device node as an interrupt controller >> + > > Why do you need extra binding document here as the compatible is same as > [1] ? You can extend that if required and add example there IMO. > Ok, I will remove the binding document in the next version. Thanks. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhong Kaihua Subject: Re: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes Date: Fri, 22 Jan 2016 16:59:01 +0800 Message-ID: <56A1EF55.5000909@huawei.com> References: <1453200681-26406-1-git-send-email-zhongkaihua@huawei.com> <569E3C0F.3040603@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <569E3C0F.3040603-5wv7dgnIgG8@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sudeep Holla Cc: robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, pawel.moll-5wv7dgnIgG8@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org, galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org, catalin.marinas-5wv7dgnIgG8@public.gmane.org, will.deacon-5wv7dgnIgG8@public.gmane.org, xuyiping-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, xuwei5-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, bintian.wang-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, haojian.zhuang-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, puck.chen-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, w.f-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, dan.zhao-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org, kong.kongxinwei-C8/M+/jPZTeaMJb+Lgu22Q@public.gmane.org List-Id: devicetree@vger.kernel.org On 2016/1/19 21:37, Sudeep Holla wrote: > > > On 19/01/16 10:51, Zhong Kaihua wrote: >> arm64: dts: Add Hi6220 gpio configuration nodes >> >> Signed-off-by: Zhong Kaihua >> Kong Xinwei >> >> Acked-by: Rob Herring >> --- >> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 + >> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 259 +++++++++ >> arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi | 607 +++++++++++++++++++++ >> 4 files changed, 890 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> new file mode 100644 >> index 0000000..a9cbf21 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> @@ -0,0 +1,23 @@ >> +Hisilicon Hi6220 GPIO controller bindings >> + >> +Required properties: >> + - compatible: "arm,pl061","arm,primecell" >> + - gpio-controller: Marks the device node as a GPIO controller. >> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a >> + description of the cells format. >> + - interrupt-controller: Mark the device node as an interrupt controller >> + > > Why do you need extra binding document here as the compatible is same as > [1] ? You can extend that if required and add example there IMO. > Ok, I will remove the binding document in the next version. Thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752877AbcAVI7v (ORCPT ); Fri, 22 Jan 2016 03:59:51 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:22776 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751913AbcAVI7n (ORCPT ); Fri, 22 Jan 2016 03:59:43 -0500 Message-ID: <56A1EF55.5000909@huawei.com> Date: Fri, 22 Jan 2016 16:59:01 +0800 From: Zhong Kaihua User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130509 Thunderbird/17.0.6 MIME-Version: 1.0 To: Sudeep Holla CC: , , , , , , , , , , , , , , , , , Subject: Re: [PATCH V3 1/3] arm64: dts: Add Hi6220 gpio configuration nodes References: <1453200681-26406-1-git-send-email-zhongkaihua@huawei.com> <569E3C0F.3040603@arm.com> In-Reply-To: <569E3C0F.3040603@arm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.142.146.73] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.56A1EF72.002A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: abcad686dfba6c6fb95bba52df13f785 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016/1/19 21:37, Sudeep Holla wrote: > > > On 19/01/16 10:51, Zhong Kaihua wrote: >> arm64: dts: Add Hi6220 gpio configuration nodes >> >> Signed-off-by: Zhong Kaihua >> Kong Xinwei >> >> Acked-by: Rob Herring >> --- >> .../devicetree/bindings/gpio/gpio-hi6220.txt | 23 + >> arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + >> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 259 +++++++++ >> arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi | 607 +++++++++++++++++++++ >> 4 files changed, 890 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> create mode 100644 arch/arm64/boot/dts/hisilicon/hikey-gpio.dtsi >> >> diff --git a/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> new file mode 100644 >> index 0000000..a9cbf21 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/gpio/gpio-hi6220.txt >> @@ -0,0 +1,23 @@ >> +Hisilicon Hi6220 GPIO controller bindings >> + >> +Required properties: >> + - compatible: "arm,pl061","arm,primecell" >> + - gpio-controller: Marks the device node as a GPIO controller. >> + - #gpio-cells: Should be 2. See gpio.txt in this directory for a >> + description of the cells format. >> + - interrupt-controller: Mark the device node as an interrupt controller >> + > > Why do you need extra binding document here as the compatible is same as > [1] ? You can extend that if required and add example there IMO. > Ok, I will remove the binding document in the next version. Thanks.