From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from hqemgate15.nvidia.com (hqemgate15.nvidia.com. [216.228.121.64]) by gmr-mx.google.com with ESMTPS id tn7si655753pac.1.2016.01.22.01.51.54 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jan 2016 01:51:54 -0800 (PST) Message-ID: <56A1F935.2040904@nvidia.com> Date: Fri, 22 Jan 2016 15:11:09 +0530 From: Laxman Dewangan MIME-Version: 1.0 To: Javier Martinez Canillas , CC: Kukjin Kim , , Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Subject: [rtc-linux] Re: [PATCH v2 03/10] rtc: max77686: Use usleep_range() instead of msleep() References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-4-git-send-email-javier@osg.samsung.com> In-Reply-To: <1453407813-14646-4-git-send-email-javier@osg.samsung.com> Content-Type: text/plain; charset=UTF-8; format=flowed Reply-To: rtc-linux@googlegroups.com List-ID: List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: > RTC_SEC = 0, > @@ -130,7 +130,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, > __func__, ret, data); > else { > /* Minimum 16ms delay required before RTC update. */ > - msleep(MAX77686_RTC_UPDATE_DELAY); > + usleep_range(MAX77686_RTC_UPDATE_DELAY, > + MAX77686_RTC_UPDATE_DELAY * 2); > } > Instead of making usleep_range(16000, 32000), can we make small range as usleep_range(16000, 17000)? I am using as usleep_range(16000, 16000) always. -- -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laxman Dewangan Subject: Re: [PATCH v2 03/10] rtc: max77686: Use usleep_range() instead of msleep() Date: Fri, 22 Jan 2016 15:11:09 +0530 Message-ID: <56A1F935.2040904@nvidia.com> References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-4-git-send-email-javier@osg.samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from hqemgate15.nvidia.com ([216.228.121.64]:10230 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752502AbcAVJvy (ORCPT ); Fri, 22 Jan 2016 04:51:54 -0500 In-Reply-To: <1453407813-14646-4-git-send-email-javier@osg.samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Javier Martinez Canillas , linux-kernel@vger.kernel.org Cc: Kukjin Kim , rtc-linux@googlegroups.com, Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: > RTC_SEC = 0, > @@ -130,7 +130,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, > __func__, ret, data); > else { > /* Minimum 16ms delay required before RTC update. */ > - msleep(MAX77686_RTC_UPDATE_DELAY); > + usleep_range(MAX77686_RTC_UPDATE_DELAY, > + MAX77686_RTC_UPDATE_DELAY * 2); > } > Instead of making usleep_range(16000, 32000), can we make small range as usleep_range(16000, 17000)? I am using as usleep_range(16000, 16000) always. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752879AbcAVJwC (ORCPT ); Fri, 22 Jan 2016 04:52:02 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:10230 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752502AbcAVJvy (ORCPT ); Fri, 22 Jan 2016 04:51:54 -0500 X-PGP-Universal: processed; by hqnvupgp08.nvidia.com on Fri, 22 Jan 2016 01:53:00 -0800 Message-ID: <56A1F935.2040904@nvidia.com> Date: Fri, 22 Jan 2016 15:11:09 +0530 From: Laxman Dewangan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Javier Martinez Canillas , CC: Kukjin Kim , , Chanwoo Choi , Alexandre Belloni , Krzysztof Kozlowski , Subject: Re: [PATCH v2 03/10] rtc: max77686: Use usleep_range() instead of msleep() References: <1453407813-14646-1-git-send-email-javier@osg.samsung.com> <1453407813-14646-4-git-send-email-javier@osg.samsung.com> In-Reply-To: <1453407813-14646-4-git-send-email-javier@osg.samsung.com> X-Originating-IP: [10.19.65.30] X-ClientProxiedBy: DRUKMAIL101.nvidia.com (10.25.59.19) To bgmail102.nvidia.com (10.25.59.11) Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 22 January 2016 01:53 AM, Javier Martinez Canillas wrote: > RTC_SEC = 0, > @@ -130,7 +130,8 @@ static int max77686_rtc_update(struct max77686_rtc_info *info, > __func__, ret, data); > else { > /* Minimum 16ms delay required before RTC update. */ > - msleep(MAX77686_RTC_UPDATE_DELAY); > + usleep_range(MAX77686_RTC_UPDATE_DELAY, > + MAX77686_RTC_UPDATE_DELAY * 2); > } > Instead of making usleep_range(16000, 32000), can we make small range as usleep_range(16000, 17000)? I am using as usleep_range(16000, 16000) always.