From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40450) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMZed-0001G6-NK for qemu-devel@nongnu.org; Fri, 22 Jan 2016 06:13:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMZeZ-000231-8W for qemu-devel@nongnu.org; Fri, 22 Jan 2016 06:13:23 -0500 Received: from e06smtp13.uk.ibm.com ([195.75.94.109]:37670) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMZeY-00022w-Vy for qemu-devel@nongnu.org; Fri, 22 Jan 2016 06:13:19 -0500 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 22 Jan 2016 11:13:17 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 3B7E817D8042 for ; Fri, 22 Jan 2016 11:13:21 +0000 (GMT) Received: from d06av03.portsmouth.uk.ibm.com (d06av03.portsmouth.uk.ibm.com [9.149.37.213]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u0MBDEog50069578 for ; Fri, 22 Jan 2016 11:13:14 GMT Received: from d06av03.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av03.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u0MBDDwS032278 for ; Fri, 22 Jan 2016 04:13:14 -0700 References: <1453396734-9363-1-git-send-email-clg@fr.ibm.com> <1453396734-9363-7-git-send-email-clg@fr.ibm.com> <20160122120725.527647af@bahia.huguette.org> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <56A20EBF.2070408@fr.ibm.com> Date: Fri, 22 Jan 2016 12:13:03 +0100 MIME-Version: 1.0 In-Reply-To: <20160122120725.527647af@bahia.huguette.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 6/9] ipmi: add get and set SENSOR_TYPE commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Greg Kurz Cc: Corey Minyard , qemu-devel@nongnu.org, Marcel Apfelbaum , "Michael S. Tsirkin" On 01/22/2016 12:07 PM, Greg Kurz wrote: > On Thu, 21 Jan 2016 18:18:51 +0100 > Cédric Le Goater wrote: > >> Signed-off-by: Cédric Le Goater >> Acked-by: Corey Minyard >> --- > > Reviewed-by: Greg Kurz > > Just two nits below. > >> hw/ipmi/ipmi_bmc_sim.c | 45 ++++++++++++++++++++++++++++++++++++++++++++- >> 1 file changed, 44 insertions(+), 1 deletion(-) >> >> diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c >> index 803c7e5130c0..7c0f2a1d9799 100644 >> --- a/hw/ipmi/ipmi_bmc_sim.c >> +++ b/hw/ipmi/ipmi_bmc_sim.c >> @@ -42,6 +42,8 @@ >> #define IPMI_CMD_REARM_SENSOR_EVTS 0x2a >> #define IPMI_CMD_GET_SENSOR_EVT_STATUS 0x2b >> #define IPMI_CMD_GET_SENSOR_READING 0x2d >> +#define IPMI_CMD_SET_SENSOR_TYPE 0x2e >> +#define IPMI_CMD_GET_SENSOR_TYPE 0x2f >> >> /* #define IPMI_NETFN_APP 0x06 In ipmi.h */ >> >> @@ -1527,6 +1529,45 @@ static void get_sensor_reading(IPMIBmcSim *ibs, >> } >> } >> >> +static void set_sensor_type(IPMIBmcSim *ibs, >> + uint8_t *cmd, unsigned int cmd_len, >> + uint8_t *rsp, unsigned int *rsp_len, >> + unsigned int max_rsp_len) >> +{ >> + IPMISensor *sens; >> + >> + >> + IPMI_CHECK_CMD_LEN(5); >> + if ((cmd[2] > MAX_SENSORS) || > > This has been a recurring remark on many patches lately, and all the people > don't necessarily agree but the extra parenthesis are not needed here... Damn. Am I contaminated ? :) C. >> + !IPMI_SENSOR_GET_PRESENT(ibs->sensors + cmd[2])) { >> + rsp[2] = IPMI_CC_REQ_ENTRY_NOT_PRESENT; >> + return; >> + } >> + sens = ibs->sensors + cmd[2]; >> + sens->sensor_type = cmd[3]; >> + sens->evt_reading_type_code = cmd[4] & 0x7f; >> +} >> + >> +static void get_sensor_type(IPMIBmcSim *ibs, >> + uint8_t *cmd, unsigned int cmd_len, >> + uint8_t *rsp, unsigned int *rsp_len, >> + unsigned int max_rsp_len) >> +{ >> + IPMISensor *sens; >> + >> + >> + IPMI_CHECK_CMD_LEN(3); >> + if ((cmd[2] > MAX_SENSORS) || > > and here. > >> + !IPMI_SENSOR_GET_PRESENT(ibs->sensors + cmd[2])) { >> + rsp[2] = IPMI_CC_REQ_ENTRY_NOT_PRESENT; >> + return; >> + } >> + sens = ibs->sensors + cmd[2]; >> + IPMI_ADD_RSP_DATA(sens->sensor_type); >> + IPMI_ADD_RSP_DATA(sens->evt_reading_type_code); >> +} >> + >> + >> static const IPMICmdHandler chassis_cmds[] = { >> [IPMI_CMD_GET_CHASSIS_CAPABILITIES] = chassis_capabilities, >> [IPMI_CMD_GET_CHASSIS_STATUS] = chassis_status, >> @@ -1542,7 +1583,9 @@ static const IPMICmdHandler sensor_event_cmds[] = { >> [IPMI_CMD_GET_SENSOR_EVT_ENABLE] = get_sensor_evt_enable, >> [IPMI_CMD_REARM_SENSOR_EVTS] = rearm_sensor_evts, >> [IPMI_CMD_GET_SENSOR_EVT_STATUS] = get_sensor_evt_status, >> - [IPMI_CMD_GET_SENSOR_READING] = get_sensor_reading >> + [IPMI_CMD_GET_SENSOR_READING] = get_sensor_reading, >> + [IPMI_CMD_SET_SENSOR_TYPE] = set_sensor_type, >> + [IPMI_CMD_GET_SENSOR_TYPE] = get_sensor_type, >> }; >> static const IPMINetfn sensor_event_netfn = { >> .cmd_nums = ARRAY_SIZE(sensor_event_cmds), >