From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42314) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMZmm-0005Xs-GW for qemu-devel@nongnu.org; Fri, 22 Jan 2016 06:21:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMZmh-0003tn-K6 for qemu-devel@nongnu.org; Fri, 22 Jan 2016 06:21:48 -0500 Received: from mail-wm0-x231.google.com ([2a00:1450:400c:c09::231]:38188) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMZmh-0003te-C0 for qemu-devel@nongnu.org; Fri, 22 Jan 2016 06:21:43 -0500 Received: by mail-wm0-x231.google.com with SMTP id b14so126961076wmb.1 for ; Fri, 22 Jan 2016 03:21:43 -0800 (PST) Sender: Paolo Bonzini References: <1453395690-32660-10-git-send-email-stefano.stabellini@eu.citrix.com> From: Paolo Bonzini Message-ID: <56A210C4.9040407@redhat.com> Date: Fri, 22 Jan 2016 12:21:40 +0100 MIME-Version: 1.0 In-Reply-To: <1453395690-32660-10-git-send-email-stefano.stabellini@eu.citrix.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PULL 10/11] Add Error **errp for xen_pt_config_init() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefano Stabellini , peter.maydell@linaro.org Cc: Cao jin , xen-devel@lists.xensource.com, qemu-devel@nongnu.org On 21/01/2016 18:01, Stefano Stabellini wrote: > - XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld reg 0x%x in grp_type=0x%x (%d/%ld), rc=%d\n", > - j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs), > - regs->offset, xen_pt_emu_reg_grps[i].grp_type, > - i, ARRAY_SIZE(xen_pt_emu_reg_grps), rc); > + xen_pt_config_reg_init(s, reg_grp_entry, regs, &err); > + if (err) { > + error_append_hint(&err, "Failed to initialize %d/%zu" > + " reg 0x%x in grp_type = 0x%x (%d/%zu)", > + j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs), Coverity noticed a preexisting problem here. emu_regs is a pointer, thus ARRAY_SIZE doesn't return what you expect. Paolo > + regs->offset, xen_pt_emu_reg_grps[i].grp_type, > + i, ARRAY_SIZE(xen_pt_emu_reg_grps)); > + error_propagate(errp, err); From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PULL 10/11] Add Error **errp for xen_pt_config_init() Date: Fri, 22 Jan 2016 12:21:40 +0100 Message-ID: <56A210C4.9040407@redhat.com> References: <1453395690-32660-10-git-send-email-stefano.stabellini@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1453395690-32660-10-git-send-email-stefano.stabellini@eu.citrix.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefano Stabellini , peter.maydell@linaro.org Cc: Cao jin , xen-devel@lists.xensource.com, qemu-devel@nongnu.org List-Id: xen-devel@lists.xenproject.org On 21/01/2016 18:01, Stefano Stabellini wrote: > - XEN_PT_LOG(&s->dev, "Failed to initialize %d/%ld reg 0x%x in grp_type=0x%x (%d/%ld), rc=%d\n", > - j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs), > - regs->offset, xen_pt_emu_reg_grps[i].grp_type, > - i, ARRAY_SIZE(xen_pt_emu_reg_grps), rc); > + xen_pt_config_reg_init(s, reg_grp_entry, regs, &err); > + if (err) { > + error_append_hint(&err, "Failed to initialize %d/%zu" > + " reg 0x%x in grp_type = 0x%x (%d/%zu)", > + j, ARRAY_SIZE(xen_pt_emu_reg_grps[i].emu_regs), Coverity noticed a preexisting problem here. emu_regs is a pointer, thus ARRAY_SIZE doesn't return what you expect. Paolo > + regs->offset, xen_pt_emu_reg_grps[i].grp_type, > + i, ARRAY_SIZE(xen_pt_emu_reg_grps)); > + error_propagate(errp, err);