Re: [Qemu-devel] [PULL 12/17] qcow2: Implement .bdrv_inactivate

[Paolo Bonzini <pbonzini@redhat.com>]

On 20/01/2016 17:25, Kevin Wolf wrote:
> +    ret = qcow2_cache_flush(bs, s->refcount_block_cache);
> +    if (ret) {
> +        result = ret;
> +        error_report("Failed to flush the refcount block cache: %s",
> +                     strerror(-ret));
> +    }
> +
> +    if (result == 0) {
> +        qcow2_mark_clean(bs);

Should you return an error if qcow2_mark_clean does?  (Coverity noticed
that its return value is usually checked).

Paolo

> +    }
> +
> +    return result;