From mboxrd@z Thu Jan 1 00:00:00 1970 From: Grygorii Strashko Subject: Re: [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port Date: Fri, 22 Jan 2016 13:58:38 +0200 Message-ID: <56A2196E.1020101@ti.com> References: <1453108103.4123.4.camel@gmail.com> <20160118201828.GE12309@linutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Thomas Gleixner , LKML , linux-rt-users To: Sebastian Andrzej Siewior , Mike Galbraith Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:36299 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbcAVL6s (ORCPT ); Fri, 22 Jan 2016 06:58:48 -0500 In-Reply-To: <20160118201828.GE12309@linutronix.de> Sender: linux-rt-users-owner@vger.kernel.org List-ID: On 01/18/2016 10:18 PM, Sebastian Andrzej Siewior wrote: > * Mike Galbraith | 2016-01-18 10:08:23 [+0100]: > >> --- a/arch/x86/entry/common.c >> +++ b/arch/x86/entry/common.c >> @@ -220,14 +220,14 @@ long syscall_trace_enter(struct pt_regs >> >> #define EXIT_TO_USERMODE_LOOP_FLAGS \ >> (_TIF_SIGPENDING | _TIF_NOTIFY_RESUME | _TIF_UPROBE | \ >> - _TIF_NEED_RESCHED | _TIF_USER_RETURN_NOTIFY) >> + _TIF_NEED_RESCHED_MASK | _TIF_USER_RETURN_NOTIFY) > > If I read this right, the loop where this define is used > _TIF_ALLWORK_MASK in v4.1 of which _TIF_NEED_RESCHED_MASK was part of= =2E > Adding this will reassmeble the old behaviour. > =E2=80=A6 Just a question (sorry if dumb). ARM has _TIF_WORK_MASK defined: #define _TIF_WORK_MASK (_TIF_NEED_RESCHED | _TIF_SIGPENDING | \ _TIF_NOTIFY_RESUME | _TIF_UPROBE) which is used to calculate loop exit condition in do_work_pending() (arch/arm/kernel/signal.c). Should _TIF_WORK_MASK also contain _TIF_NEED_RESCHED_LAZY? --=20 regards, -grygorii -- To unsubscribe from this list: send the line "unsubscribe linux-rt-user= s" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753461AbcAVL6z (ORCPT ); Fri, 22 Jan 2016 06:58:55 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:36299 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753303AbcAVL6s (ORCPT ); Fri, 22 Jan 2016 06:58:48 -0500 From: Grygorii Strashko Subject: Re: [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port To: Sebastian Andrzej Siewior , Mike Galbraith References: <1453108103.4123.4.camel@gmail.com> <20160118201828.GE12309@linutronix.de> CC: Thomas Gleixner , LKML , linux-rt-users Message-ID: <56A2196E.1020101@ti.com> Date: Fri, 22 Jan 2016 13:58:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160118201828.GE12309@linutronix.de> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/18/2016 10:18 PM, Sebastian Andrzej Siewior wrote: > * Mike Galbraith | 2016-01-18 10:08:23 [+0100]: > >> --- a/arch/x86/entry/common.c >> +++ b/arch/x86/entry/common.c >> @@ -220,14 +220,14 @@ long syscall_trace_enter(struct pt_regs >> >> #define EXIT_TO_USERMODE_LOOP_FLAGS \ >> (_TIF_SIGPENDING | _TIF_NOTIFY_RESUME | _TIF_UPROBE | \ >> - _TIF_NEED_RESCHED | _TIF_USER_RETURN_NOTIFY) >> + _TIF_NEED_RESCHED_MASK | _TIF_USER_RETURN_NOTIFY) > > If I read this right, the loop where this define is used > _TIF_ALLWORK_MASK in v4.1 of which _TIF_NEED_RESCHED_MASK was part of. > Adding this will reassmeble the old behaviour. > … Just a question (sorry if dumb). ARM has _TIF_WORK_MASK defined: #define _TIF_WORK_MASK (_TIF_NEED_RESCHED | _TIF_SIGPENDING | \ _TIF_NOTIFY_RESUME | _TIF_UPROBE) which is used to calculate loop exit condition in do_work_pending() (arch/arm/kernel/signal.c). Should _TIF_WORK_MASK also contain _TIF_NEED_RESCHED_LAZY? -- regards, -grygorii