From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37239) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMbOg-0002EM-0p for qemu-devel@nongnu.org; Fri, 22 Jan 2016 08:05:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aMbOe-0005Ak-Ti for qemu-devel@nongnu.org; Fri, 22 Jan 2016 08:05:01 -0500 Received: from mail-pa0-x241.google.com ([2607:f8b0:400e:c03::241]:34391) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aMbOe-00059f-FT for qemu-devel@nongnu.org; Fri, 22 Jan 2016 08:05:00 -0500 Received: by mail-pa0-x241.google.com with SMTP id yy13so3182765pab.1 for ; Fri, 22 Jan 2016 05:05:00 -0800 (PST) References: <1453396734-9363-1-git-send-email-clg@fr.ibm.com> <1453396734-9363-9-git-send-email-clg@fr.ibm.com> From: Corey Minyard Message-ID: <56A228F9.1070708@gmail.com> Date: Fri, 22 Jan 2016 07:04:57 -0600 MIME-Version: 1.0 In-Reply-To: <1453396734-9363-9-git-send-email-clg@fr.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v2 8/9] ipmi: add ACPI power and GUID commands Reply-To: minyard@acm.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , Corey Minyard Cc: "Michael S. Tsirkin" , qemu-devel@nongnu.org, Marcel Apfelbaum , Greg Kurz On 01/21/2016 11:18 AM, Cédric Le Goater wrote: > Signed-off-by: Cédric Le Goater > --- > > Changes since v1: > - added ACPI to command names. Thanks. Acked-by: Corey Minyard > > hw/ipmi/ipmi_bmc_sim.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 49 insertions(+) > > diff --git a/hw/ipmi/ipmi_bmc_sim.c b/hw/ipmi/ipmi_bmc_sim.c > index e882af3f1b40..53c75cb21c1a 100644 > --- a/hw/ipmi/ipmi_bmc_sim.c > +++ b/hw/ipmi/ipmi_bmc_sim.c > @@ -25,6 +25,7 @@ > #include > #include > #include > +#include "sysemu/sysemu.h" > #include "qemu/timer.h" > #include "hw/ipmi/ipmi.h" > #include "qemu/error-report.h" > @@ -51,6 +52,9 @@ > #define IPMI_CMD_GET_DEVICE_ID 0x01 > #define IPMI_CMD_COLD_RESET 0x02 > #define IPMI_CMD_WARM_RESET 0x03 > +#define IPMI_CMD_SET_ACPI_POWER_STATE 0x06 > +#define IPMI_CMD_GET_ACPI_POWER_STATE 0x07 > +#define IPMI_CMD_GET_DEVICE_GUID 0x08 > #define IPMI_CMD_RESET_WATCHDOG_TIMER 0x22 > #define IPMI_CMD_SET_WATCHDOG_TIMER 0x24 > #define IPMI_CMD_GET_WATCHDOG_TIMER 0x25 > @@ -200,6 +204,9 @@ struct IPMIBmcSim { > > uint8_t restart_cause; > > + uint8_t acpi_power_state[2]; > + uint8_t uuid[16]; > + > IPMISel sel; > IPMISdr sdr; > IPMISensor sensors[MAX_SENSORS]; > @@ -828,6 +835,36 @@ static void warm_reset(IPMIBmcSim *ibs, > k->reset(s, false); > } > } > +static void set_acpi_power_state(IPMIBmcSim *ibs, > + uint8_t *cmd, unsigned int cmd_len, > + uint8_t *rsp, unsigned int *rsp_len, > + unsigned int max_rsp_len) > +{ > + IPMI_CHECK_CMD_LEN(4); > + ibs->acpi_power_state[0] = cmd[2]; > + ibs->acpi_power_state[1] = cmd[3]; > +} > + > +static void get_acpi_power_state(IPMIBmcSim *ibs, > + uint8_t *cmd, unsigned int cmd_len, > + uint8_t *rsp, unsigned int *rsp_len, > + unsigned int max_rsp_len) > +{ > + IPMI_ADD_RSP_DATA(ibs->acpi_power_state[0]); > + IPMI_ADD_RSP_DATA(ibs->acpi_power_state[1]); > +} > + > +static void get_device_guid(IPMIBmcSim *ibs, > + uint8_t *cmd, unsigned int cmd_len, > + uint8_t *rsp, unsigned int *rsp_len, > + unsigned int max_rsp_len) > +{ > + unsigned int i; > + > + for (i = 0; i < 16; i++) { > + IPMI_ADD_RSP_DATA(ibs->uuid[i]); > + } > +} > > static void set_bmc_global_enables(IPMIBmcSim *ibs, > uint8_t *cmd, unsigned int cmd_len, > @@ -1609,6 +1646,9 @@ static const IPMICmdHandler app_cmds[] = { > [IPMI_CMD_GET_DEVICE_ID] = get_device_id, > [IPMI_CMD_COLD_RESET] = cold_reset, > [IPMI_CMD_WARM_RESET] = warm_reset, > + [IPMI_CMD_SET_ACPI_POWER_STATE] = set_acpi_power_state, > + [IPMI_CMD_GET_ACPI_POWER_STATE] = get_acpi_power_state, > + [IPMI_CMD_GET_DEVICE_GUID] = get_device_guid, > [IPMI_CMD_SET_BMC_GLOBAL_ENABLES] = set_bmc_global_enables, > [IPMI_CMD_GET_BMC_GLOBAL_ENABLES] = get_bmc_global_enables, > [IPMI_CMD_CLR_MSG_FLAGS] = clr_msg_flags, > @@ -1734,6 +1774,15 @@ static void ipmi_sim_init(Object *obj) > i += len; > } > > + ibs->acpi_power_state[0] = 0; > + ibs->acpi_power_state[1] = 0; > + > + if (qemu_uuid_set) { > + memcpy(&ibs->uuid, qemu_uuid, 16); > + } else { > + memset(&ibs->uuid, 0, 16); > + } > + > ipmi_init_sensors_from_sdrs(ibs); > register_cmds(ibs); >