From: Guenter Roeck <linux@roeck-us.net>
To: "Måns Rullgård" <mans@mansr.com>
Cc: Mason <slash.tmp@free.fr>, Wim Van Sebroeck <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v2] watchdog: tango: rename ARCH_TANGOX to ARCH_TANGO
Date: Fri, 22 Jan 2016 06:16:52 -0800 [thread overview]
Message-ID: <56A239D4.5050708@roeck-us.net> (raw)
In-Reply-To: <yw1xoacdn9wh.fsf@unicorn.mansr.com>
On 01/22/2016 03:14 AM, Måns Rullgård wrote:
> Guenter Roeck <linux@roeck-us.net> writes:
>
>> On Thu, Jan 21, 2016 at 03:27:07PM +0100, Mason wrote:
>>> From: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>>>
>>> This change was requested by arm-soc maintainer Kevin Hilman
>>> because the X in TANGOX is a wildcard.
>>>
>> Not what I was looking for, but not worth arguing about it, so
>
> It would be better if the commit message simply mentioned the fact that
> the platform support uses ARCH_TANGO and this has to match. The details
> of why it got named that way are less important.
>
Agreed. That is why I had asked to move that information after the "---".
But as I said, this is not worth an endless argument.
Guenter
>>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>>
>> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>>
>>> ---
>>> drivers/watchdog/Kconfig | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/watchdog/Kconfig b/drivers/watchdog/Kconfig
>>> index 4f0e7be0da34..e723e0169f88 100644
>>> --- a/drivers/watchdog/Kconfig
>>> +++ b/drivers/watchdog/Kconfig
>>> @@ -145,7 +145,7 @@ config MENF21BMC_WATCHDOG
>>> config TANGOX_WATCHDOG
>>> tristate "Sigma Designs SMP86xx/SMP87xx watchdog"
>>> select WATCHDOG_CORE
>>> - depends on ARCH_TANGOX || COMPILE_TEST
>>> + depends on ARCH_TANGO || COMPILE_TEST
>>> help
>>> Support for the watchdog in Sigma Designs SMP86xx (tango3)
>>> and SMP87xx (tango4) family chips.
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
--
To unsubscribe from this list: send the line "unsubscribe linux-watchdog" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-01-22 14:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 14:27 [PATCH v2] watchdog: tango: rename ARCH_TANGOX to ARCH_TANGO Mason
2016-01-21 14:28 ` Måns Rullgård
2016-01-21 20:42 ` Guenter Roeck
2016-01-22 11:14 ` Måns Rullgård
2016-01-22 14:16 ` Guenter Roeck [this message]
2016-01-22 14:51 ` Mason
2016-01-22 15:41 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A239D4.5050708@roeck-us.net \
--to=linux@roeck-us.net \
--cc=linux-watchdog@vger.kernel.org \
--cc=mans@mansr.com \
--cc=slash.tmp@free.fr \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.