Re: [GIT PULL] NVMe changes for 4.5-rc1

[Jens Axboe <axboe@fb.com>]

On 01/22/2016 09:26 AM, Linus Torvalds wrote:
>
> On Jan 22, 2016 7:59 AM, "Jens Axboe" <axboe@fb.com
> <mailto:axboe@fb.com>> wrote:
>  >>
>  >>   - nvme_dev_remove() got renamed to nvme_remove_namespaces(), but also
>  >> lost the "dev" argument (it takes "struct nvme_ctrl *ctrl" now).
>  >
>  > &dev->ctrl
>
> That's not the problem - the code does that already.
>
> But we want the dev argument *back*, since the function now wants to do
> that nvme_io_incapable() check and then cancel the IO on it.
>
> And I didn't know if you guys would want to use container_of() or just
> change the calling convention back to using "dev", or perhaps just
> decide to do the IO cleanup in the caller instead. That last option
> seems the cleanest, since now nvme_dev_remove_namespaces() is just about
> the namespace, and maybe it would be better to re-introduce a whole new
> nvme_dev_remove() that does the old thing.

The latter is the cleanest approach, we'll get it fixed up.

> So I decided to not do anything at all, and just let you guys sorry it
> out instead.

Is that like a Canadian duel?

-- 
Jens Axboe