From: Peter Hurley <peter@hurleysoftware.com>
To: John Ogness <john.ogness@linutronix.de>,
gregkh@linuxfoundation.org, vinod.koul@intel.com
Cc: dan.j.williams@intel.com, bigeasy@linutronix.de,
tony@atomide.com, nsekhar@ti.com, peter.ujfalusi@ti.com,
dmaengine@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic transfers
Date: Fri, 22 Jan 2016 08:31:21 -0800 [thread overview]
Message-ID: <56A25959.4060802@hurleysoftware.com> (raw)
In-Reply-To: <87zivxq57d.fsf@linutronix.de>
Hi John,
On 01/22/2016 02:27 AM, John Ogness wrote:
> Note that an ugly device-tree lookup hack is implemented in order
> to detect if the sDMA engine is being used. This is necessary
> because the sDMA driver does not implement pause/resume correctly
> and therefore requires slightly different logic for the UART
> driver.
No, this is not acceptable.
Please work with Vinod to refine the dma_get_slave_caps() interface
so that dmaengine drivers that don't provide the _documented_ pause/resume
support can be identified generically.
Regards,
Peter Hurley
next prev parent reply other threads:[~2016-01-22 16:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 10:27 [PATCH 3/4] tty: serial: 8250: omap: convert to using cyclic transfers John Ogness
2016-01-22 10:27 ` John Ogness
2016-01-22 16:31 ` Peter Hurley [this message]
2016-01-23 20:14 ` Sebastian Andrzej Siewior
2016-01-23 21:24 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A25959.4060802@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=bigeasy@linutronix.de \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=tony@atomide.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.