Re: [Qemu-devel] [PATCH] qmp: add query-block-dirty-bitmap

["Denis V. Lunev" <den@virtuozzo.com>]

On 01/22/2016 08:28 PM, Vladimir Sementsov-Ogievskiy wrote:
> On 22.01.2016 20:22, Denis V. Lunev wrote:
>> On 01/22/2016 08:07 PM, Vladimir Sementsov-Ogievskiy wrote:
>>   { 'command': 'query-block', 'returns': ['BlockInfo'] }
>>   +##
>> +# @BlockDirtyRegion:
>> +#
>> +# Region in bytes.
>> +#
>> +# @start: first byte
>> +#
>> +# @count: number of bytes in the region
>> +#
>> +# Since: 2.3
>> +##
>> +{ 'struct': 'BlockDirtyRegion',
>> +  'data': { 'start': 'int', 'count': 'int' } }
>> +
>> +##
>> +# @BlockDirtyBitmapInfo
>> +#
>> +# @name: the name of the dirty bitmap
>> +#
>> +# @size: size of the dirty bitmap in sectors
>> +#
>> +# @granularity: granularity of the dirty bitmap in bytes
>> +#
>> +# @disabled: whether the dirty bitmap is disabled
>> +#
>> +# @dirty-count: number of dirty bytes according to the dirty bitmap
>> +#
>> +# @dirty-regions: dirty regions of the bitmap
>> +#
>> +# Since 2.3
>> +##
>> +{ 'struct': 'BlockDirtyBitmapInfo',
>> +  'data': { 'name': 'str',
>> +            'size': 'int',
>> +            'granularity': 'int',
>> +            'disabled': 'bool',
>> +            'dirty-count': 'int',
>> +            'dirty-regions': ['BlockDirtyRegion'] } }
>> +
>> +##
>> +# @query-block-dirty-bitmap
>> +#
>> +# Get a description for specified dirty bitmap including it's dirty 
>> regions.
>> +# This command is in general for testing purposes.
>> +#
>> +# Returns: @BlockDirtyBitmapInfo
>> +#
>> +# Since: 2.3
>> +##
>> +{ 'command': 'query-block-dirty-bitmap',
>> +  'data': 'BlockDirtyBitmap',
>> +  'returns': 'BlockDirtyBitmapInfo' }
>> 1) should we consider part-by-part retrieval? This could be useful 
>> for large discs.
>> 2) Change to since 2.6
>> 3) Do you think that content should be retrieved separately than data?
>
> 3 - what do you mean?
>

sorry, I mean bitmap description separately from bitmap bits aka data