From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Date: Fri, 22 Jan 2016 19:29:28 +0100 Message-ID: <56A27508.4050701@gmail.com> References: <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> <20160121075849.GH19130@phenom.ffwll.local> <56A0989E.30006@daenzer.net> <20160121100905.GL19130@phenom.ffwll.local> <56A19C98.8020208@daenzer.net> <20160122151835.GM23290@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6F7AB6ECAD for ; Fri, 22 Jan 2016 10:29:35 -0800 (PST) Received: by mail-wm0-f42.google.com with SMTP id r129so224104004wmr.0 for ; Fri, 22 Jan 2016 10:29:35 -0800 (PST) In-Reply-To: <20160122151835.GM23290@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , =?UTF-8?Q?Michel_D=c3=a4nzer?= Cc: Alex Deucher , dri-devel@lists.freedesktop.org, LKML , Vlastimil Babka , =?UTF-8?Q?Christian_K=c3=b6nig?= List-Id: dri-devel@lists.freedesktop.org CgpPbiAwMS8yMi8yMDE2IDA0OjE4IFBNLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gT24gRnJp LCBKYW4gMjIsIDIwMTYgYXQgMTI6MDY6MDBQTSArMDkwMCwgTWljaGVsIETDpG56ZXIgd3JvdGU6 Cj4+Cj4+IFsgVHJpbW1pbmcgS0RFIGZvbGtzIGZyb20gQ2MgXQo+Pgo+PiBPbiAyMS4wMS4yMDE2 IDE5OjA5LCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+Pj4gT24gVGh1LCBKYW4gMjEsIDIwMTYgYXQg MDU6MzY6NDZQTSArMDkwMCwgTWljaGVsIETDpG56ZXIgd3JvdGU6Cj4+Pj4gT24gMjEuMDEuMjAx NiAxNjo1OCwgRGFuaWVsIFZldHRlciB3cm90ZToKPj4+Pj4KPj4+Pj4gQ2FuIHlvdSBwbGVhc2Ug cG9pbnQgbWUgYXQgdGhlIHZibGFuayBvbi9vZmYganVtcCBidWcgcGxlYXNlPwo+Pj4+Cj4+Pj4g QUZBSVIgSSBvcmlnaW5hbGx5IHJlcG9ydGVkIGl0IGluIHJlc3BvbnNlIHRvCj4+Pj4gaHR0cDov L2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAxNS1BdWd1c3QvMDg3 ODQxLmh0bWwKPj4+PiAsIGJ1dCBJIGNhbid0IGZpbmQgdGhhdCBpbiB0aGUgYXJjaGl2ZXMsIHNv IG1heWJlIHRoYXQgd2FzIGp1c3Qgb24gSVJDLgo+Pj4+IFNlZQo+Pj4+IGh0dHA6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRldmVsLzIwMTYtSmFudWFyeS8wOTkxMjIuaHRt bAo+Pj4+IC4gQmFzaWNhbGx5LCBJIHJhbiBpbnRvIHRoZSBidWcgZml4ZWQgYnkgeW91ciBwYXRj aCBiZWNhdXNlIHRoZSBjb3VudGVyCj4+Pj4ganVtcGVkIGZvcndhcmQgb24gZXZlcnkgRFBNUyBv ZmYsIHNvIGl0IGhpdCB0aGUgMzItYml0IGJvdW5kYXJ5IGFmdGVyCj4+Pj4ganVzdCBhIGZldyBk YXlzLgo+Pj4KPj4+IE9rLCBzbyBqdXN0IHVuY292ZXJlZCB0aGUgb3ZlcmZsb3cgYnVnLgo+Pgo+ PiBOb3Qgc3VyZSB3aGF0IHlvdSBtZWFuIGJ5ICJqdXN0IiwgYnV0IHRvIGJlIGNsZWFyOiBUaGUg ZHJtX3ZibGFua19vbi9vZmYKPj4gY291bnRlciBqdW1waW5nIGJ1ZyAoc2ltaWxhciB0byB0aGUg YnVnIHRoaXMgdGhyZWFkIGlzIGFib3V0KSwgd2hpY2gKPj4gZXhwb3NlZCB0aGUgb3ZlcmZsb3cg YnVnLCBpcyBzdGlsbCBhbGl2ZSBhbmQga2lja2luZyBpbiA0LjUuIEl0IHNlZW1zCj4+IHRvIGhh cHBlbiB3aGVuIHR1cm5pbmcgb2ZmIHRoZSBDUlRDOgo+Pgo+PiBbZHJtOmRybV91cGRhdGVfdmJs YW5rX2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAwOiBjdXJyZW50PTIxODEw NDY5NCwgZGlmZj0wLCBodz05MTYgaHdfbGFzdD05MTYKPj4gW2RybTpyYWRlb25fZ2V0X3ZibGFu a19jb3VudGVyX2ttc10gY3J0YyAwOiBkaXN0IGZyb20gdmJsYW5rIHN0YXJ0IDMKPj4gW2RybTpk cm1fY2FsY192Ymx0aW1lc3RhbXBfZnJvbV9zY2Fub3V0cG9zXSBjcnRjIDAgOiB2IDB4NyBwKDIx OTksLTQ1KUAgNzMwNC4zMDczNTQgLT4gNzMwNC4zMDgwMDYgW2UgMCB1cywgMCByZXBdCj4+IFtk cm06cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIGNydGMgMDogZGlzdCBmcm9tIHZibGFu ayBzdGFydCAzCj4+IFtkcm06ZHJtX3VwZGF0ZV92YmxhbmtfY291bnRdIHVwZGF0aW5nIHZibGFu ayBjb3VudCBvbiBjcnRjIDA6IGN1cnJlbnQ9MjE4MTA0Njk0LCBkaWZmPTE2Nzc2MzAxLCBodz0x IGh3X2xhc3Q9OTE2Cj4KPiBOb3Qgc3VyZSB3aGF0IGJ1ZyB3ZSdyZSB0YWxraW5nIGFib3V0IGhl cmUsIGJ1dCBoZXJlIHRoZSBodyBjb3VudGVyCj4gY2xlYXJseSBqdW1wcyBiYWNrd2FyZHMuCj4K Pj4gW2RybTpyYWRlb25fZ2V0X3ZibGFua19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0 IDMKPj4gW2RybTpyYWRlb25fZ2V0X3ZibGFua19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBz dGF0IDMKPj4gW2RybTpkcm1fdXBkYXRlX3ZibGFua19jb3VudF0gdXBkYXRpbmcgdmJsYW5rIGNv dW50IG9uIGNydGMgMTogY3VycmVudD0wLCBkaWZmPTAsIGh3PTAgaHdfbGFzdD0wCj4+IFtkcm06 cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIFF1ZXJ5IGZhaWxlZCEgc3RhdCAzCj4+IFtk cm06cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIFF1ZXJ5IGZhaWxlZCEgc3RhdCAzCj4+ IFtkcm06ZHJtX3VwZGF0ZV92YmxhbmtfY291bnRdIHVwZGF0aW5nIHZibGFuayBjb3VudCBvbiBj cnRjIDI6IGN1cnJlbnQ9MCwgZGlmZj0wLCBodz0wIGh3X2xhc3Q9MAo+PiBbZHJtOnJhZGVvbl9n ZXRfdmJsYW5rX2NvdW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMwo+PiBbZHJtOnJhZGVv bl9nZXRfdmJsYW5rX2NvdW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMwo+PiBbZHJtOmRy bV91cGRhdGVfdmJsYW5rX2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAzOiBj dXJyZW50PTAsIGRpZmY9MCwgaHc9MCBod19sYXN0PTAKPj4gW2RybTpyYWRlb25fZ2V0X3ZibGFu a19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0IDEKPj4gW2RybTpkcm1fY2FsY192Ymx0 aW1lc3RhbXBfZnJvbV9zY2Fub3V0cG9zXSBjcnRjIDAgOiB2IDB4MSBwKDAsMClAIDczMDQuMzE3 MTQwIC0+IDczMDQuMzE3MTQwIFtlIDAgdXMsIDAgcmVwXQo+PiBbZHJtOnJhZGVvbl9nZXRfdmJs YW5rX2NvdW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMQo+PiBbZHJtOmRybV91cGRhdGVf dmJsYW5rX2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAwOiBjdXJyZW50PTIz NDg4MDk5NSwgZGlmZj0xNjc3NzIxNSwgaHc9MCBod19sYXN0PTEKPgo+IFNhbWUgaGVyZS4KPgo+ IFRoZXNlIHRoaW5ncyBqdXN0IGRvbid0IGhhcHBlbiBvbiBpOTE1IGJlY2F1c2UgZHJtX3ZibGFu a19vZmYoKSBhbmQKPiBkcm1fdmJsYW5rX29uKCkgYXJlIGFsd2F5cyBjYWxsZWQgYXJvdW5kIHRo ZSB0aW1lcyB3aGVuIHRoZSBodyBjb3VudGVyCj4gbWlnaHQgZ2V0IHJlc2V0LiBPciBhdCBsZWFz dCB0aGF0J3MgaG93IGl0IHNob3VsZCBiZS4KPgoKRndpdywgdGVzdGluZyB0aGUgSEQtNTc1NzAg c2luZ2xlIGRpc3BsYXkgd2l0aCBteSBwYXRjaCB0aGF0IHVzZXMgCmRybV92Ymxhbmtfb2ZmL29u KCkgaW4gdGhlIERQTVMgT0ZGL09OIHBhdGggb2YgcmFkZW9uLWttcyBkb2VzIHNob3cgCmhhcmR3 YXJlIGNvdW50ZXIgcmVzZXQgdG8gemVybyBhcyBleHBlY3RlZCwgYnV0IG5vIGp1bXBzIG9mIHNv ZnR3YXJlIAp2YmxhbmsgY291bnRlci4gU28gd2l0aCB0aGF0IHZibGFua19vZmYvb24gcGxhY2Vt ZW50IGl0IHNlZW1zIHRvIHdvcmsgCm5pY2VseSBoZXJlLgoKLW1hcmlvCgo+PiBkZXYtPm1heF92 YmxhbmtfY291bnQgPSAweGZmZmZmZmZmLCB3aGljaCBtYWtlcyB0aGUgd3JhcGFyb3VuZCBjb2Rl IGluCj4+IGRybV91cGRhdGVfdmJsYW5rX2NvdW50IGEgbm8tb3AuIE1heWJlIHlvdSBjYW4gcmVw cm9kdWNlIGl0IGlmIHlvdQo+PiBhcnRpZmljaWFsbHkgc2V0IGEgbG93ZXIgbWF4X3ZibGFua19j b3VudCBpbiB0aGUgZHJpdmVyLgo+Pgo+Pgo+PiAtLQo+PiBFYXJ0aGxpbmcgTWljaGVsIETDpG56 ZXIgICAgICAgICAgICAgICB8ICAgICAgICAgICAgICAgaHR0cDovL3d3dy5hbWQuY29tCj4+IExp YnJlIHNvZnR3YXJlIGVudGh1c2lhc3QgICAgICAgICAgICAgfCAgICAgICAgICAgICBNZXNhIGFu ZCBYIGRldmVsb3Blcgo+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754913AbcAVS3k (ORCPT ); Fri, 22 Jan 2016 13:29:40 -0500 Received: from mail-wm0-f45.google.com ([74.125.82.45]:33213 "EHLO mail-wm0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754643AbcAVS3f (ORCPT ); Fri, 22 Jan 2016 13:29:35 -0500 Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , =?UTF-8?Q?Michel_D=c3=a4nzer?= References: <569CC357.8030302@suse.cz> <569FEEDE.4060409@gmail.com> <56A053CE.7000500@daenzer.net> <56A06D2E.4000008@gmail.com> <56A07CF9.5060506@daenzer.net> <56A07D97.6030606@daenzer.net> <20160121075849.GH19130@phenom.ffwll.local> <56A0989E.30006@daenzer.net> <20160121100905.GL19130@phenom.ffwll.local> <56A19C98.8020208@daenzer.net> <20160122151835.GM23290@intel.com> Cc: Vlastimil Babka , LKML , dri-devel@lists.freedesktop.org, Alex Deucher , =?UTF-8?Q?Christian_K=c3=b6nig?= From: Mario Kleiner Message-ID: <56A27508.4050701@gmail.com> Date: Fri, 22 Jan 2016 19:29:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160122151835.GM23290@intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/22/2016 04:18 PM, Ville Syrjälä wrote: > On Fri, Jan 22, 2016 at 12:06:00PM +0900, Michel Dänzer wrote: >> >> [ Trimming KDE folks from Cc ] >> >> On 21.01.2016 19:09, Daniel Vetter wrote: >>> On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: >>>> On 21.01.2016 16:58, Daniel Vetter wrote: >>>>> >>>>> Can you please point me at the vblank on/off jump bug please? >>>> >>>> AFAIR I originally reported it in response to >>>> http://lists.freedesktop.org/archives/dri-devel/2015-August/087841.html >>>> , but I can't find that in the archives, so maybe that was just on IRC. >>>> See >>>> http://lists.freedesktop.org/archives/dri-devel/2016-January/099122.html >>>> . Basically, I ran into the bug fixed by your patch because the counter >>>> jumped forward on every DPMS off, so it hit the 32-bit boundary after >>>> just a few days. >>> >>> Ok, so just uncovered the overflow bug. >> >> Not sure what you mean by "just", but to be clear: The drm_vblank_on/off >> counter jumping bug (similar to the bug this thread is about), which >> exposed the overflow bug, is still alive and kicking in 4.5. It seems >> to happen when turning off the CRTC: >> >> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=218104694, diff=0, hw=916 hw_last=916 >> [drm:radeon_get_vblank_counter_kms] crtc 0: dist from vblank start 3 >> [drm:drm_calc_vbltimestamp_from_scanoutpos] crtc 0 : v 0x7 p(2199,-45)@ 7304.307354 -> 7304.308006 [e 0 us, 0 rep] >> [drm:radeon_get_vblank_counter_kms] crtc 0: dist from vblank start 3 >> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=218104694, diff=16776301, hw=1 hw_last=916 > > Not sure what bug we're talking about here, but here the hw counter > clearly jumps backwards. > >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:drm_update_vblank_count] updating vblank count on crtc 1: current=0, diff=0, hw=0 hw_last=0 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:drm_update_vblank_count] updating vblank count on crtc 2: current=0, diff=0, hw=0 hw_last=0 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >> [drm:drm_update_vblank_count] updating vblank count on crtc 3: current=0, diff=0, hw=0 hw_last=0 >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 1 >> [drm:drm_calc_vbltimestamp_from_scanoutpos] crtc 0 : v 0x1 p(0,0)@ 7304.317140 -> 7304.317140 [e 0 us, 0 rep] >> [drm:radeon_get_vblank_counter_kms] Query failed! stat 1 >> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=234880995, diff=16777215, hw=0 hw_last=1 > > Same here. > > These things just don't happen on i915 because drm_vblank_off() and > drm_vblank_on() are always called around the times when the hw counter > might get reset. Or at least that's how it should be. > Fwiw, testing the HD-57570 single display with my patch that uses drm_vblank_off/on() in the DPMS OFF/ON path of radeon-kms does show hardware counter reset to zero as expected, but no jumps of software vblank counter. So with that vblank_off/on placement it seems to work nicely here. -mario >> dev->max_vblank_count = 0xffffffff, which makes the wraparound code in >> drm_update_vblank_count a no-op. Maybe you can reproduce it if you >> artificially set a lower max_vblank_count in the driver. >> >> >> -- >> Earthling Michel Dänzer | http://www.amd.com >> Libre software enthusiast | Mesa and X developer >