From: Max Reitz <mreitz@redhat.com>
To: Fam Zheng <famz@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
pbonzini@redhat.com, Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v7 15/15] iotests: Add "qemu-img map" test for VMDK extents
Date: Sat, 23 Jan 2016 00:51:29 +0100 [thread overview]
Message-ID: <56A2C081.6000303@redhat.com> (raw)
In-Reply-To: <1453431996-27764-16-git-send-email-famz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 5011 bytes --]
On 22.01.2016 04:06, Fam Zheng wrote:
> Reviewed-by: Eric Blake <eblake@redhat.com>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> tests/qemu-iotests/059 | 10 ++++++++++
> tests/qemu-iotests/059.out | 38 ++++++++++++++++++++++++++++++++++++++
> 2 files changed, 48 insertions(+)
>
> diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059
> index 0ded0c3..261d8b0 100755
> --- a/tests/qemu-iotests/059
> +++ b/tests/qemu-iotests/059
> @@ -133,6 +133,16 @@ $QEMU_IO -c "write -P 0xa 900G 512" "$TEST_IMG" | _filter_qemu_io
> $QEMU_IO -c "read -v 900G 1024" "$TEST_IMG" | _filter_qemu_io
>
> echo
> +echo "=== Testing qemu-img map on extents ==="
> +for fmt in twoGbMaxExtentSparse twoGbMaxExtentFlat; do
> + IMGOPTS="subformat=$fmt" _make_test_img 31G
> + $QEMU_IO -c "write 65024 1k" "$TEST_IMG" | _filter_qemu_io
> + $QEMU_IO -c "write 2147483136 1k" "$TEST_IMG" | _filter_qemu_io
> + $QEMU_IO -c "write 5G 1k" "$TEST_IMG" | _filter_qemu_io
> + $QEMU_IMG map "$TEST_IMG" | _filter_testdir
> +done
> +
> +echo
> echo "=== Testing afl image with a very large capacity ==="
> _use_sample_img afl9.vmdk.bz2
> _img_info
> diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out
> index 9d506cb..9f5e5cc 100644
> --- a/tests/qemu-iotests/059.out
> +++ b/tests/qemu-iotests/059.out
> @@ -2335,6 +2335,44 @@ e1000003f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> read 1024/1024 bytes at offset 966367641600
> 1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
>
> +=== Testing qemu-img map on extents ===
> +Formatting 'TEST_DIR/iotest-version3.IMGFMT', fmt=IMGFMT size=33285996544 subformat=twoGbMaxExtentSparse
> +wrote 1024/1024 bytes at offset 65024
> +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +wrote 1024/1024 bytes at offset 2147483136
> +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +wrote 1024/1024 bytes at offset 5368709120
> +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +Offset Length Mapped to File
> +0 0x20000 0x50000 TEST_DIR/iotest-version3-s001.vmdk
> +0x7fff0000 0x10000 0x70000 TEST_DIR/iotest-version3-s001.vmdk
> +0x80000000 0x10000 0x50000 TEST_DIR/iotest-version3-s002.vmdk
> +0x140000000 0x10000 0x50000 TEST_DIR/iotest-version3-s003.vmdk
> +Formatting 'TEST_DIR/iotest-version3.IMGFMT', fmt=IMGFMT size=33285996544 subformat=twoGbMaxExtentFlat
> +wrote 1024/1024 bytes at offset 65024
> +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +wrote 1024/1024 bytes at offset 2147483136
> +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +wrote 1024/1024 bytes at offset 5368709120
> +1 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
> +Offset Length Mapped to File
> +0 0x80000000 0 TEST_DIR/iotest-version3-f001.vmdk
> +0x80000000 0x80000000 0 TEST_DIR/iotest-version3-f002.vmdk
> +0x100000000 0x80000000 0 TEST_DIR/iotest-version3-f003.vmdk
> +0x180000000 0x80000000 0 TEST_DIR/iotest-version3-f004.vmdk
> +0x200000000 0x80000000 0 TEST_DIR/iotest-version3-f005.vmdk
> +0x280000000 0x80000000 0 TEST_DIR/iotest-version3-f006.vmdk
> +0x300000000 0x80000000 0 TEST_DIR/iotest-version3-f007.vmdk
> +0x380000000 0x80000000 0 TEST_DIR/iotest-version3-f008.vmdk
> +0x400000000 0x80000000 0 TEST_DIR/iotest-version3-f009.vmdk
> +0x480000000 0x80000000 0 TEST_DIR/iotest-version3-f010.vmdk
> +0x500000000 0x80000000 0 TEST_DIR/iotest-version3-f011.vmdk
> +0x580000000 0x80000000 0 TEST_DIR/iotest-version3-f012.vmdk
> +0x600000000 0x80000000 0 TEST_DIR/iotest-version3-f013.vmdk
> +0x680000000 0x80000000 0 TEST_DIR/iotest-version3-f014.vmdk
> +0x700000000 0x80000000 0 TEST_DIR/iotest-version3-f015.vmdk
> +0x780000000 0x40000000 0 TEST_DIR/iotest-version3-f016.vmdk
> +
I'm afraid I'm getting a different output here:
0xf000 0x2000 0xf000 ...-f001.vmdk
0x7ffff000 0x1000 0x7ffff000 ...-f001.vmdk
0x80000000 0x1000 0 ...-f002.vmdk
0x140000000 0x1000 0x40000000 ...-f003.vmdk
(and also, I'm getting an error "qemu-img: Could not open
'/tmp/test/t.vmdk': VMDK version 3 must be read only" in another place
in this test as of d62d9dc4b81, I presume)
Max
> === Testing afl image with a very large capacity ===
> qemu-img: Can't get size of device 'image': File too large
> *** done
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-01-22 23:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-22 3:06 [Qemu-devel] [PATCH v7 00/15] qemu-img map: Allow driver to return file of the allocated block Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 01/15] block: Add "file" output parameter to block status query functions Fam Zheng
2016-01-22 22:56 ` Max Reitz
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 02/15] qcow: Assign bs->file->bs to file in qcow_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 03/15] qcow2: Assign bs->file->bs to file in qcow2_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 04/15] raw: Assign bs to file in raw_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 05/15] iscsi: Assign bs to file in iscsi_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 06/15] parallels: Assign bs->file->bs to file in parallels_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 07/15] qed: Assign bs->file->bs to file in bdrv_qed_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 08/15] sheepdog: Assign bs to file in sd_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 09/15] vdi: Assign bs->file->bs to file in vdi_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 10/15] vpc: Assign bs->file->bs to file in vpc_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 11/15] vmdk: Return extent's file in bdrv_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 12/15] block: Use returned *file in bdrv_co_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 13/15] qemu-img: In "map", use the returned "file" from bdrv_get_block_status Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 14/15] qemu-img: Make MapEntry a QAPI struct Fam Zheng
2016-01-22 3:06 ` [Qemu-devel] [PATCH v7 15/15] iotests: Add "qemu-img map" test for VMDK extents Fam Zheng
2016-01-22 23:51 ` Max Reitz [this message]
2016-01-25 2:19 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A2C081.6000303@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.