From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbcAWMeP (ORCPT ); Sat, 23 Jan 2016 07:34:15 -0500 Received: from david.siemens.de ([192.35.17.14]:40567 "EHLO david.siemens.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751721AbcAWMeM (ORCPT ); Sat, 23 Jan 2016 07:34:12 -0500 Subject: Re: [PATCH 4/5] scripts/gdb: Add mount point list command To: Kieran Bingham References: <1453288550-4706-1-git-send-email-kieran.bingham@linaro.org> <1453288550-4706-5-git-send-email-kieran.bingham@linaro.org> Cc: linux-kernel@vger.kernel.org, maxime.coquelin@st.com, peter.griffin@linaro.org, lee.jones@linaro.org From: Jan Kiszka Message-ID: <56A3733C.7090303@siemens.com> Date: Sat, 23 Jan 2016 13:34:04 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: <1453288550-4706-5-git-send-email-kieran.bingham@linaro.org> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016-01-20 12:15, Kieran Bingham wrote: > lx-mounts will identify current mount points based on the 'init_task' > namespace by default, as we do not yet have a kernel thread list > implementation to select the current running thread. > > Optionally, a user can specify a PID to list from that process' > namespace > > This is somewhat limited vs the /proc/mounts file, as that calls into > vfs hooks through the s_op functions to obtain extra information. > > Signed-off-by: Kieran Bingham > --- > > > In this patch, I'm interested in your opinions on coding styles. > Would you prefer to see the function helpers, (dentry_name, info_opts) where > they are, or inside the command as class members? Or perhaps defined in utils? > > This also shows where I need to take constant information from the kernel. > In this case, they are simple numerical bitflags, and unlikely to change but > I didn't want to duplicate their values. > > > scripts/gdb/linux/constants.py.in | 21 ++++++++ > scripts/gdb/linux/proc.py | 110 ++++++++++++++++++++++++++++++++++++++ > 2 files changed, 131 insertions(+) > > diff --git a/scripts/gdb/linux/constants.py.in b/scripts/gdb/linux/constants.py.in > index d84084ac945b..739a15d2e984 100644 > --- a/scripts/gdb/linux/constants.py.in > +++ b/scripts/gdb/linux/constants.py.in > @@ -12,7 +12,11 @@ > * > */ > > +#include > +#include > + > /* We need to stringify expanded macros so that they can be parsed */ > #define STRING(x) #x > #define XSTRING(x) STRING(x) > This hunk is malformed, indicating that 4 lines are added while there are actually only 3 new ones. Could you check what went wrong? I'm applying it manually for now. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux