From: Jonathan Cameron <jic23@kernel.org>
To: Akinobu Mita <akinobu.mita@gmail.com>, linux-iio@vger.kernel.org
Cc: Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald <pmeerw@pmeerw.net>
Subject: Re: [PATCH v2 1/2] iio: pressure: mpl115: don't set unused i2c clientdata
Date: Sun, 24 Jan 2016 16:54:21 +0000 [thread overview]
Message-ID: <56A501BD.4050708@kernel.org> (raw)
In-Reply-To: <1452873603-17381-1-git-send-email-akinobu.mita@gmail.com>
On 15/01/16 16:00, Akinobu Mita wrote:
> mpl115 sets i2c clientdata, but it is not used anywhere. So remove it.
>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
> Cc: Jonathan Cameron <jic23@kernel.org>
> Cc: Hartmut Knaack <knaack.h@gmx.de>
> Cc: Lars-Peter Clausen <lars@metafoo.de>
> Cc: Peter Meerwald <pmeerw@pmeerw.net>
> Cc: linux-iio@vger.kernel.org
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.
Thanks,
Jonathan
> ---
> drivers/iio/pressure/mpl115.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/iio/pressure/mpl115.c b/drivers/iio/pressure/mpl115.c
> index f5ecd6e..3e1e3353 100644
> --- a/drivers/iio/pressure/mpl115.c
> +++ b/drivers/iio/pressure/mpl115.c
> @@ -163,7 +163,6 @@ static int mpl115_probe(struct i2c_client *client,
> data->client = client;
> mutex_init(&data->lock);
>
> - i2c_set_clientdata(client, indio_dev);
> indio_dev->info = &mpl115_info;
> indio_dev->name = id->name;
> indio_dev->dev.parent = &client->dev;
>
prev parent reply other threads:[~2016-01-24 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-15 16:00 [PATCH v2 1/2] iio: pressure: mpl115: don't set unused i2c clientdata Akinobu Mita
2016-01-15 16:00 ` [PATCH v2 2/2] iio: pressure: mpl115: support MPL115A1 Akinobu Mita
2016-01-16 11:19 ` Jonathan Cameron
2016-01-24 16:55 ` Jonathan Cameron
2016-01-24 16:54 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A501BD.4050708@kernel.org \
--to=jic23@kernel.org \
--cc=akinobu.mita@gmail.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.