Re: [PATCH 2/2] md-cluster: delete useless code

[Guoqing Jiang <gqjiang@suse.com>]

On 01/23/2016 08:45 AM, Shaohua Li wrote:
> page->index already considers node offset. The node_offset calculation
> in write_sb_page is useless and confusion.

Acked-by: Guoqing Jiang <gqjiang@suse.com>

Thanks,
Guoqing
> Cc: Goldwyn Rodrigues <rgoldwyn@suse.com>
> Cc: Guoqing Jiang <gqjiang@suse.com>
> Cc: NeilBrown <neilb@suse.com>
> Signed-off-by: Shaohua Li <shli@fb.com>
> ---
>   drivers/md/bitmap.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 4f22e91..d80cce4 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -210,10 +210,6 @@ static int write_sb_page(struct bitmap *bitmap, struct page *page, int wait)
>   	struct block_device *bdev;
>   	struct mddev *mddev = bitmap->mddev;
>   	struct bitmap_storage *store = &bitmap->storage;
> -	int node_offset = 0;
> -
> -	if (mddev_is_clustered(bitmap->mddev))
> -		node_offset = bitmap->cluster_slot * store->file_pages;
>   
>   	while ((rdev = next_active_rdev(rdev, mddev)) != NULL) {
>   		int size = PAGE_SIZE;