All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tsutomu Itoh <t-itoh@jp.fujitsu.com>
To: dsterba@suse.cz
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] Btrfs: fix error number in send.c
Date: Mon, 25 Jan 2016 11:23:51 +0900	[thread overview]
Message-ID: <56A58737.906@jp.fujitsu.com> (raw)
In-Reply-To: <20160122140043.GS4227@twin.jikos.cz>

Hi, David,

On 2016/01/22 23:00, David Sterba wrote:
> On Fri, Jan 22, 2016 at 09:13:25AM +0900, Tsutomu Itoh wrote:
>> ENOTSUPP should not be returned to the user program.
>>   (cf. include/linux/errno.h)
>> Therefore, EOPNOTSUPP is used instead of ENOTSUPP.
>
> I'm not sure that EOPNOTSUPP is the right error code here. I'd rather
> make it EINVAL, the bug we're talking about is a new type of inode
> outside of the S_IFMT bits. "not supported" would mean we don't support
> it but we could in theory.

Thanks for review.

In the meaning that btrfs-send is not supporting a new type of inode now,
EOPNOTSUPP is acceptable, I think.

Thanks,
Tsutomu


  reply	other threads:[~2016-01-25  2:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-22  0:13 [PATCH] Btrfs: fix error number in send.c Tsutomu Itoh
2016-01-22 14:00 ` David Sterba
2016-01-25  2:23   ` Tsutomu Itoh [this message]
2016-01-26 13:01     ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A58737.906@jp.fujitsu.com \
    --to=t-itoh@jp.fujitsu.com \
    --cc=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.