From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNZZG-0001Tc-NH for qemu-devel@nongnu.org; Mon, 25 Jan 2016 00:19:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNZZC-0002Vh-9Y for qemu-devel@nongnu.org; Mon, 25 Jan 2016 00:19:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50319) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNZZC-0002Vd-3j for qemu-devel@nongnu.org; Mon, 25 Jan 2016 00:19:54 -0500 References: <1453451811-11860-1-git-send-email-zhang.zhanghailiang@huawei.com> <1453451811-11860-6-git-send-email-zhang.zhanghailiang@huawei.com> From: Jason Wang Message-ID: <56A5B062.2040103@redhat.com> Date: Mon, 25 Jan 2016 13:19:30 +0800 MIME-Version: 1.0 In-Reply-To: <1453451811-11860-6-git-send-email-zhang.zhanghailiang@huawei.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 5/7] filter-buffer: Accept zero interval List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: zhanghailiang , qemu-devel@nongnu.org Cc: zhangchen.fnst@cn.fujitsu.com, hongyang.yang@easystack.cn On 01/22/2016 04:36 PM, zhanghailiang wrote: > We may want to accept zero interval when VM FT solutions like MC > or COLO use this filter to release packets on demand. > > Signed-off-by: zhanghailiang > Reviewed-by: Yang Hongyang > --- > net/filter-buffer.c | 10 ---------- > 1 file changed, 10 deletions(-) Looks a independent patch of this rfc series. > > diff --git a/net/filter-buffer.c b/net/filter-buffer.c > index 57be149..12e0c87 100644 > --- a/net/filter-buffer.c > +++ b/net/filter-buffer.c > @@ -103,16 +103,6 @@ static void filter_buffer_setup(NetFilterState *nf, Error **errp) > { > FilterBufferState *s = FILTER_BUFFER(nf); > > - /* > - * We may want to accept zero interval when VM FT solutions like MC > - * or COLO use this filter to release packets on demand. > - */ > - if (!s->interval) { > - error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "interval", > - "a non-zero interval"); > - return; > - } > - > s->incoming_queue = qemu_new_net_queue(qemu_netfilter_pass_to_next, nf); > if (s->interval) { > timer_init_us(&s->release_timer, QEMU_CLOCK_VIRTUAL,