From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51494)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1aNfJL-0005Hi-Oy
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 06:27:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1aNfJH-0006uS-3t
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 06:27:55 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42877)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1aNfJG-0006uH-UT
	for qemu-devel@nongnu.org; Mon, 25 Jan 2016 06:27:51 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (Postfix) with ESMTPS id 96A0D8EA3B
	for <qemu-devel@nongnu.org>; Mon, 25 Jan 2016 11:27:50 +0000 (UTC)
References: <1453564933-29638-1-git-send-email-ehabkost@redhat.com>
From: Laszlo Ersek <lersek@redhat.com>
Message-ID: <56A606B3.7050400@redhat.com>
Date: Mon, 25 Jan 2016 12:27:47 +0100
MIME-Version: 1.0
In-Reply-To: <1453564933-29638-1-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 0/5] q35: Remove old machines and unused
	compat code
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Marcel Apfelbaum <marcel.a@redhat.com>, "Michael S. Tsirkin" <mst@redhat.com>, Markus Armbruster <armbru@redhat.com>, Igor Mammedov <imammedo@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, John Snow <jsnow@redhat.com>

On 01/23/16 17:02, Eduardo Habkost wrote:
> This is another attempt to remove old q35 machine code. Now I am
> also removing unused compat code to demonstrate the benefit of
> throwing away the old code that nobody uses.
> 
> Eduardo Habkost (5):
>   q35: Remove old machine versions
>   machine: Remove no_tco field
>   ich9: Remove enable_tco arguments from init functions
>   q35: Remove unused q35-acpi-dsdt.aml file
>   q35: No need to check gigabyte_align
> 
>  Makefile                  |   2 +-
>  hw/acpi/ich9.c            |   8 +--
>  hw/i386/pc_q35.c          | 176 +---------------------------------------------
>  hw/isa/lpc_ich9.c         |   4 +-
>  include/hw/acpi/ich9.h    |   1 -
>  include/hw/boards.h       |   1 -
>  include/hw/i386/ich9.h    |   2 +-
>  pc-bios/q35-acpi-dsdt.aml | Bin 7344 -> 0 bytes
>  8 files changed, 9 insertions(+), 185 deletions(-)
>  delete mode 100644 pc-bios/q35-acpi-dsdt.aml
> 

I read / skimmed the earlier discussion:

http://thread.gmane.org/gmane.comp.emulators.qemu/356340
http://thread.gmane.org/gmane.comp.emulators.qemu/382574

For patches 1, 2, 3, 5:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

For patch 4:

How about removing the following two files in addition:
- hw/i386/q35-acpi-dsdt.dsl
- hw/i386/q35-acpi-dsdt.hex.generated

and updating the references in "hw/i386/Makefile.objs"?

Thanks
Laszlo