From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Crispin Subject: Re: [PATCH V2 1/2] dt-bindings: regulator: Add document for MT6323 regulator Date: Mon, 25 Jan 2016 13:05:52 +0100 Message-ID: <56A60FA0.3060503@openwrt.org> References: <1453718405-40815-1-git-send-email-blogic@openwrt.org> <20160125113710.GJ6588@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160125113710.GJ6588-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Steven Liu , Liam Girdwood , Henry Chen , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Matthias Brugger , Chen Zhong , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: linux-mediatek@lists.infradead.org On 25/01/2016 12:37, Mark Brown wrote: > On Mon, Jan 25, 2016 at 11:40:04AM +0100, John Crispin wrote: >> Based on the MT6397 binding documentation. >> >> Signed-off-by: John Crispin >> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > In reply to your previous submission I said: > > | important. Please also use subject lines matching the style for the > | subsystem (for patch 1). > > Please don't ignore review comments, people are generally making them > for a reason and are likely to have the same concerns if issues remain > unaddressed. Having to repeat the same comments can get repetitive and > make people question the value of time spent reviewing. If you disagree > with the review comments that's fine but you need to reply and discuss > your concerns so that the reviewer can understand your decisions. > Hi, sorry about that. I've been juggling with a pile of patches the last couple of weeks and missed folding the fixup into the patch before sending it. I've just sent you a V3. John -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: blogic@openwrt.org (John Crispin) Date: Mon, 25 Jan 2016 13:05:52 +0100 Subject: [PATCH V2 1/2] dt-bindings: regulator: Add document for MT6323 regulator In-Reply-To: <20160125113710.GJ6588@sirena.org.uk> References: <1453718405-40815-1-git-send-email-blogic@openwrt.org> <20160125113710.GJ6588@sirena.org.uk> Message-ID: <56A60FA0.3060503@openwrt.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 25/01/2016 12:37, Mark Brown wrote: > On Mon, Jan 25, 2016 at 11:40:04AM +0100, John Crispin wrote: >> Based on the MT6397 binding documentation. >> >> Signed-off-by: John Crispin >> Cc: devicetree at vger.kernel.org > > In reply to your previous submission I said: > > | important. Please also use subject lines matching the style for the > | subsystem (for patch 1). > > Please don't ignore review comments, people are generally making them > for a reason and are likely to have the same concerns if issues remain > unaddressed. Having to repeat the same comments can get repetitive and > make people question the value of time spent reviewing. If you disagree > with the review comments that's fine but you need to reply and discuss > your concerns so that the reviewer can understand your decisions. > Hi, sorry about that. I've been juggling with a pile of patches the last couple of weeks and missed folding the fixup into the patch before sending it. I've just sent you a V3. John From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756923AbcAYMGB (ORCPT ); Mon, 25 Jan 2016 07:06:01 -0500 Received: from arrakis.dune.hu ([78.24.191.176]:57445 "EHLO arrakis.dune.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756021AbcAYMF6 (ORCPT ); Mon, 25 Jan 2016 07:05:58 -0500 Subject: Re: [PATCH V2 1/2] dt-bindings: regulator: Add document for MT6323 regulator To: Mark Brown References: <1453718405-40815-1-git-send-email-blogic@openwrt.org> <20160125113710.GJ6588@sirena.org.uk> Cc: devicetree@vger.kernel.org, Steven Liu , Liam Girdwood , Henry Chen , linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, Matthias Brugger , Chen Zhong , linux-arm-kernel@lists.infradead.org From: John Crispin Message-ID: <56A60FA0.3060503@openwrt.org> Date: Mon, 25 Jan 2016 13:05:52 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160125113710.GJ6588@sirena.org.uk> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/01/2016 12:37, Mark Brown wrote: > On Mon, Jan 25, 2016 at 11:40:04AM +0100, John Crispin wrote: >> Based on the MT6397 binding documentation. >> >> Signed-off-by: John Crispin >> Cc: devicetree@vger.kernel.org > > In reply to your previous submission I said: > > | important. Please also use subject lines matching the style for the > | subsystem (for patch 1). > > Please don't ignore review comments, people are generally making them > for a reason and are likely to have the same concerns if issues remain > unaddressed. Having to repeat the same comments can get repetitive and > make people question the value of time spent reviewing. If you disagree > with the review comments that's fine but you need to reply and discuss > your concerns so that the reviewer can understand your decisions. > Hi, sorry about that. I've been juggling with a pile of patches the last couple of weeks and missed folding the fixup into the patch before sending it. I've just sent you a V3. John