From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756329AbcAYOOK (ORCPT ); Mon, 25 Jan 2016 09:14:10 -0500 Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:42127 "EHLO e06smtp07.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755501AbcAYOOH (ORCPT ); Mon, 25 Jan 2016 09:14:07 -0500 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: sth@linux.vnet.ibm.com X-IBM-RcptTo: linux-block@vger.kernel.org;linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] block: fix bio splitting on max sectors To: Jens Axboe , Ming Lei , linux-kernel@vger.kernel.org References: <1453507533-25593-1-git-send-email-tom.leiming@gmail.com> <56A2F70E.2070802@kernel.dk> Cc: linux-block@vger.kernel.org, Linus Torvalds , Keith Busch From: Stefan Haberland Message-ID: <56A62DA7.8050506@linux.vnet.ibm.com> Date: Mon, 25 Jan 2016 15:13:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <56A2F70E.2070802@kernel.dk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16012514-0029-0000-0000-000005944986 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 23.01.2016 um 04:44 schrieb Jens Axboe: > On 01/22/2016 05:05 PM, Ming Lei wrote: >> After commit e36f62042880(block: split bios to maxpossible length), >> bio can be splitted in the middle of a vector entry, then it >> is easy to split out one bio which size isn't aligned with block >> size, especially when the block size is bigger than 512. >> >> This patch fixes the issue by making the max io size aligned >> to logical block size. >> >> Fixes: e36f62042880(block: split bios to maxpossible length) >> Reported-by: Stefan Haberland >> Cc: Keith Busch >> Suggested-by: Linus Torvalds >> Signed-off-by: Ming Lei >> --- >> V1: >> - avoid double shift as suggested by Linus >> - compute 'max_sectors' once as suggested by Keith > > This looks good to me, I'll apply and run a bit of local testing. > I applied the patch and it seems to work for DASD devices. I will do some more testing but for me it looks OK. Thanks! Regards, Stefan