From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39643) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNhxr-0002lV-G8 for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:17:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNhxm-0000er-Gi for qemu-devel@nongnu.org; Mon, 25 Jan 2016 09:17:55 -0500 References: <1453689887-2567-1-git-send-email-famz@redhat.com> <1453689887-2567-16-git-send-email-famz@redhat.com> <56A62D0A.7020704@redhat.com> From: Max Reitz Message-ID: <56A62E7F.1000208@redhat.com> Date: Mon, 25 Jan 2016 15:17:35 +0100 MIME-Version: 1.0 In-Reply-To: <56A62D0A.7020704@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="D5nvAX3JS4WfBa4R9qvLiP7EPUknK6A3N" Subject: Re: [Qemu-devel] [PATCH v8 15/15] iotests: Add "qemu-img map" test for VMDK extents List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , pbonzini@redhat.com, Stefan Hajnoczi , qemu-block@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --D5nvAX3JS4WfBa4R9qvLiP7EPUknK6A3N Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: quoted-printable On 25.01.2016 15:11, Max Reitz wrote: > On 25.01.2016 03:44, Fam Zheng wrote: >> Signed-off-by: Fam Zheng >> --- >> tests/qemu-iotests/059 | 10 ++++++++++ >> tests/qemu-iotests/059.out | 26 ++++++++++++++++++++++++++ >> 2 files changed, 36 insertions(+) >> >> diff --git a/tests/qemu-iotests/059 b/tests/qemu-iotests/059 >> index 0ded0c3..0332bbb 100755 >> --- a/tests/qemu-iotests/059 >> +++ b/tests/qemu-iotests/059 >> @@ -133,6 +133,16 @@ $QEMU_IO -c "write -P 0xa 900G 512" "$TEST_IMG" |= _filter_qemu_io >> $QEMU_IO -c "read -v 900G 1024" "$TEST_IMG" | _filter_qemu_io >> =20 >> echo >> +echo "=3D=3D=3D Testing qemu-img map on extents =3D=3D=3D" >> +for fmt in monolithicSparse twoGbMaxExtentSparse; do >> + IMGOPTS=3D"subformat=3D$fmt" _make_test_img 31G >> + $QEMU_IO -c "write 65024 1k" "$TEST_IMG" | _filter_qemu_io >> + $QEMU_IO -c "write 2147483136 1k" "$TEST_IMG" | _filter_qemu_io >> + $QEMU_IO -c "write 5G 1k" "$TEST_IMG" | _filter_qemu_io >> + $QEMU_IMG map "$TEST_IMG" | _filter_testdir >> +done >> + >> +echo >> echo "=3D=3D=3D Testing afl image with a very large capacity =3D=3D=3D= " >> _use_sample_img afl9.vmdk.bz2 >> _img_info >> diff --git a/tests/qemu-iotests/059.out b/tests/qemu-iotests/059.out >> index 9d506cb..5e041d7 100644 >> --- a/tests/qemu-iotests/059.out >> +++ b/tests/qemu-iotests/059.out >> @@ -2050,6 +2050,7 @@ wrote 512/512 bytes at offset 0 >> 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >> wrote 512/512 bytes at offset 10240 >> 512 bytes, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) >> +qemu-img: Could not open '/home/fam/build/last/tests/qemu-iotests/scr= atch/t.vmdk': VMDK version 3 must be read only =2E..and I just noticed that my home directory is called /home/maxx and not /home/fam. :-) > I'd rather have the test fail than include this apparently wrong line > (according to > http://lists.nongnu.org/archive/html/qemu-block/2016-01/msg00710.html) > here, but I'll leave that up to you. >=20 > Reviewed-by: Max Reitz So I'll have to revoke this R-b. Max --D5nvAX3JS4WfBa4R9qvLiP7EPUknK6A3N Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJWpi5/AAoJEDuxQgLoOKytlmMH/0QI4FxJAo2vNEGDOWvtSeqc 1mMJPS2RCpXU/8MzcDgI/ud0n8Kef4jS2EPQnree0dqKlL+CnpTKQ0qvl2eV7YsH 8FqMc9SuvN8oe1G2YY1Xz594aevLJ5jhif1qemmOsGlXCRmdqwVshU+ZUNwyKAMO c1fHKD1UzBCDyMU3xvNK1BUEkdSOaIl6ddzTKXrH2Pidjs6kGeYxgkegWUjWLe31 xizO4lNsfs0d3FMvl9SAFRw7a6CSAvcgUTgEtlg+Eb0cjiLxnIHLpxoJkNshZJWx LxzzojbjgSFJSDt0PgBOte7hwKJfxh7fAnH6GVDZaMxdFSHdhx3zl3AFT+yKlBc= =jAiI -----END PGP SIGNATURE----- --D5nvAX3JS4WfBa4R9qvLiP7EPUknK6A3N--