diff for duplicates of <56A63A85.6060609@nvidia.com> diff --git a/a/1.txt b/N1/1.txt index ff345c4..1dae17c 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,15 @@ -Thanks Lee for your review. I will take care of most of comment on my +Thanks Lee for your review. I will take care of most of comment on my=20 next patch. -I have reply on some comment and seeking more details for few comments +I have reply on some comment and seeking more details for few comments=20 as follows. On Monday 25 January 2016 05:26 PM, Lee Jones wrote: > On Tue, 19 Jan 2016, Laxman Dewangan wrote: > ->> +- interrupt-controller: MAX77620 has internal interrupt controller which +>> +- interrupt-controller: MAX77620 has internal interrupt controller whic= +h >> + takes the interrupt request from internal sub-blocks like RTC, >> + regulators, GPIOs as well as external input. > This is how interrupt-controllers usually work. I don't think there @@ -16,19 +17,20 @@ On Monday 25 January 2016 05:26 PM, Lee Jones wrote: > ../interrupt-controller/interrupts.txt instead. Something similar to (just to confirm) -- interrupt-controller: describes the 88pm860x as an interrupt +- interrupt-controller: describes the 88pm860x as an interrupt=20 controller (has its own domain) > >> +- #interrupt-cells: Should be set to 2 for IRQ number and flags. >> + The first cell is the IRQ number. IRQ numbers for different interrupt >> + source of MAX77620 are defined at dt-bindings/mfd/max77620.h ->> + The second cell is the flags, encoded as the trigger masks from binding +>> + The second cell is the flags, encoded as the trigger masks from bindi= +ng >> + document interrupts.txt, using dt-bindings/irq. > This is a very lengthy read for such little information. Please make > it more succinct. Take a look at other files for examples. -I started with as3722.txt and it seems I am carrying forward the -complexity here. Originally, as3722 is posted by me only. Any good file +I started with as3722.txt and it seems I am carrying forward the=20 +complexity here. Originally, as3722 is posted by me only. Any good file=20 example which I can refer? @@ -54,7 +56,7 @@ example which I can refer? > > ... don't you think? -Agree, I can make indenting. And will do whatever places it needs in +Agree, I can make indenting. And will do whatever places it needs in=20 this document. > @@ -63,8 +65,8 @@ this document. >> +This device also supports the power OFF of system. > What is the "power OFF of system"? -PMIC supplies the power. So once PMIC is in OFF state, it turns off all -its rail and hence no SW execution on system. Still external supply will +PMIC supplies the power. So once PMIC is in OFF state, it turns off all=20 +its rail and hence no SW execution on system. Still external supply will=20 keep supply to PMIC. @@ -73,19 +75,21 @@ keep supply to PMIC. >> +- system-power-controller: Boolean, This device will be use as > You don't describe the type of each property, so why is this one > special? -Hmm. I describe the boolean and tristate only. Do I need to define type +Hmm. I describe the boolean and tristate only. Do I need to define type=20 for integer,string also? >> +power OFF slot and slot period of the device. Device has 3 FPS as FPS0, >> +FPS1 and FPS2. The details of FPS configuration is provided through >> +subnode "fps". The details of FPS0, FPS1, FPS2 are provided through the ->> +child node under this subnodes. The FPS number is provided via reg property. +>> +child node under this subnodes. The FPS number is provided via reg prop= +erty. >> + >> +The property for fps child nodes as: >> +Required properties: >> + -reg: FPS number like 0, 1, 2 for FPS0, FPS1 and FPS2 respectively. > I'm surprised Rob Acked this. We don't usually do device numbers in DT. -What is best way to make the child node for FPS and differentiate FPS0,1, 2? +What is best way to make the child node for FPS and differentiate FPS0,1, 2= +? What is your suggestion here? @@ -109,24 +113,24 @@ What is your suggestion here? > property not present? If not, can't you just remove the entire node? > Or am I missing something? -Here, my need is to connect different FPS source inputs EN0, EN1 or SW. -They can connected to any inputs. That's why fps-enable-input select the +Here, my need is to connect different FPS source inputs EN0, EN1 or SW.=20 +They can connected to any inputs. That's why fps-enable-input select the=20 related digital input for given FPS. -However, I can reduce the need of "fps-sw-enable" and make this always -enable if fps-enable-input= <SW>. +However, I can reduce the need of "fps-sw-enable" and make this always=20 +enable if fps-enable-input=3D <SW>. Here is excerpt from datasheet: B3:B1: SRCFPSx[1:0] Enable Source. Specifies the enable source for the sequencer. - 0b00=EN0 hardware input - 0b01=EN1 hardware input - 0b10=ENFPSx software bit - 0b11=reserved + 0b00=3DEN0 hardware input + 0b01=3DEN1 hardware input + 0b10=3DENFPSx software bit + 0b11=3Dreserved B0 ENFPSx Software Enable - 0=Disable FPSx - 1=Enable FPSx - X=ENFPSx is a don’t care if SRCFPSx[1:0] != 0b10 + 0=3DDisable FPSx + 1=3DEnable FPSx + X=3DENFPSx is a don=E2=80=99t care if SRCFPSx[1:0] !=3D 0b10 > @@ -135,16 +139,24 @@ B0 ENFPSx Low Power Mode (LPM). I will add details. > +Pinmux and GPIO: -> +=============== +> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > I think this whole section needs moving to ../pinctrl and needs to be > reviewed by Linus W. -Is this mean I need to create DT binding doc for the each subsystem +Is this mean I need to create DT binding doc for the each subsystem=20 differently? Actually during AS3722, I had different understanding to have single file. --- -To unsubscribe from this list: send the line "unsubscribe linux-gpio" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html +--=20 +--=20 +You received this message because you are subscribed to "rtc-linux". +Membership options at http://groups.google.com/group/rtc-linux . +Please read http://groups.google.com/group/rtc-linux/web/checklist +before submitting a driver. +---=20 +You received this message because you are subscribed to the Google Groups "= +rtc-linux" group. +To unsubscribe from this group and stop receiving emails from it, send an e= +mail to rtc-linux+unsubscribe@googlegroups.com. +For more options, visit https://groups.google.com/d/optout. diff --git a/a/content_digest b/N1/content_digest index 728e8cc..bea766c 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -2,41 +2,42 @@ "ref\01453198783-28383-2-git-send-email-ldewangan@nvidia.com\0" "ref\020160125115610.GC3368@x1\0" "From\0Laxman Dewangan <ldewangan@nvidia.com>\0" - "Subject\0Re: [PATCH V4 1/5] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024\0" + "Subject\0[rtc-linux] Re: [PATCH V4 1/5] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024\0" "Date\0Mon, 25 Jan 2016 20:38:53 +0530\0" "To\0Lee Jones <lee.jones@linaro.org>\0" - "Cc\0robh+dt@kernel.org" - pawel.moll@arm.com - mark.rutland@arm.com - ijc+devicetree@hellion.org.uk - galak@codeaurora.org - linus.walleij@linaro.org - gnurou@gmail.com - broonie@kernel.org - a.zummo@towertech.it - alexandre.belloni@free-electrons.com - lgirdwood@gmail.com - devicetree@vger.kernel.org - linux-kernel@vger.kernel.org - linux-gpio@vger.kernel.org - rtc-linux@googlegroups.com - swarren@nvidia.com - treding@nvidia.com - k.kozlowski@samsung.com - " vreddytalla@nvidia.com\0" + "Cc\0<robh+dt@kernel.org>" + <pawel.moll@arm.com> + <mark.rutland@arm.com> + <ijc+devicetree@hellion.org.uk> + <galak@codeaurora.org> + <linus.walleij@linaro.org> + <gnurou@gmail.com> + <broonie@kernel.org> + <a.zummo@towertech.it> + <alexandre.belloni@free-electrons.com> + <lgirdwood@gmail.com> + <devicetree@vger.kernel.org> + <linux-kernel@vger.kernel.org> + <linux-gpio@vger.kernel.org> + <rtc-linux@googlegroups.com> + <swarren@nvidia.com> + <treding@nvidia.com> + <k.kozlowski@samsung.com> + " <vreddytalla@nvidia.com>\0" "\00:1\0" "b\0" "\n" - "Thanks Lee for your review. I will take care of most of comment on my \n" + "Thanks Lee for your review. I will take care of most of comment on my=20\n" "next patch.\n" "\n" - "I have reply on some comment and seeking more details for few comments \n" + "I have reply on some comment and seeking more details for few comments=20\n" "as follows.\n" "\n" "On Monday 25 January 2016 05:26 PM, Lee Jones wrote:\n" "> On Tue, 19 Jan 2016, Laxman Dewangan wrote:\n" ">\n" - ">> +- interrupt-controller: MAX77620 has internal interrupt controller which\n" + ">> +- interrupt-controller: MAX77620 has internal interrupt controller whic=\n" + "h\n" ">> + takes the interrupt request from internal sub-blocks like RTC,\n" ">> + regulators, GPIOs as well as external input.\n" "> This is how interrupt-controllers usually work. I don't think there\n" @@ -44,19 +45,20 @@ "> ../interrupt-controller/interrupts.txt instead.\n" "\n" "Something similar to (just to confirm)\n" - "- interrupt-controller: describes the 88pm860x as an interrupt \n" + "- interrupt-controller: describes the 88pm860x as an interrupt=20\n" "controller (has its own domain)\n" "\n" ">\n" ">> +- #interrupt-cells: Should be set to 2 for IRQ number and flags.\n" ">> + The first cell is the IRQ number. IRQ numbers for different interrupt\n" ">> + source of MAX77620 are defined at dt-bindings/mfd/max77620.h\n" - ">> + The second cell is the flags, encoded as the trigger masks from binding\n" + ">> + The second cell is the flags, encoded as the trigger masks from bindi=\n" + "ng\n" ">> + document interrupts.txt, using dt-bindings/irq.\n" "> This is a very lengthy read for such little information. Please make\n" "> it more succinct. Take a look at other files for examples.\n" - "I started with as3722.txt and it seems I am carrying forward the \n" - "complexity here. Originally, as3722 is posted by me only. Any good file \n" + "I started with as3722.txt and it seems I am carrying forward the=20\n" + "complexity here. Originally, as3722 is posted by me only. Any good file=20\n" "example which I can refer?\n" "\n" "\n" @@ -82,7 +84,7 @@ ">\n" "> ... don't you think?\n" "\n" - "Agree, I can make indenting. And will do whatever places it needs in \n" + "Agree, I can make indenting. And will do whatever places it needs in=20\n" "this document.\n" "\n" ">\n" @@ -91,8 +93,8 @@ ">> +This device also supports the power OFF of system.\n" "> What is the \"power OFF of system\"?\n" "\n" - "PMIC supplies the power. So once PMIC is in OFF state, it turns off all \n" - "its rail and hence no SW execution on system. Still external supply will \n" + "PMIC supplies the power. So once PMIC is in OFF state, it turns off all=20\n" + "its rail and hence no SW execution on system. Still external supply will=20\n" "keep supply to PMIC.\n" "\n" "\n" @@ -101,19 +103,21 @@ ">> +- system-power-controller: Boolean, This device will be use as\n" "> You don't describe the type of each property, so why is this one\n" "> special?\n" - "Hmm. I describe the boolean and tristate only. Do I need to define type \n" + "Hmm. I describe the boolean and tristate only. Do I need to define type=20\n" "for integer,string also?\n" "\n" ">> +power OFF slot and slot period of the device. Device has 3 FPS as FPS0,\n" ">> +FPS1 and FPS2. The details of FPS configuration is provided through\n" ">> +subnode \"fps\". The details of FPS0, FPS1, FPS2 are provided through the\n" - ">> +child node under this subnodes. The FPS number is provided via reg property.\n" + ">> +child node under this subnodes. The FPS number is provided via reg prop=\n" + "erty.\n" ">> +\n" ">> +The property for fps child nodes as:\n" ">> +Required properties:\n" ">> +\t-reg: FPS number like 0, 1, 2 for FPS0, FPS1 and FPS2 respectively.\n" "> I'm surprised Rob Acked this. We don't usually do device numbers in DT.\n" - "What is best way to make the child node for FPS and differentiate FPS0,1, 2?\n" + "What is best way to make the child node for FPS and differentiate FPS0,1, 2=\n" + "?\n" "What is your suggestion here?\n" "\n" "\n" @@ -137,24 +141,24 @@ "> property not present? If not, can't you just remove the entire node?\n" "> Or am I missing something?\n" "\n" - "Here, my need is to connect different FPS source inputs EN0, EN1 or SW. \n" - "They can connected to any inputs. That's why fps-enable-input select the \n" + "Here, my need is to connect different FPS source inputs EN0, EN1 or SW.=20\n" + "They can connected to any inputs. That's why fps-enable-input select the=20\n" "related digital input for given FPS.\n" - "However, I can reduce the need of \"fps-sw-enable\" and make this always \n" - "enable if fps-enable-input= <SW>.\n" + "However, I can reduce the need of \"fps-sw-enable\" and make this always=20\n" + "enable if fps-enable-input=3D <SW>.\n" "\n" "Here is excerpt from datasheet:\n" "B3:B1: SRCFPSx[1:0]\n" " Enable Source. Specifies the enable source for the sequencer.\n" - " 0b00=EN0 hardware input\n" - " 0b01=EN1 hardware input\n" - " 0b10=ENFPSx software bit\n" - " 0b11=reserved\n" + " 0b00=3DEN0 hardware input\n" + " 0b01=3DEN1 hardware input\n" + " 0b10=3DENFPSx software bit\n" + " 0b11=3Dreserved\n" "B0 ENFPSx\n" " Software Enable\n" - " 0=Disable FPSx\n" - " 1=Enable FPSx\n" - " X=ENFPSx is a don\302\222t care if SRCFPSx[1:0] != 0b10\n" + " 0=3DDisable FPSx\n" + " 1=3DEnable FPSx\n" + " X=3DENFPSx is a don=E2=80=99t care if SRCFPSx[1:0] !=3D 0b10\n" "\n" "\n" ">\n" @@ -163,18 +167,26 @@ "Low Power Mode (LPM). I will add details.\n" "\n" "> +Pinmux and GPIO:\n" - "> +===============\n" + "> +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D\n" "> I think this whole section needs moving to ../pinctrl and needs to be\n" "> reviewed by Linus W.\n" "\n" - "Is this mean I need to create DT binding doc for the each subsystem \n" + "Is this mean I need to create DT binding doc for the each subsystem=20\n" "differently?\n" "Actually during AS3722, I had different understanding to have single file.\n" "\n" "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + "--=20\n" + "--=20\n" + "You received this message because you are subscribed to \"rtc-linux\".\n" + "Membership options at http://groups.google.com/group/rtc-linux .\n" + "Please read http://groups.google.com/group/rtc-linux/web/checklist\n" + "before submitting a driver.\n" + "---=20\n" + "You received this message because you are subscribed to the Google Groups \"=\n" + "rtc-linux\" group.\n" + "To unsubscribe from this group and stop receiving emails from it, send an e=\n" + "mail to rtc-linux+unsubscribe@googlegroups.com.\n" + For more options, visit https://groups.google.com/d/optout. -ac330677d2068ce39c689bbb24f22d0810104af62d8159380512bc26ab161d90 +7e7a72341b58e47f4e3aa76d134df81f81914b6e8c61f188249b791155e0ab99
diff --git a/a/1.txt b/N2/1.txt index ff345c4..6043dbd 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -142,9 +142,3 @@ Low Power Mode (LPM). I will add details. Is this mean I need to create DT binding doc for the each subsystem differently? Actually during AS3722, I had different understanding to have single file. - - --- -To unsubscribe from this list: send the line "unsubscribe linux-gpio" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 728e8cc..e590b73 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -5,25 +5,25 @@ "Subject\0Re: [PATCH V4 1/5] DT: mfd: add device-tree binding doc fro PMIC max77620/max20024\0" "Date\0Mon, 25 Jan 2016 20:38:53 +0530\0" "To\0Lee Jones <lee.jones@linaro.org>\0" - "Cc\0robh+dt@kernel.org" - pawel.moll@arm.com - mark.rutland@arm.com - ijc+devicetree@hellion.org.uk - galak@codeaurora.org - linus.walleij@linaro.org - gnurou@gmail.com - broonie@kernel.org - a.zummo@towertech.it - alexandre.belloni@free-electrons.com - lgirdwood@gmail.com - devicetree@vger.kernel.org - linux-kernel@vger.kernel.org - linux-gpio@vger.kernel.org - rtc-linux@googlegroups.com - swarren@nvidia.com - treding@nvidia.com - k.kozlowski@samsung.com - " vreddytalla@nvidia.com\0" + "Cc\0<robh+dt@kernel.org>" + <pawel.moll@arm.com> + <mark.rutland@arm.com> + <ijc+devicetree@hellion.org.uk> + <galak@codeaurora.org> + <linus.walleij@linaro.org> + <gnurou@gmail.com> + <broonie@kernel.org> + <a.zummo@towertech.it> + <alexandre.belloni@free-electrons.com> + <lgirdwood@gmail.com> + <devicetree@vger.kernel.org> + <linux-kernel@vger.kernel.org> + <linux-gpio@vger.kernel.org> + <rtc-linux@googlegroups.com> + <swarren@nvidia.com> + <treding@nvidia.com> + <k.kozlowski@samsung.com> + " <vreddytalla@nvidia.com>\0" "\00:1\0" "b\0" "\n" @@ -169,12 +169,6 @@ "\n" "Is this mean I need to create DT binding doc for the each subsystem \n" "differently?\n" - "Actually during AS3722, I had different understanding to have single file.\n" - "\n" - "\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe linux-gpio\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + Actually during AS3722, I had different understanding to have single file. -ac330677d2068ce39c689bbb24f22d0810104af62d8159380512bc26ab161d90 +63cd76d1d75c05330e58d784d67a50328b48664cf137d2b63dec81322e508aaa
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.