From mboxrd@z Thu Jan  1 00:00:00 1970
From: marc.zyngier@arm.com (Marc Zyngier)
Date: Mon, 25 Jan 2016 16:19:24 +0000
Subject: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused
In-Reply-To: <1453737499-1960073-1-git-send-email-arnd@arndb.de>
References: <1453737499-1960073-1-git-send-email-arnd@arndb.de>
Message-ID: <56A64B0C.2010809@arm.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 25/01/16 15:58, Arnd Bergmann wrote:
> The init_eint array in the s3c24xx irqchip driver is used by
> every individual chip variant, but Kconfig allows building
> the driver when they are all disabled, and that leads to
> a harmless compile-time warning:
> 
> drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
> 
> This marks the array as __maybe_unused to avoid the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/irqchip/irq-s3c24xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index c71914e8f596..5dc5a760c723 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -605,7 +605,7 @@ err:
>  	return ERR_PTR(ret);
>  }
>  
> -static struct s3c_irq_data init_eint[32] = {
> +static struct s3c_irq_data __maybe_unused init_eint[32] = {
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
> 

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.
-- 
Jazz is not dead. It just smells funny...

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933498AbcAYQTa (ORCPT <rfc822;w@1wt.eu>);
	Mon, 25 Jan 2016 11:19:30 -0500
Received: from foss.arm.com ([217.140.101.70]:38994 "EHLO foss.arm.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S932251AbcAYQT1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 25 Jan 2016 11:19:27 -0500
Subject: Re: [PATCH] irqchip: s3c24xx: mark init_eint as __maybe_unused
To: Arnd Bergmann <arnd@arndb.de>, Jason Cooper <jason@lakedaemon.net>
References: <1453737499-1960073-1-git-send-email-arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org, Thomas Gleixner <tglx@linutronix.de>,
        linux-kernel@vger.kernel.org
From: Marc Zyngier <marc.zyngier@arm.com>
Organization: ARM Ltd
Message-ID: <56A64B0C.2010809@arm.com>
Date: Mon, 25 Jan 2016 16:19:24 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <1453737499-1960073-1-git-send-email-arnd@arndb.de>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 25/01/16 15:58, Arnd Bergmann wrote:
> The init_eint array in the s3c24xx irqchip driver is used by
> every individual chip variant, but Kconfig allows building
> the driver when they are all disabled, and that leads to
> a harmless compile-time warning:
> 
> drivers/irqchip/irq-s3c24xx.c:608:28: error: 'init_eint' defined but not used [-Werror=unused-variable]
> 
> This marks the array as __maybe_unused to avoid the warning.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/irqchip/irq-s3c24xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-s3c24xx.c b/drivers/irqchip/irq-s3c24xx.c
> index c71914e8f596..5dc5a760c723 100644
> --- a/drivers/irqchip/irq-s3c24xx.c
> +++ b/drivers/irqchip/irq-s3c24xx.c
> @@ -605,7 +605,7 @@ err:
>  	return ERR_PTR(ret);
>  }
>  
> -static struct s3c_irq_data init_eint[32] = {
> +static struct s3c_irq_data __maybe_unused init_eint[32] = {
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
>  	{ .type = S3C_IRQTYPE_NONE, }, /* reserved */
> 

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

	M.
-- 
Jazz is not dead. It just smells funny...