From mboxrd@z Thu Jan 1 00:00:00 1970 From: rjui@broadcom.com (Ray Jui) Date: Mon, 25 Jan 2016 09:15:45 -0800 Subject: [PATCH] ARM: bcm: use const and __initconst for smp_operations In-Reply-To: <1453721475-15156-1-git-send-email-yamada.masahiro@socionext.com> References: <1453721475-15156-1-git-send-email-yamada.masahiro@socionext.com> Message-ID: <56A65841.1040100@broadcom.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Masahiro, On 1/25/2016 3:31 AM, Masahiro Yamada wrote: > This newly added code missed the global fixup by commit 75305275a721 > ("ARM: use const and __initconst for smp_operations"). So fix it now. > > Also, add missing "static" qualifier. > > Signed-off-by: Masahiro Yamada > --- > > arch/arm/mach-bcm/platsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c > index 575defc..cfae9c7 100644 > --- a/arch/arm/mach-bcm/platsmp.c > +++ b/arch/arm/mach-bcm/platsmp.c > @@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = { > CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method", > &bcm_smp_ops); > > -struct smp_operations nsp_smp_ops __initdata = { > +static const struct smp_operations nsp_smp_ops __initconst = { > .smp_prepare_cpus = bcm_smp_prepare_cpus, > .smp_boot_secondary = nsp_boot_secondary, > }; > This fix looks good to me. Thanks! Reviewed-by: Ray Jui From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933745AbcAYRPx (ORCPT ); Mon, 25 Jan 2016 12:15:53 -0500 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:61736 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932913AbcAYRPs (ORCPT ); Mon, 25 Jan 2016 12:15:48 -0500 X-IronPort-AV: E=Sophos;i="5.22,345,1449561600"; d="scan'208";a="86415274" Subject: Re: [PATCH] ARM: bcm: use const and __initconst for smp_operations To: Masahiro Yamada , References: <1453721475-15156-1-git-send-email-yamada.masahiro@socionext.com> CC: Scott Branden , , Russell King , , Florian Fainelli From: Ray Jui Message-ID: <56A65841.1040100@broadcom.com> Date: Mon, 25 Jan 2016 09:15:45 -0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1453721475-15156-1-git-send-email-yamada.masahiro@socionext.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Masahiro, On 1/25/2016 3:31 AM, Masahiro Yamada wrote: > This newly added code missed the global fixup by commit 75305275a721 > ("ARM: use const and __initconst for smp_operations"). So fix it now. > > Also, add missing "static" qualifier. > > Signed-off-by: Masahiro Yamada > --- > > arch/arm/mach-bcm/platsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-bcm/platsmp.c b/arch/arm/mach-bcm/platsmp.c > index 575defc..cfae9c7 100644 > --- a/arch/arm/mach-bcm/platsmp.c > +++ b/arch/arm/mach-bcm/platsmp.c > @@ -283,7 +283,7 @@ static const struct smp_operations bcm_smp_ops __initconst = { > CPU_METHOD_OF_DECLARE(bcm_smp_bcm281xx, "brcm,bcm11351-cpu-method", > &bcm_smp_ops); > > -struct smp_operations nsp_smp_ops __initdata = { > +static const struct smp_operations nsp_smp_ops __initconst = { > .smp_prepare_cpus = bcm_smp_prepare_cpus, > .smp_boot_secondary = nsp_boot_secondary, > }; > This fix looks good to me. Thanks! Reviewed-by: Ray Jui