From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNlG1-0003f3-OF for qemu-devel@nongnu.org; Mon, 25 Jan 2016 12:48:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNlG0-0002z4-LQ for qemu-devel@nongnu.org; Mon, 25 Jan 2016 12:48:53 -0500 References: <1453495865-9649-1-git-send-email-jsnow@redhat.com> <1453495865-9649-11-git-send-email-jsnow@redhat.com> <56A2982E.1060104@redhat.com> From: Eric Blake Message-ID: <56A65FFE.4070906@redhat.com> Date: Mon, 25 Jan 2016 10:48:46 -0700 MIME-Version: 1.0 In-Reply-To: <56A2982E.1060104@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ggu7xWpr91Q75VQoMhKbpodPnbBQGRDvk" Subject: Re: [Qemu-devel] [PATCH v5 10/12] fdc: rework pick_geometry List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-block@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ggu7xWpr91Q75VQoMhKbpodPnbBQGRDvk Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/22/2016 01:59 PM, John Snow wrote: >=20 >=20 > On 01/22/2016 03:51 PM, John Snow wrote: >> This one is the crazy one. >> >> fd_revalidate currently uses pick_geometry to tell if the diskette >> geometry has changed upon an eject/insert event, but it won't allow us= >> to insert a 1.44MB diskette into a 2.88MB drive. This is inflexible. >> >> The new algorithm applies a new heuristic to guessing disk geometries >> that allows us to switch diskette types as long as the physical size >> matches before falling back to the old heuristic. >> >> The old one is roughly: >> - If the size (sectors) and type matches, choose it. >> - Fall back to the first geometry that matched our type. >> >> The new one is: >> - If the size (sectors) and type matches, choose it. >> - If the size (sectors) and physical size match, choose it. >> - If the size (sectors) matches at all, choose it begrudgingly. >> - Fall back to the first geometry that matched our type. >> >=20 > Goofed and didn't update commit. Will change on PULL to omit the third > line if the patch is otherwise OK. Yep, that's the only thing I noticed. Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ggu7xWpr91Q75VQoMhKbpodPnbBQGRDvk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWpl/+AAoJEKeha0olJ0NqhvEH/0fCCGosjgoEJQ+FCfq1ztZE 5G4Aw/nLov/szoPCDZrMXQbRGZpGc7WMes/3aCXEu3OTQ3RdgDLMqCwiW/zIEwS4 4jE5C2RsnOo0aifdGDChRLpb2IAeajU4CWXn8NgGpE2n6sUEWRqDUO/j10RBU9En sCEvgEdNHOwxEH+e2oev3cSw0oRDqjL5pUoemkaeK78l87aRRG5fGuigZMq2fnth caXfE4moR0/6InwzwWGbuoYkSBdDGKWQLhIm/9cPUG1jPBe0f31/xnbFmeqDNEUV W/WwfZ63svQ4PxQRubIkE8kkN0y01LZ+VL+WA32SGvDCZzqDxH8inhsxxtGy9PM= =5CkZ -----END PGP SIGNATURE----- --Ggu7xWpr91Q75VQoMhKbpodPnbBQGRDvk--