From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mario Kleiner Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon Date: Mon, 25 Jan 2016 20:30:14 +0100 Message-ID: <56A677C6.4050909@gmail.com> References: <56A0989E.30006@daenzer.net> <20160121100905.GL19130@phenom.ffwll.local> <56A19C98.8020208@daenzer.net> <20160122151835.GM23290@intel.com> <56A5A171.7000205@daenzer.net> <56A6203D.3030803@gmail.com> <20160125132310.GS23290@intel.com> <56A626D5.2040808@gmail.com> <20160125145309.GT23290@intel.com> <56A64F86.9080605@gmail.com> <20160125185122.GV11240@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8BBB46E531 for ; Mon, 25 Jan 2016 11:30:19 -0800 (PST) Received: by mail-wm0-f50.google.com with SMTP id l65so77493220wmf.1 for ; Mon, 25 Jan 2016 11:30:19 -0800 (PST) In-Reply-To: <20160125185122.GV11240@phenom.ffwll.local> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Alex Deucher , Vlastimil Babka , LKML , dri-devel@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= List-Id: dri-devel@lists.freedesktop.org CgpPbiAwMS8yNS8yMDE2IDA3OjUxIFBNLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+IE9uIE1vbiwg SmFuIDI1LCAyMDE2IGF0IDA1OjM4OjMwUE0gKzAxMDAsIE1hcmlvIEtsZWluZXIgd3JvdGU6Cj4+ IFJlYWRkaW5nIERhbmllbCwgd2hpY2ggc29tZWhvdyBnb3QgZHJvcHBlZCBmcm9tIHRoZSBjYy4K Pj4KPj4gT24gMDEvMjUvMjAxNiAwMzo1MyBQTSwgVmlsbGUgU3lyasOkbMOkIHdyb3RlOgo+Pj4g T24gTW9uLCBKYW4gMjUsIDIwMTYgYXQgMDI6NDQ6NTNQTSArMDEwMCwgTWFyaW8gS2xlaW5lciB3 cm90ZToKPj4+Pgo+Pj4+Cj4+Pj4gT24gMDEvMjUvMjAxNiAwMjoyMyBQTSwgVmlsbGUgU3lyasOk bMOkIHdyb3RlOgo+Pj4+PiBPbiBNb24sIEphbiAyNSwgMjAxNiBhdCAwMjoxNjo0NVBNICswMTAw LCBNYXJpbyBLbGVpbmVyIHdyb3RlOgo+Pj4+Pj4KPj4+Pj4+Cj4+Pj4+PiBPbiAwMS8yNS8yMDE2 IDA1OjE1IEFNLCBNaWNoZWwgRMOkbnplciB3cm90ZToKPj4+Pj4+PiBPbiAyMy4wMS4yMDE2IDAw OjE4LCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4+Pj4+Pj4+IE9uIEZyaSwgSmFuIDIyLCAyMDE2 IGF0IDEyOjA2OjAwUE0gKzA5MDAsIE1pY2hlbCBEw6RuemVyIHdyb3RlOgo+Pj4+Pj4+Pj4KPj4+ Pj4+Pj4+IFsgVHJpbW1pbmcgS0RFIGZvbGtzIGZyb20gQ2MgXQo+Pj4+Pj4+Pj4KPj4+Pj4+Pj4+ IE9uIDIxLjAxLjIwMTYgMTk6MDksIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+Pj4+Pj4+Pj4gT24g VGh1LCBKYW4gMjEsIDIwMTYgYXQgMDU6MzY6NDZQTSArMDkwMCwgTWljaGVsIETDpG56ZXIgd3Jv dGU6Cj4+Pj4+Pj4+Pj4+IE9uIDIxLjAxLjIwMTYgMTY6NTgsIERhbmllbCBWZXR0ZXIgd3JvdGU6 Cj4+Pj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4+Pj4gQ2FuIHlvdSBwbGVhc2UgcG9pbnQgbWUgYXQgdGhl IHZibGFuayBvbi9vZmYganVtcCBidWcgcGxlYXNlPwo+Pj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4+PiBB RkFJUiBJIG9yaWdpbmFsbHkgcmVwb3J0ZWQgaXQgaW4gcmVzcG9uc2UgdG8KPj4+Pj4+Pj4+Pj4g aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9hcmNoaXZlcy9kcmktZGV2ZWwvMjAxNS1BdWd1 c3QvMDg3ODQxLmh0bWwKPj4+Pj4+Pj4+Pj4gLCBidXQgSSBjYW4ndCBmaW5kIHRoYXQgaW4gdGhl IGFyY2hpdmVzLCBzbyBtYXliZSB0aGF0IHdhcyBqdXN0IG9uIElSQy4KPj4+Pj4+Pj4+Pj4gU2Vl Cj4+Pj4+Pj4+Pj4+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvYXJjaGl2ZXMvZHJpLWRl dmVsLzIwMTYtSmFudWFyeS8wOTkxMjIuaHRtbAo+Pj4+Pj4+Pj4+PiAuIEJhc2ljYWxseSwgSSBy YW4gaW50byB0aGUgYnVnIGZpeGVkIGJ5IHlvdXIgcGF0Y2ggYmVjYXVzZSB0aGUgY291bnRlcgo+ Pj4+Pj4+Pj4+PiBqdW1wZWQgZm9yd2FyZCBvbiBldmVyeSBEUE1TIG9mZiwgc28gaXQgaGl0IHRo ZSAzMi1iaXQgYm91bmRhcnkgYWZ0ZXIKPj4+Pj4+Pj4+Pj4ganVzdCBhIGZldyBkYXlzLgo+Pj4+ Pj4+Pj4+Cj4+Pj4+Pj4+Pj4gT2ssIHNvIGp1c3QgdW5jb3ZlcmVkIHRoZSBvdmVyZmxvdyBidWcu Cj4+Pj4+Pj4+Pgo+Pj4+Pj4+Pj4gTm90IHN1cmUgd2hhdCB5b3UgbWVhbiBieSAianVzdCIsIGJ1 dCB0byBiZSBjbGVhcjogVGhlIGRybV92Ymxhbmtfb24vb2ZmCj4+Pj4+Pj4+PiBjb3VudGVyIGp1 bXBpbmcgYnVnIChzaW1pbGFyIHRvIHRoZSBidWcgdGhpcyB0aHJlYWQgaXMgYWJvdXQpLCB3aGlj aAo+Pj4+Pj4+Pj4gZXhwb3NlZCB0aGUgb3ZlcmZsb3cgYnVnLCBpcyBzdGlsbCBhbGl2ZSBhbmQg a2lja2luZyBpbiA0LjUuIEl0IHNlZW1zCj4+Pj4+Pj4+PiB0byBoYXBwZW4gd2hlbiB0dXJuaW5n IG9mZiB0aGUgQ1JUQzoKPj4+Pj4+Pj4+Cj4+Pj4+Pj4+PiBbZHJtOmRybV91cGRhdGVfdmJsYW5r X2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAwOiBjdXJyZW50PTIxODEwNDY5 NCwgZGlmZj0wLCBodz05MTYgaHdfbGFzdD05MTYKPj4+Pj4+Pj4+IFtkcm06cmFkZW9uX2dldF92 YmxhbmtfY291bnRlcl9rbXNdIGNydGMgMDogZGlzdCBmcm9tIHZibGFuayBzdGFydCAzCj4+Pj4+ Pj4+PiBbZHJtOmRybV9jYWxjX3ZibHRpbWVzdGFtcF9mcm9tX3NjYW5vdXRwb3NdIGNydGMgMCA6 IHYgMHg3IHAoMjE5OSwtNDUpQCA3MzA0LjMwNzM1NCAtPiA3MzA0LjMwODAwNiBbZSAwIHVzLCAw IHJlcF0KPj4+Pj4+Pj4+IFtkcm06cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIGNydGMg MDogZGlzdCBmcm9tIHZibGFuayBzdGFydCAzCj4+Pj4+Pj4+PiBbZHJtOmRybV91cGRhdGVfdmJs YW5rX2NvdW50XSB1cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAwOiBjdXJyZW50PTIxODEw NDY5NCwgZGlmZj0xNjc3NjMwMSwgaHc9MSBod19sYXN0PTkxNgo+Pj4+Pj4+Pgo+Pj4+Pj4+PiBO b3Qgc3VyZSB3aGF0IGJ1ZyB3ZSdyZSB0YWxraW5nIGFib3V0IGhlcmUsIGJ1dCBoZXJlIHRoZSBo dyBjb3VudGVyCj4+Pj4+Pj4+IGNsZWFybHkganVtcHMgYmFja3dhcmRzLgo+Pj4+Pj4+Pgo+Pj4+ Pj4+Pj4gW2RybTpyYWRlb25fZ2V0X3ZibGFua19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBz dGF0IDMKPj4+Pj4+Pj4+IFtkcm06cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIFF1ZXJ5 IGZhaWxlZCEgc3RhdCAzCj4+Pj4+Pj4+PiBbZHJtOmRybV91cGRhdGVfdmJsYW5rX2NvdW50XSB1 cGRhdGluZyB2YmxhbmsgY291bnQgb24gY3J0YyAxOiBjdXJyZW50PTAsIGRpZmY9MCwgaHc9MCBo d19sYXN0PTAKPj4+Pj4+Pj4+IFtkcm06cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIFF1 ZXJ5IGZhaWxlZCEgc3RhdCAzCj4+Pj4+Pj4+PiBbZHJtOnJhZGVvbl9nZXRfdmJsYW5rX2NvdW50 ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMwo+Pj4+Pj4+Pj4gW2RybTpkcm1fdXBkYXRlX3Zi bGFua19jb3VudF0gdXBkYXRpbmcgdmJsYW5rIGNvdW50IG9uIGNydGMgMjogY3VycmVudD0wLCBk aWZmPTAsIGh3PTAgaHdfbGFzdD0wCj4+Pj4+Pj4+PiBbZHJtOnJhZGVvbl9nZXRfdmJsYW5rX2Nv dW50ZXJfa21zXSBRdWVyeSBmYWlsZWQhIHN0YXQgMwo+Pj4+Pj4+Pj4gW2RybTpyYWRlb25fZ2V0 X3ZibGFua19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0IDMKPj4+Pj4+Pj4+IFtkcm06 ZHJtX3VwZGF0ZV92YmxhbmtfY291bnRdIHVwZGF0aW5nIHZibGFuayBjb3VudCBvbiBjcnRjIDM6 IGN1cnJlbnQ9MCwgZGlmZj0wLCBodz0wIGh3X2xhc3Q9MAo+Pj4+Pj4+Pj4gW2RybTpyYWRlb25f Z2V0X3ZibGFua19jb3VudGVyX2ttc10gUXVlcnkgZmFpbGVkISBzdGF0IDEKPj4+Pj4+Pj4+IFtk cm06ZHJtX2NhbGNfdmJsdGltZXN0YW1wX2Zyb21fc2Nhbm91dHBvc10gY3J0YyAwIDogdiAweDEg cCgwLDApQCA3MzA0LjMxNzE0MCAtPiA3MzA0LjMxNzE0MCBbZSAwIHVzLCAwIHJlcF0KPj4+Pj4+ Pj4+IFtkcm06cmFkZW9uX2dldF92YmxhbmtfY291bnRlcl9rbXNdIFF1ZXJ5IGZhaWxlZCEgc3Rh dCAxCj4+Pj4+Pj4+PiBbZHJtOmRybV91cGRhdGVfdmJsYW5rX2NvdW50XSB1cGRhdGluZyB2Ymxh bmsgY291bnQgb24gY3J0YyAwOiBjdXJyZW50PTIzNDg4MDk5NSwgZGlmZj0xNjc3NzIxNSwgaHc9 MCBod19sYXN0PTEKPj4+Pj4+Pj4KPj4+Pj4+Pj4gU2FtZSBoZXJlLgo+Pj4+Pj4+Cj4+Pj4+Pj4g QXQgbGVhc3Qgb25lIG9mIHRoZSBqdW1wcyBpcyBleHBlY3RlZCwgYmVjYXVzZSB0aGlzIGlzIGFy b3VuZCB0dXJuaW5nCj4+Pj4+Pj4gb2ZmIHRoZSBDUlRDIGZvciBEUE1TIG9mZi4gRG9uJ3Qga25v dyB5ZXQgd2h5IHRoZXJlIGFyZSB0d28ganVtcHMgYmFjawo+Pj4+Pj4+IHRob3VnaC4KPj4+Pj4+ Pgo+Pj4+Pj4+Cj4+Pj4+Pj4+IFRoZXNlIHRoaW5ncyBqdXN0IGRvbid0IGhhcHBlbiBvbiBpOTE1 IGJlY2F1c2UgZHJtX3ZibGFua19vZmYoKSBhbmQKPj4+Pj4+Pj4gZHJtX3ZibGFua19vbigpIGFy ZSBhbHdheXMgY2FsbGVkIGFyb3VuZCB0aGUgdGltZXMgd2hlbiB0aGUgaHcgY291bnRlcgo+Pj4+ Pj4+PiBtaWdodCBnZXQgcmVzZXQuIE9yIGF0IGxlYXN0IHRoYXQncyBob3cgaXQgc2hvdWxkIGJl Lgo+Pj4+Pj4+Cj4+Pj4+Pj4gV2hpY2ggaXMgb2YgY291cnNlIHRoZSBpZGVhIG9mIERhbmllbCdz IHBhdGNoICh3aGljaCBpcyB3aGF0IEknbSBnZXR0aW5nCj4+Pj4+Pj4gdGhlIGFib3ZlIHdpdGgp IG9yIE1hcmlvJ3MgcGF0Y2ggYXMgd2VsbCwgYnV0IGNsZWFybHkgc29tZXRoaW5nJ3Mgc3RpbGwK Pj4+Pj4+PiB3cm9uZy4gSXQncyBjZXJ0YWlubHkgcG9zc2libGUgdGhhdCBpdCdzIHNvbWV0aGlu ZyBpbiB0aGUgZHJpdmVyLCBidXQKPj4+Pj4+PiBzaW5jZSBjYWxsaW5nIGRybV92YmxhbmtfcHJl L3Bvc3RfbW9kZXNldCBmcm9tIHRoZSBzYW1lIHBsYWNlcyBzZWVtcyB0bwo+Pj4+Pj4+IHdvcmsg ZmluZSAoaWdub3JpbmcgdGhlIHJlZ3Jlc3Npb24gZGlzY3Vzc2VkIGluIHRoaXMgdGhyZWFkKS4u LiBEbwo+Pj4+Pj4+IGRybV92Ymxhbmtfb24vb2ZmIHJlcXVpcmUgc29tZXRoaW5nIGVsc2UgdG8g aGFuZGxlIHRoaXMgY29ycmVjdGx5Pwo+Pj4+Pj4+Cj4+Pj4+Pj4KPj4+Pj4+Cj4+Pj4+PiBJIHN1 c3BlY3QgaXQgaXMgYmVjYXVzZSB2YmxhbmtfZGlzYWJsZV9hbmRfc2F2ZSBjYWxscwo+Pj4+Pj4g ZHJtX3VwZGF0ZV92YmxhbmtfY291bnQoKSB1bmNvbmRpdGlvbmFsbHksIGV2ZW4gaWYgdmJsYW5r IGlycXMgYXJlCj4+Pj4+PiBhbHJlYWR5IG9mZi4KPj4+Pj4+Cj4+Pj4+PiBTbyBvbiBhIG1hbnVh bCBkaXNwbGF5IGRpc2FibGUgLT4gcmVlbmFibGUgeW91IGdldCBzb21ldGhpbmcgbGlrZQo+Pj4+ Pj4KPj4+Pj4+IEF0IGRpc2FibGU6Cj4+Pj4+Pgo+Pj4+Pj4gQ2FsbCB0byBkcG1zLW9mZiAtLT4g YXRvbWJpb3NfY3J0Y19kcG1zKERQTVNfT0ZGKSAtLT4gZHJtX3ZibGFua19vZmYgLT4KPj4+Pj4+ IHZibGFua19kaXNhYmxlX2FuZF9zYXZlIC0+IGlycXMgb2ZmLCBkcm1fdXBkYXRlX3ZibGFua19j b3VudCgpIGNvbXB1dGVzCj4+Pj4+PiBmaW5hbCBjb3VudC4KPj4+Pj4+Cj4+Pj4+PiBUaGVuIHRo ZSBjcnRjIGlzIHNodXQgZG93biBhbmQgaXRzIGh3IGNvdW50ZXIgcmVzZXRzIHRvIHplcm8uCj4+ Pj4+Pgo+Pj4+Pj4gQXQgcmVlbmFibGU6Cj4+Pj4+Pgo+Pj4+Pj4gTW9kZXNldHRpbmcgLT4gZHJt X2NydGNfaGVscGVyX3NldF9tb2RlIC0+IGNydGNfZnVuY3MtPnByZXBhcmUoY3J0YykgLT4KPj4+ Pj4+IGF0b21iaW9zX2NydGNfcHJlcGFyZSgpIC0+IGF0b21iaW9zX2NydGNfZHBtcyhEUE1TX09G RikgLT4KPj4+Pj4+IGRybV92Ymxhbmtfb2ZmIC0+IHZibGFua19kaXNhYmxlX2FuZF9zYXZlIC0+ IEEgcG9pbnRsZXNzCj4+Pj4+PiBkcm1fdXBkYXRlX3ZibGFua19jb3VudCgpIHdoaWxlIHRoZSBo dyBjb3VudGVyIGlzIGFscmVhZHkgcmVzZXQgdG8gemVybwo+Pj4+Pj4gLS0+IFVud2FudGVkIGNv dW50ZXIganVtcC4KPj4+Pj4+Cj4+Pj4+Pgo+Pj4+Pj4gVGhlIHByb2JsZW0gZG9lc24ndCBoYXBw ZW4gb24gYSBwdXJlIG1vZGVzZXQgdG8gYSBkaWZmZXJlbnQgdmlkZW8KPj4+Pj4+IHJlc29sdXRp b24vcmVmcmVzaCByYXRlLCBhcyB0aGVuIHdlIG9ubHkgaGF2ZSBvbmUgY2FsbCBpbnRvCj4+Pj4+ PiBhdG9tYmlvc19jcnRjX2RwbXMoRFBNU19PRkYpLgo+Pj4+Pj4KPj4+Pj4+IEkgdGhpbmsgdGhl IGZpeCBpcyB0byBmaXggdmJsYW5rX2Rpc2FibGVfYW5kX3NhdmUoKSB0byBvbmx5IGNhbGwKPj4+ Pj4+IGRybV91cGRhdGVfdmJsYW5rX2NvdW50KCkgaWYgdmJsYW5rIGlycXMgZ2V0IGFjdHVhbGx5 IGRpc2FibGVkLCBub3Qgb24KPj4+Pj4+IG5vLW9wIGNhbGxzLiBJIHdpbGwgdHJ5IHRoYXQgbm93 Lgo+Pj4+Pgo+Pj4+PiBJdCBkb2VzIHRoYXQgb24gcHVycG9zZS4gT3RoZXJ3aXNlIHRoZSB2Ymxh bmsgY291bnRlciB3b3VsZCBhcHBlYXIgdG8KPj4+Pj4gaGF2ZSBzdGFsbGVkIHdoaWxlIHRoZSBp bnRlcnJ1cHQgd2FzIG9mZi4KPj4+Pj4KPj4+Pgo+Pj4+IE9rLCB0aGF0J3Mgd2hhdCB0aGUgY29t bWVudHMgdGhlcmUgc2F5LCBhbHRob3VnaCBpIGRvbid0IHNlZSBhdG0uIHdoeQo+Pj4+IHRoYXQg cGVyY2VpdmVkIHN0YWxsIHdvdWxkIGJlIGEgYmlnIHByb2JsZW0uIEkgY2hlY2tlZCBhbGwgY2Fs bGVycyBvZgo+Pj4+IHZibGFua19kaXNhYmxlX2FuZF9zYXZlKCkuIFRoZXkgYXJlIGFsbCBjYXJl ZnVsIHRvIG5vdCBjYWxsIHRoYXQKPj4+PiBmdW5jdGlvbiBpZiB2YmxhbmtzIGFyZSBhbHJlYWR5 IGRpc2FibGVkLiBUaGUgb25seSBleGNlcHRpb24gaXMKPj4+PiBkcm1fdmJsYW5rX29mZigpLiBJ ZiBkcm1fdmJsYW5rX29mZi9vbiBpcyBzdXBwb3NlZCB0byBwcm90ZWN0IGttcwo+Pj4+IGRyaXZl cnMgd2hpY2ggaGF2ZSByZXNldHRpbmcgaHcgY291bnRlcnMgb3Igb3RoZXIgcHJvYmxlbWF0aWMg YmVoYXZpb3VyCj4+Pj4gZHVyaW5nIG1vZGVzZXRzIGV0Yy4gdGhlbiB0aGlzIHdpbGwgYnJlYWsu IEUuZy4sIGNhbGxpbmcgdGhlIHZibGFuawo+Pj4+IHRpbWVzdGFtcGluZyBzdHVmZiBpcyBhbHNv IG5vdCBzYWZlL3dlbGwtZGVmaW5lZCBkdXJpbmcgbW9kZXNldHMgd2hlbgo+Pj4+IHRoZSB0aW1l c3RhbXBpbmcgY29uc3RhbnRzIGFyZSBub3QgKHlldCkgdXBkYXRlZCB0byByZWZsZWN0IHRoZSBu ZXcgbW9kZQo+Pj4+IHRpbWluZyBvZiB0aGUgbW9kZXNldCBpbiBwcm9ncmVzcy4KPj4+Cj4+PiBU aGUgaWRlYSBpcyB0byBtYWludGFpbiB0aGUgYXBwZWFyYW5jZSB0aGF0IHRoZSBjb3VudGVyIHRp Y2tzIGFsbCB0aGUKPj4+IHRpbWUgYXMgbG9uZyBhcyB0aGUgY3J0YyBpcyBhY3RpdmUuIFdoaWxl IHRoYXQgbWF5IG5vdCBiZSByZWFsbHkKPj4+IHJlcXVpcmVkIGluIGNhc2UgaWYgbm8gb25lIGlz IGN1cnJlbnRseSBpbnRlcmVzdGVkIGluIHRoZSB2YmxhbmsKPj4+IGNvdW50ZXIsIEkgdGhpbmsg aXQncyBhIG5pY2UgdGhpbmcgdG8gaGF2ZSBqdXN0IHRvIG1ha2UgdGhlIGJlaGF2aW91cgo+Pj4g b2YgdGhlIGNvdW50ZXIgY29uc2lzdGVudC4KPj4+Cj4+PiBBcyBmYXIgYXMgY2FsbGluZyBkcm1f dmJsYW5rX29mZigpIGFmdGVyIHRoZSBodyBjb3VudGVyIGdvdCByZXNldCwgd2VsbCwKPj4+IHRo YXQgbm90IGNvcnJlY3QuIEl0IHNob3VsZCBiZSBjYWxsZWQgYmVmb3JlIHRoZSByZXNldC4KPj4K Pj4gV2hhdCByYWRlb24gZG9lcyBpcyBjYWxsaW5nIGRybV92Ymxhbmtfb2ZmIGF0IGJlZ2lubmlu ZyBvZiBEUE1TX09GRi4gVGhlCj4+IGZpcnN0IGNhbGwgdG8gRE1QU19PRkYgd2lsbCBjYWxsIGRy bV92Ymxhbmtfb2ZmKCkgYW5kIHJlYWxseSBkaXNhYmxlCj4+IHZibGFuay1pcnFzIGlmIHRoZXkg d2VyZSBydW5uaW5nLCB1cGRhdGluZyB0aGUgY291bnRzL3RzIGEgbGFzdCB0aW1lLiBCdXQKPj4g dGhlbiB0aGUgZHBtcyBvZmYgd2lsbCByZXNldCB0aGUgaHcgY291bnRlciB0byB6ZXJvLiBXaGVu IG9uZSByZWVuYWJsZXMgdGhlCj4+IGRpc3BsYXksIGEgc2Vjb25kIGNhbGwgdG8gRFBNU19PRkYg d2lsbCBub3cgY2FsbCBkcm1fdmJsYW5rX29mZiBhZ2FpbiB3aGVuCj4+IGl0IGFwcGFyZW50bHkg c2hvdWxkbid0Lgo+Pgo+PiBJIGp1c3QgdGVzdGVkIHRoaXMgcGF0Y2gsIHdoaWNoIGZpeGVzIHRo ZSBjb3VudGVyIGp1bXBzIG9uIHJhZGVvbi1rbXMgd2l0aAo+PiBteSBvciBEYW5pZWwncyBkcm1f dmJsYW5rX29mZiBwYXRjaGVzIHRvIHJhZGVvbjoKPgo+IFRoaXMgbWlnaHQgYmUgZHVlIHRvIHRo ZSBsZWdhY3kgaGVscGVycywgd2hpY2gganVzdCBsb3ZlIHRvIHJlZHVuZGFudGx5Cj4gZGlzYWJs ZSBzdHVmZiB0aGF0J3Mgb2ZmIGFscmVhZHkuIFRoZSBwcm9ibGVtIEkgc2VlIHdpdGggbm8tb3Bp bmcgdGhlc2UKPiBvdXQgaXMgdGhhdCBmb3IgYXRvbWljIGRyaXZlcnMgKHdoaWNoIHJlYWxseSBz aG91bGQgZ2V0IHRoaXMgcmlnaHQpIHRoaXMKPiBtaWdodCBwYXBlciBvdmVyIGJ1Z3M6IEUuZy4g d2hlbiB5b3UgZm9yZ2V0IHRvIGNhbGwgX29mZigpIHdoZW4gZGlzYWJsaW5nCj4gdGhlIGNydGMs IHRoZW4gY2FsbGluZyBfb24oKSB0d2ljZSBpbiBhIHJvdyBpcyBpbmRlZWQgYSBzZXJpb3VzIGJ1 Zy4KPiBTaW1pbGFyIHdoZW4geW91IGZvcmdldCB0byBjYWxsIF9vbigpIGFuZCBoYXZlIG11bHRp cGxlIF9vZmYoKSBjYWxscyBpbiBhCj4gcm93Lgo+Cj4gU28gbm90IHN1cmUgd2hhdCB0byBkbyBo ZXJlLgo+IC1EYW5pZWwKPgoKWWVzLCB0aGUgbGVnYWN5IGhlbHBlcnMgY2F1c2UgdHdvIGNhbGxz IHRvIGRwbXMgb2ZmIGlmIG9uZSBkaXNhYmxlcyBhIApkaXNwbGF5LiBGaXJzdCBkdXJpbmcgZGlz cGxheSBkaXNhYmxlIGFzIGludGVuZGVkLiBUaGVuIHdoZW4gb25lIApyZWVuYWJsZXMgdGhlIGRp c3BsYXkgZHVyaW5nIG1vZGVzZXR0aW5nIGFzIHBhcnQgb2YgCmNydGNfZnVuY3MtPnByZXBhcmUo KSAtIGF0IGxlYXN0IG9uIHJhZGVvbi4KCk1heWJlIHRoZSBtaW5pbXVtIHRoaW5nIHRoYXQgd291 bGQgaGVscCBpcyB0byBqdXN0IGNoZWNrIGZvciAKdmJsYW5rLT5pbm1vZGVzZXQgaW4gZHJtX3Zi bGFua19vZmYoKS4gSWYgdGhhdCB3b3VsZCBiZSB0aGUgY2FzZSB3ZSdkIAprbm93IGl0IGlzIGEg cmVkdW5kYW50IGNhbGwgYW5kIGNvdWxkIG5vLW9wIGl0IGFuZCBkbyBhIApXQVJOX09OKHZibGFu ay0+aW5tb2Rlc2V0KT8KCmRybV92Ymxhbmtfb24oKSBpIGRvbid0IGtub3cgaG93IHRvIHRyZWF0 LCBidXQgdGhhdCBvbmUgY2FsbHMgCmRybV9yZXNldF92YmxhbmtfdGltZXN0YW1wKCkgd2hpY2gg c2hvdWxkIGJlIGxlc3MgcHJvYmxlbWF0aWMgaWYgY2FsbGVkIApyZWR1bmRhbnRseS4KCk5vdyB0 aGUgcGF0Y2ggaSB3YW50IHRvIHRyeSBuZXh0IHRvIGZpeCB0aGUgZHJtX3ZibGFua19wcmUvcG9z dF9tb2Rlc2V0IApyZWdyZXNzaW9uIGluIExpbnV4IDQuNC80LjUgaXMgdG8gYWRkIGEgLi4uCgpp ZiAoKGRpZmYgPiAxKSAmJiB2YmxhbmstPmlubW9kZXNldCkgZGlmZiA9IDE7CgouLi4gdG8gdGhl IGJvdHRvbSBvZiBkcm1fdXBkYXRlX3ZibGFua19jb3VudCgpLiBUaGF0IHNob3VsZCBob3BlZnVs bHkgCnJlc3RvcmUgdGhlIHByZS9wb3N0X21vZGVzZXQgYmVoYXZpb3IgYXMgY2xvc2UgdG8gdGhl IG9yaWdpbmFsIGJlaGF2aW9yIAphcyBwb3NzaWJsZS4gQXMgYSBzaWRlIGVmZmVjdCBpdCB3b3Vs ZCBhbHNvIHByZXZlbnQgdGhlIGNvdW50ZXIganVtcCAKY2F1c2VkIGJ5IHJlZHVuZGFudCBjYWxs cyB0byBkcm1fdmJsYW5rX29mZigpLgoKLW1hcmlvCgo+Pgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVy cy9ncHUvZHJtL2RybV9pcnEuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1faXJxLmMKPj4gaW5kZXgg NjA3ZjQ5My4uZDczOWQ5MyAxMDA2NDQKPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9pcnEu Ywo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2lycS5jCj4+IEBAIC0xMzEzLDcgKzEzMTMs MTAgQEAgdm9pZCBkcm1fdmJsYW5rX29mZihzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCB1bnNpZ25l ZAo+PiBpbnQgcGlwZSkKPj4gICAgICAgICAgc3Bpbl9sb2NrX2lycXNhdmUoJmRldi0+ZXZlbnRf bG9jaywgaXJxZmxhZ3MpOwo+Pgo+PiAgICAgICAgICBzcGluX2xvY2soJmRldi0+dmJsX2xvY2sp Owo+PiAtICAgICAgIHZibGFua19kaXNhYmxlX2FuZF9zYXZlKGRldiwgcGlwZSk7Cj4+ICsgICAg ICAgRFJNX0RFQlVHX1ZCTCgiY3J0YyAlZCwgdmJsYW5rIGVuYWJsZWQgJWRcbiIsIHBpcGUsCj4+ IHZibGFuay0+ZW5hYmxlZCk7Cj4+ICsKPj4gKyAgICAgICBpZiAodmJsYW5rLT5lbmFibGVkKQo+ PiArICAgICAgICAgICAgICAgdmJsYW5rX2Rpc2FibGVfYW5kX3NhdmUoZGV2LCBwaXBlKTsKPj4g ICAgICAgICAgd2FrZV91cCgmdmJsYW5rLT5xdWV1ZSk7Cj4+Cj4+ICAgICAgICAgIC8qCj4+IEBA IC0xNDE1LDYgKzE0MTgsOCBAQCB2b2lkIGRybV92Ymxhbmtfb24oc3RydWN0IGRybV9kZXZpY2Ug KmRldiwgdW5zaWduZWQKPj4gaW50IHBpcGUpCj4+ICAgICAgICAgICAgICAgICAgcmV0dXJuOwo+ Pgo+PiAgICAgICAgICBzcGluX2xvY2tfaXJxc2F2ZSgmZGV2LT52YmxfbG9jaywgaXJxZmxhZ3Mp Owo+PiArICAgICAgIERSTV9ERUJVR19WQkwoImNydGMgJWQsIHZibGFuayBlbmFibGVkICVkXG4i LCBwaXBlLAo+PiB2YmxhbmstPmVuYWJsZWQpOwo+PiArCj4+ICAgICAgICAgIC8qIERyb3Agb3Vy IHByaXZhdGUgInByZXZlbnQgZHJtX3ZibGFua19nZXQiIHJlZmNvdW50ICovCj4+ICAgICAgICAg IGlmICh2YmxhbmstPmlubW9kZXNldCkgewo+PiAgICAgICAgICAgICAgICAgIGF0b21pY19kZWMo JnZibGFuay0+cmVmY291bnQpOwo+Pgo+Pgo+Pgo+PiBBbm90aGVyLCBtYXliZSBiZXR0ZXIsIGFw cHJvYWNoIG1pZ2h0IGJlIHRvIG5vLW9wIHJlZHVuZGFudCBjYWxscyB0bwo+PiBkcm1fdmJsYW5r X29mZigpIGlmZiB2YmxhbmstPmlubW9kZXNldCBhbmQgbm8tb3AgcmVkdW5kYW50IGNhbGxzIHRv Cj4+IGRybV92Ymxhbmtfb24oKSBpZmYgIXZibGFuay0+aW5tb2Rlc2V0Lgo+Pgo+PiAtbWFyaW8K Pj4KPj4KPj4+Cj4+Pj4KPj4+PiAtbWFyaW8KPj4+Pgo+Pj4+Cj4+Pj4+Pgo+Pj4+Pj4gT3RoZXJ3 aXNlIGttcyBkcml2ZXJzIHdvdWxkIGhhdmUgdG8gYmUgY2FyZWZ1bCB0byBuZXZlciBjYWxsCj4+ Pj4+PiBkcm1fdmJsYW5rX29mZiBtdWx0aXBsZSB0aW1lcyBiZWZvcmUgY2FsbGluZyBkcm1fdmJs YW5rX29uLCBidXQgdGhlIGhlbHAKPj4+Pj4+IHRleHQgdG8gZHJtX3ZibGFua19vbigpIGNsYWlt cyB0aGF0IHVuYmFsYW5jZWQgY2FsbHMgdG8gdGhlc2UgZnVuY3Rpb25zCj4+Pj4+PiBhcmUgcGVy ZmVjdGx5IGZpbmUuCj4+Pj4+Pgo+Pj4+Pj4gLW1hcmlvCj4+Pj4+Pgo+Pj4+Pj4KPj4+Pj4+Cj4+ Pj4+Pgo+Pj4+Pj4KPj4+Pj4+Cj4+Pj4+Pgo+Pj4+Pgo+Pj4KPgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1k ZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758535AbcAYTa1 (ORCPT ); Mon, 25 Jan 2016 14:30:27 -0500 Received: from mail-wm0-f48.google.com ([74.125.82.48]:36571 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758508AbcAYTaT (ORCPT ); Mon, 25 Jan 2016 14:30:19 -0500 Subject: Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , =?UTF-8?Q?Michel_D=c3=a4nzer?= , Alex Deucher , Vlastimil Babka , LKML , dri-devel@lists.freedesktop.org, =?UTF-8?Q?Christian_K=c3=b6nig?= References: <56A0989E.30006@daenzer.net> <20160121100905.GL19130@phenom.ffwll.local> <56A19C98.8020208@daenzer.net> <20160122151835.GM23290@intel.com> <56A5A171.7000205@daenzer.net> <56A6203D.3030803@gmail.com> <20160125132310.GS23290@intel.com> <56A626D5.2040808@gmail.com> <20160125145309.GT23290@intel.com> <56A64F86.9080605@gmail.com> <20160125185122.GV11240@phenom.ffwll.local> From: Mario Kleiner Message-ID: <56A677C6.4050909@gmail.com> Date: Mon, 25 Jan 2016 20:30:14 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <20160125185122.GV11240@phenom.ffwll.local> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/25/2016 07:51 PM, Daniel Vetter wrote: > On Mon, Jan 25, 2016 at 05:38:30PM +0100, Mario Kleiner wrote: >> Readding Daniel, which somehow got dropped from the cc. >> >> On 01/25/2016 03:53 PM, Ville Syrjälä wrote: >>> On Mon, Jan 25, 2016 at 02:44:53PM +0100, Mario Kleiner wrote: >>>> >>>> >>>> On 01/25/2016 02:23 PM, Ville Syrjälä wrote: >>>>> On Mon, Jan 25, 2016 at 02:16:45PM +0100, Mario Kleiner wrote: >>>>>> >>>>>> >>>>>> On 01/25/2016 05:15 AM, Michel Dänzer wrote: >>>>>>> On 23.01.2016 00:18, Ville Syrjälä wrote: >>>>>>>> On Fri, Jan 22, 2016 at 12:06:00PM +0900, Michel Dänzer wrote: >>>>>>>>> >>>>>>>>> [ Trimming KDE folks from Cc ] >>>>>>>>> >>>>>>>>> On 21.01.2016 19:09, Daniel Vetter wrote: >>>>>>>>>> On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: >>>>>>>>>>> On 21.01.2016 16:58, Daniel Vetter wrote: >>>>>>>>>>>> >>>>>>>>>>>> Can you please point me at the vblank on/off jump bug please? >>>>>>>>>>> >>>>>>>>>>> AFAIR I originally reported it in response to >>>>>>>>>>> http://lists.freedesktop.org/archives/dri-devel/2015-August/087841.html >>>>>>>>>>> , but I can't find that in the archives, so maybe that was just on IRC. >>>>>>>>>>> See >>>>>>>>>>> http://lists.freedesktop.org/archives/dri-devel/2016-January/099122.html >>>>>>>>>>> . Basically, I ran into the bug fixed by your patch because the counter >>>>>>>>>>> jumped forward on every DPMS off, so it hit the 32-bit boundary after >>>>>>>>>>> just a few days. >>>>>>>>>> >>>>>>>>>> Ok, so just uncovered the overflow bug. >>>>>>>>> >>>>>>>>> Not sure what you mean by "just", but to be clear: The drm_vblank_on/off >>>>>>>>> counter jumping bug (similar to the bug this thread is about), which >>>>>>>>> exposed the overflow bug, is still alive and kicking in 4.5. It seems >>>>>>>>> to happen when turning off the CRTC: >>>>>>>>> >>>>>>>>> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=218104694, diff=0, hw=916 hw_last=916 >>>>>>>>> [drm:radeon_get_vblank_counter_kms] crtc 0: dist from vblank start 3 >>>>>>>>> [drm:drm_calc_vbltimestamp_from_scanoutpos] crtc 0 : v 0x7 p(2199,-45)@ 7304.307354 -> 7304.308006 [e 0 us, 0 rep] >>>>>>>>> [drm:radeon_get_vblank_counter_kms] crtc 0: dist from vblank start 3 >>>>>>>>> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=218104694, diff=16776301, hw=1 hw_last=916 >>>>>>>> >>>>>>>> Not sure what bug we're talking about here, but here the hw counter >>>>>>>> clearly jumps backwards. >>>>>>>> >>>>>>>>> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >>>>>>>>> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >>>>>>>>> [drm:drm_update_vblank_count] updating vblank count on crtc 1: current=0, diff=0, hw=0 hw_last=0 >>>>>>>>> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >>>>>>>>> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >>>>>>>>> [drm:drm_update_vblank_count] updating vblank count on crtc 2: current=0, diff=0, hw=0 hw_last=0 >>>>>>>>> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >>>>>>>>> [drm:radeon_get_vblank_counter_kms] Query failed! stat 3 >>>>>>>>> [drm:drm_update_vblank_count] updating vblank count on crtc 3: current=0, diff=0, hw=0 hw_last=0 >>>>>>>>> [drm:radeon_get_vblank_counter_kms] Query failed! stat 1 >>>>>>>>> [drm:drm_calc_vbltimestamp_from_scanoutpos] crtc 0 : v 0x1 p(0,0)@ 7304.317140 -> 7304.317140 [e 0 us, 0 rep] >>>>>>>>> [drm:radeon_get_vblank_counter_kms] Query failed! stat 1 >>>>>>>>> [drm:drm_update_vblank_count] updating vblank count on crtc 0: current=234880995, diff=16777215, hw=0 hw_last=1 >>>>>>>> >>>>>>>> Same here. >>>>>>> >>>>>>> At least one of the jumps is expected, because this is around turning >>>>>>> off the CRTC for DPMS off. Don't know yet why there are two jumps back >>>>>>> though. >>>>>>> >>>>>>> >>>>>>>> These things just don't happen on i915 because drm_vblank_off() and >>>>>>>> drm_vblank_on() are always called around the times when the hw counter >>>>>>>> might get reset. Or at least that's how it should be. >>>>>>> >>>>>>> Which is of course the idea of Daniel's patch (which is what I'm getting >>>>>>> the above with) or Mario's patch as well, but clearly something's still >>>>>>> wrong. It's certainly possible that it's something in the driver, but >>>>>>> since calling drm_vblank_pre/post_modeset from the same places seems to >>>>>>> work fine (ignoring the regression discussed in this thread)... Do >>>>>>> drm_vblank_on/off require something else to handle this correctly? >>>>>>> >>>>>>> >>>>>> >>>>>> I suspect it is because vblank_disable_and_save calls >>>>>> drm_update_vblank_count() unconditionally, even if vblank irqs are >>>>>> already off. >>>>>> >>>>>> So on a manual display disable -> reenable you get something like >>>>>> >>>>>> At disable: >>>>>> >>>>>> Call to dpms-off --> atombios_crtc_dpms(DPMS_OFF) --> drm_vblank_off -> >>>>>> vblank_disable_and_save -> irqs off, drm_update_vblank_count() computes >>>>>> final count. >>>>>> >>>>>> Then the crtc is shut down and its hw counter resets to zero. >>>>>> >>>>>> At reenable: >>>>>> >>>>>> Modesetting -> drm_crtc_helper_set_mode -> crtc_funcs->prepare(crtc) -> >>>>>> atombios_crtc_prepare() -> atombios_crtc_dpms(DPMS_OFF) -> >>>>>> drm_vblank_off -> vblank_disable_and_save -> A pointless >>>>>> drm_update_vblank_count() while the hw counter is already reset to zero >>>>>> --> Unwanted counter jump. >>>>>> >>>>>> >>>>>> The problem doesn't happen on a pure modeset to a different video >>>>>> resolution/refresh rate, as then we only have one call into >>>>>> atombios_crtc_dpms(DPMS_OFF). >>>>>> >>>>>> I think the fix is to fix vblank_disable_and_save() to only call >>>>>> drm_update_vblank_count() if vblank irqs get actually disabled, not on >>>>>> no-op calls. I will try that now. >>>>> >>>>> It does that on purpose. Otherwise the vblank counter would appear to >>>>> have stalled while the interrupt was off. >>>>> >>>> >>>> Ok, that's what the comments there say, although i don't see atm. why >>>> that perceived stall would be a big problem. I checked all callers of >>>> vblank_disable_and_save(). They are all careful to not call that >>>> function if vblanks are already disabled. The only exception is >>>> drm_vblank_off(). If drm_vblank_off/on is supposed to protect kms >>>> drivers which have resetting hw counters or other problematic behaviour >>>> during modesets etc. then this will break. E.g., calling the vblank >>>> timestamping stuff is also not safe/well-defined during modesets when >>>> the timestamping constants are not (yet) updated to reflect the new mode >>>> timing of the modeset in progress. >>> >>> The idea is to maintain the appearance that the counter ticks all the >>> time as long as the crtc is active. While that may not be really >>> required in case if no one is currently interested in the vblank >>> counter, I think it's a nice thing to have just to make the behaviour >>> of the counter consistent. >>> >>> As far as calling drm_vblank_off() after the hw counter got reset, well, >>> that not correct. It should be called before the reset. >> >> What radeon does is calling drm_vblank_off at beginning of DPMS_OFF. The >> first call to DMPS_OFF will call drm_vblank_off() and really disable >> vblank-irqs if they were running, updating the counts/ts a last time. But >> then the dpms off will reset the hw counter to zero. When one reenables the >> display, a second call to DPMS_OFF will now call drm_vblank_off again when >> it apparently shouldn't. >> >> I just tested this patch, which fixes the counter jumps on radeon-kms with >> my or Daniel's drm_vblank_off patches to radeon: > > This might be due to the legacy helpers, which just love to redundantly > disable stuff that's off already. The problem I see with no-oping these > out is that for atomic drivers (which really should get this right) this > might paper over bugs: E.g. when you forget to call _off() when disabling > the crtc, then calling _on() twice in a row is indeed a serious bug. > Similar when you forget to call _on() and have multiple _off() calls in a > row. > > So not sure what to do here. > -Daniel > Yes, the legacy helpers cause two calls to dpms off if one disables a display. First during display disable as intended. Then when one reenables the display during modesetting as part of crtc_funcs->prepare() - at least on radeon. Maybe the minimum thing that would help is to just check for vblank->inmodeset in drm_vblank_off(). If that would be the case we'd know it is a redundant call and could no-op it and do a WARN_ON(vblank->inmodeset)? drm_vblank_on() i don't know how to treat, but that one calls drm_reset_vblank_timestamp() which should be less problematic if called redundantly. Now the patch i want to try next to fix the drm_vblank_pre/post_modeset regression in Linux 4.4/4.5 is to add a ... if ((diff > 1) && vblank->inmodeset) diff = 1; ... to the bottom of drm_update_vblank_count(). That should hopefully restore the pre/post_modeset behavior as close to the original behavior as possible. As a side effect it would also prevent the counter jump caused by redundant calls to drm_vblank_off(). -mario >> >> diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_irq.c >> index 607f493..d739d93 100644 >> --- a/drivers/gpu/drm/drm_irq.c >> +++ b/drivers/gpu/drm/drm_irq.c >> @@ -1313,7 +1313,10 @@ void drm_vblank_off(struct drm_device *dev, unsigned >> int pipe) >> spin_lock_irqsave(&dev->event_lock, irqflags); >> >> spin_lock(&dev->vbl_lock); >> - vblank_disable_and_save(dev, pipe); >> + DRM_DEBUG_VBL("crtc %d, vblank enabled %d\n", pipe, >> vblank->enabled); >> + >> + if (vblank->enabled) >> + vblank_disable_and_save(dev, pipe); >> wake_up(&vblank->queue); >> >> /* >> @@ -1415,6 +1418,8 @@ void drm_vblank_on(struct drm_device *dev, unsigned >> int pipe) >> return; >> >> spin_lock_irqsave(&dev->vbl_lock, irqflags); >> + DRM_DEBUG_VBL("crtc %d, vblank enabled %d\n", pipe, >> vblank->enabled); >> + >> /* Drop our private "prevent drm_vblank_get" refcount */ >> if (vblank->inmodeset) { >> atomic_dec(&vblank->refcount); >> >> >> >> Another, maybe better, approach might be to no-op redundant calls to >> drm_vblank_off() iff vblank->inmodeset and no-op redundant calls to >> drm_vblank_on() iff !vblank->inmodeset. >> >> -mario >> >> >>> >>>> >>>> -mario >>>> >>>> >>>>>> >>>>>> Otherwise kms drivers would have to be careful to never call >>>>>> drm_vblank_off multiple times before calling drm_vblank_on, but the help >>>>>> text to drm_vblank_on() claims that unbalanced calls to these functions >>>>>> are perfectly fine. >>>>>> >>>>>> -mario >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> >>>>> >>> >