All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Osipenko <digetx@gmail.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
Cc: Peter Maydell <peter.maydell@linaro.org>,
	qemu-arm <qemu-arm@nongnu.org>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v11 2/7] hw/ptimer: Perform counter wrap around if timer already expired
Date: Mon, 25 Jan 2016 22:43:06 +0300	[thread overview]
Message-ID: <56A67ACA.4090801@gmail.com> (raw)
In-Reply-To: <CAPokK=q0EzXWeAFibVYKXmvwh5=vM6LsEqJB9k5dNGF6AiHeoA@mail.gmail.com>

Hello Peter,

24.01.2016 08:29, Peter Crosthwaite пишет:

[snip]

>> +            if (expired && (counter != 0)) {
>> +                /* Wrap around periodic counter.  */
>> +                counter = s->limit - counter % s->limit;
>> +            }

Noticed another nit here. This should be:

counter = s->limit - (counter - 1) % s->limit;

So wraparound for counter = -1 is counter = limit (not limit - 1). Will fix it 
in V12.

I suppose your r-b is still valid, otherwise please let me know.

-- 
Dmitry

  reply	other threads:[~2016-01-25 19:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-21 19:03 [Qemu-arm] [PATCH v11 0/7] PTimer fixes/features and ARM MPTimer conversion Dmitry Osipenko
2016-01-21 19:03 ` [Qemu-devel] " Dmitry Osipenko
2016-01-21 19:03 ` [Qemu-devel] [PATCH v11 1/7] hw/ptimer: Fix issues caused by the adjusted timer limit value Dmitry Osipenko
2016-01-21 19:03 ` [Qemu-devel] [PATCH v11 2/7] hw/ptimer: Perform counter wrap around if timer already expired Dmitry Osipenko
2016-01-24  5:29   ` Peter Crosthwaite
2016-01-25 19:43     ` Dmitry Osipenko [this message]
2016-01-21 19:03 ` [Qemu-devel] [PATCH v11 3/7] hw/ptimer: Update .delta on period/freq change Dmitry Osipenko
2016-01-21 19:03 ` [Qemu-devel] [PATCH v11 4/7] hw/ptimer: Support "on the fly" timer mode switch Dmitry Osipenko
2016-01-21 19:03 ` [Qemu-devel] [PATCH v11 5/7] hw/ptimer: Introduce ptimer_get_limit Dmitry Osipenko
2016-01-21 19:03 ` [Qemu-devel] [PATCH v11 6/7] hw/ptimer: Legalize running with delta = load = 0 and abort on period = 0 Dmitry Osipenko
2016-01-24  4:28   ` [Qemu-arm] " Peter Crosthwaite
2016-01-24  4:28     ` [Qemu-devel] " Peter Crosthwaite
2016-01-24 15:02     ` [Qemu-arm] " Dmitry Osipenko
2016-01-24 15:02       ` [Qemu-devel] " Dmitry Osipenko
2016-01-21 19:03 ` [Qemu-devel] [PATCH v11 7/7] arm_mptimer: Convert to use ptimer Dmitry Osipenko
2016-01-24  5:25   ` [Qemu-arm] " Peter Crosthwaite
2016-01-24  5:25     ` [Qemu-devel] " Peter Crosthwaite
2016-01-24 14:59     ` [Qemu-arm] " Dmitry Osipenko
2016-01-24 14:59       ` [Qemu-devel] " Dmitry Osipenko
2016-01-26 20:29       ` [Qemu-arm] " Dmitry Osipenko
2016-01-26 20:29         ` [Qemu-devel] " Dmitry Osipenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A67ACA.4090801@gmail.com \
    --to=digetx@gmail.com \
    --cc=crosthwaitepeter@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.