From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38614) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNnp9-0002mX-SY for qemu-devel@nongnu.org; Mon, 25 Jan 2016 15:33:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNnp8-0003fS-Rd for qemu-devel@nongnu.org; Mon, 25 Jan 2016 15:33:19 -0500 References: <1453747275-9468-1-git-send-email-mreitz@redhat.com> <1453747275-9468-6-git-send-email-mreitz@redhat.com> From: Eric Blake Message-ID: <56A68682.8000304@redhat.com> Date: Mon, 25 Jan 2016 13:33:06 -0700 MIME-Version: 1.0 In-Reply-To: <1453747275-9468-6-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="1Ww282hLT0oUcoJwSpecPajXkXGAuMl3c" Subject: Re: [Qemu-devel] [PATCH 5/8] iotests: Make _filter_nbd drop log lines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-block@nongnu.org Cc: Kevin Wolf , Paolo Bonzini , Fam Zheng , qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --1Ww282hLT0oUcoJwSpecPajXkXGAuMl3c Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/25/2016 11:41 AM, Max Reitz wrote: > The NBD log lines ("/your/source/dir/nbd.c:function():line: error") This line doesn't match the pre- or post-patch sed pattern. Something that would match would be "/your/source/dir/nbd/file.c:function():line: error". Maybe you should tweak the commit message? > should not be converted to empty lines but removed altogether. >=20 > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/083.out | 10 ---------- > tests/qemu-iotests/common.filter | 2 +- > 2 files changed, 1 insertion(+), 11 deletions(-) > +++ b/tests/qemu-iotests/common.filter > @@ -237,7 +237,7 @@ _filter_nbd() > # receive callbacks sometimes, making them unreliable. > # > # Filter out the TCP port number since this changes between runs. > - sed -e 's#^.*nbd/.*\.c:.*##g' \ > + sed -e '/nbd\/.*\.c:/d' \ The filter may be over-broad,... > -e 's#nbd:127\.0\.0\.1:[^:]*:#nbd:127\.0\.0\.1:PORT:#g' \ =2E..given that this line will be useless if anything in the resulting message contains '.c'. A tighter filter might be worth it (maybe '^[!:]*nbd\/[!:]*\.c:/d', to at least limit it to lines where "nbd/...c:" appears at the front of the line? But that's a separate change. Your conversion looks sane by itself, so: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --1Ww282hLT0oUcoJwSpecPajXkXGAuMl3c Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJWpoaCAAoJEKeha0olJ0NqLqIIAJihv0LiFvGV3Qgz8m2d7Ckk Om0Vz8sYa3aQmeC6PGr2j/Y0nJLYDpQYZ3GHMlixBU+N5y+MdyMMYFPvH/R93iEN OX4jyHqdwzfaBcCvvAJbG+Y/xndjGOSvEPudUXfddCa2UTjCQeaDI3jro4efE6ZE hD9NVYi9mb0AKy9W36mC/JKy85RBA0oh3gRNl76Edbfyo4KJDFbQRPc2Ss0EwiS9 PiLc2nvKXqWGR8d80ZOKTassVGBW6/s04najEjfbU0ha6pFeR+KKRHrKYo39EIfg jyfT6Rl6TKPSioAI56/fmZ5xOrqpmSgPX4QHlt5PSTNWIR1A0UgoUDRkQJLpWdA= =94C6 -----END PGP SIGNATURE----- --1Ww282hLT0oUcoJwSpecPajXkXGAuMl3c--