From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNnt5-0005Md-1T for qemu-devel@nongnu.org; Mon, 25 Jan 2016 15:37:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNnt3-0004MC-VO for qemu-devel@nongnu.org; Mon, 25 Jan 2016 15:37:22 -0500 References: <1453270306-16608-1-git-send-email-famz@redhat.com> <1453270306-16608-3-git-send-email-famz@redhat.com> From: John Snow Message-ID: <56A6877C.20402@redhat.com> Date: Mon, 25 Jan 2016 15:37:16 -0500 MIME-Version: 1.0 In-Reply-To: <1453270306-16608-3-git-send-email-famz@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 02/13] typedefs: Add BdrvDirtyBitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fam Zheng , qemu-devel@nongnu.org Cc: Kevin Wolf , Jeff Cody , Vladimir Sementsov-Ogievskiy , qemu-block@nongnu.org On 01/20/2016 01:11 AM, Fam Zheng wrote: > Following patches to refactor and move block dirty bitmap code could use > this. > > Signed-off-by: Fam Zheng > --- > include/block/block.h | 3 +-- > include/qemu/typedefs.h | 1 + > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/block/block.h b/include/block/block.h > index c96923d..483bfd3 100644 > --- a/include/block/block.h > +++ b/include/block/block.h > @@ -8,6 +8,7 @@ > #include "block/accounting.h" > #include "qapi/qmp/qobject.h" > #include "qapi-types.h" > +#include "qemu/hbitmap.h" > > /* block.c */ > typedef struct BlockDriver BlockDriver; > @@ -472,8 +473,6 @@ void *qemu_try_blockalign(BlockDriverState *bs, size_t size); > void *qemu_try_blockalign0(BlockDriverState *bs, size_t size); > bool bdrv_qiov_is_aligned(BlockDriverState *bs, QEMUIOVector *qiov); > > -struct HBitmapIter; > -typedef struct BdrvDirtyBitmap BdrvDirtyBitmap; > BdrvDirtyBitmap *bdrv_create_dirty_bitmap(BlockDriverState *bs, > uint32_t granularity, > const char *name, > diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h > index 78fe6e8..0cf9d74 100644 > --- a/include/qemu/typedefs.h > +++ b/include/qemu/typedefs.h > @@ -10,6 +10,7 @@ typedef struct AddressSpace AddressSpace; > typedef struct AioContext AioContext; > typedef struct AllwinnerAHCIState AllwinnerAHCIState; > typedef struct AudioState AudioState; > +typedef struct BdrvDirtyBitmap BdrvDirtyBitmap; > typedef struct BlockBackend BlockBackend; > typedef struct BlockBackendRootState BlockBackendRootState; > typedef struct BlockDriverState BlockDriverState; > Reviewed-by: John Snow