From: Romain Naour <romain.naour@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/8] vlc: remove dependency on C library
Date: Mon, 25 Jan 2016 23:55:27 +0100 [thread overview]
Message-ID: <56A6A7DF.1080607@gmail.com> (raw)
In-Reply-To: <1453148701-10036-5-git-send-email-thomas.petazzoni@free-electrons.com>
Thomas, All,
Le 18/01/2016 21:24, Thomas Petazzoni a ?crit :
> vlc uses <spawn.h> which was not available in old uClibc
> versions. However, since we are removing support for uClibc 0.9.33, we
> can get rid of such dependency. In addition, <spawn.h> is provided by
> musl, and therefore VLC can be enabled with this C library.
>
> Consequently, this commit completely removes any C library dependency
> for the vlc package. The only special case that needs to be handled is
> the Blackfin external toolchain from Analog Devices, which still uses
> an old uClibc version that doesn't provide <spawn.h>.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Build tested on a x86_64 musl toolchain.
Tested-by: Romain Naour <romain.naour@gmail.com>
Reviewed-by: Romain Naour <romain.naour@gmail.com>
Best regards,
Romain
> ---
> package/vlc/Config.in | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/vlc/Config.in b/package/vlc/Config.in
> index 03e85c3..cad21e2 100644
> --- a/package/vlc/Config.in
> +++ b/package/vlc/Config.in
> @@ -5,12 +5,12 @@ endif
>
> config BR2_PACKAGE_VLC
> bool "vlc"
> - depends on (BR2_UCLIBC_VERSION_SNAPSHOT || BR2_UCLIBC_VERSION_NG || BR2_TOOLCHAIN_USES_GLIBC) # spawn.h
> depends on BR2_INSTALL_LIBSTDCPP
> depends on !BR2_STATIC_LIBS
> depends on BR2_USE_WCHAR
> depends on BR2_TOOLCHAIN_HAS_THREADS
> depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
> + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX
> select BR2_PACKAGE_LIBVORBIS if BR2_PACKAGE_OPUS
> select BR2_PACKAGE_VLC_OPENCV_BACKEND if BR2_PACKAGE_OPENCV
> select BR2_PACKAGE_VLC_OPENCV3_BACKEND if BR2_PACKAGE_OPENCV3
> @@ -32,7 +32,7 @@ config BR2_PACKAGE_VLC_OPENCV3_BACKEND
> select BR2_PACKAGE_OPENCV3_LIB_IMGPROC
> select BR2_PACKAGE_OPENCV3_LIB_OBJDETECT
>
> -comment "vlc needs a uclibc snapshot, uclibc-ng or (e)glibc toolchain w/ C++, dynamic library, wchar, threads, headers >= 3.7"
> - depends on !(BR2_UCLIBC_VERSION_SNAPSHOT || BR2_UCLIBC_VERSION_NG || BR2_TOOLCHAIN_USES_GLIBC) \
> - || !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_USE_WCHAR \
> +comment "vlc needs a toolchain w/ C++, dynamic library, wchar, threads, headers >= 3.7"
> + depends on !BR2_TOOLCHAIN_EXTERNAL_BLACKFIN_UCLINUX
> + depends on !BR2_INSTALL_LIBSTDCPP || BR2_STATIC_LIBS || !BR2_USE_WCHAR \
> || !BR2_TOOLCHAIN_HAS_THREADS || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
>
next prev parent reply other threads:[~2016-01-25 22:55 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-18 20:24 [Buildroot] [PATCH 0/8] Remove uClibc version selection: always use uClibc-ng Thomas Petazzoni
2016-01-18 20:24 ` [Buildroot] [PATCH 1/8] libunwind: fix C library dependency Thomas Petazzoni
2016-01-25 21:59 ` Romain Naour
2016-01-25 22:20 ` Thomas Petazzoni
2016-01-25 22:33 ` Romain Naour
2016-01-25 22:43 ` Thomas Petazzoni
2016-01-18 20:24 ` [Buildroot] [PATCH 2/8] lttng-babeltrace: make available for all C libraries Thomas Petazzoni
2016-01-18 20:35 ` Baruch Siach
2016-01-25 22:16 ` Romain Naour
2016-01-18 20:24 ` [Buildroot] [PATCH 3/8] mongrel2: allow using uClibc but only on certain architectures Thomas Petazzoni
2016-01-25 22:41 ` Romain Naour
2016-01-25 22:59 ` Thomas Petazzoni
2016-01-18 20:24 ` [Buildroot] [PATCH 4/8] vlc: remove dependency on C library Thomas Petazzoni
2016-01-25 22:55 ` Romain Naour [this message]
2016-01-18 20:24 ` [Buildroot] [PATCH 5/8] samba4: remove dependency on specific C libraries Thomas Petazzoni
2016-01-25 23:06 ` Romain Naour
2016-01-26 9:58 ` Thomas Petazzoni
2016-01-18 20:24 ` [Buildroot] [PATCH 6/8] uclibc: remove 0.9.33 version Thomas Petazzoni
2016-01-25 23:11 ` Romain Naour
2016-01-25 23:14 ` Romain Naour
2016-01-26 22:08 ` Arnout Vandecappelle
2016-01-18 20:25 ` [Buildroot] [PATCH 7/8] uclibc: remove support for the snapshot version Thomas Petazzoni
2016-01-25 23:16 ` Romain Naour
2016-01-18 20:25 ` [Buildroot] [PATCH 8/8] uclibc: remove version selection Thomas Petazzoni
2016-01-25 23:31 ` Romain Naour
2016-01-24 20:25 ` [Buildroot] [PATCH 0/8] Remove uClibc version selection: always use uClibc-ng Romain Naour
2016-01-24 20:32 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A6A7DF.1080607@gmail.com \
--to=romain.naour@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.