From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Date: Tue, 26 Jan 2016 00:46:26 +0000 Subject: Re: [PATCH] fbdev: s6e8ax0: avoid unused function warnings Message-Id: <56A6C1E2.7060804@samsung.com> List-Id: References: <1453734300-1958304-1-git-send-email-arnd@arndb.de> In-Reply-To: <1453734300-1958304-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: linux-arm-kernel@lists.infradead.org On 26.01.2016 00:04, Arnd Bergmann wrote: > The s6e8ax0 suspend/resume functions are hidden inside of an #ifdef > when CONFIG_PM is set to avoid unused function warnings, but they > call some other functions that nothing else calls, and we get warnings > about those: > > drivers/video/fbdev/exynos/s6e8ax0.c:449:13: error: 's6e8ax0_sleep_in' defined but not used [-Werror=unused-function] > drivers/video/fbdev/exynos/s6e8ax0.c:485:13: error: 's6e8ax0_display_off' defined but not used [-Werror=unused-function] > > This marks the PM functions as __maybe_unused so the compiler can > silently drop them when they are not referenced. > > Signed-off-by: Arnd Bergmann > --- > drivers/video/fbdev/exynos/s6e8ax0.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: Krzysztof Kozlowski Subject: Re: [PATCH] fbdev: s6e8ax0: avoid unused function warnings Date: Tue, 26 Jan 2016 09:46:26 +0900 Message-ID: <56A6C1E2.7060804@samsung.com> References: <1453734300-1958304-1-git-send-email-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:36709 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755882AbcAZAqa (ORCPT ); Mon, 25 Jan 2016 19:46:30 -0500 In-reply-to: <1453734300-1958304-1-git-send-email-arnd@arndb.de> Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Arnd Bergmann , Tomi Valkeinen Cc: linux-arm-kernel@lists.infradead.org, Jean-Christophe Plagniol-Villard , Kukjin Kim , linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org On 26.01.2016 00:04, Arnd Bergmann wrote: > The s6e8ax0 suspend/resume functions are hidden inside of an #ifdef > when CONFIG_PM is set to avoid unused function warnings, but they > call some other functions that nothing else calls, and we get warnings > about those: > > drivers/video/fbdev/exynos/s6e8ax0.c:449:13: error: 's6e8ax0_sleep_in' defined but not used [-Werror=unused-function] > drivers/video/fbdev/exynos/s6e8ax0.c:485:13: error: 's6e8ax0_display_off' defined but not used [-Werror=unused-function] > > This marks the PM functions as __maybe_unused so the compiler can > silently drop them when they are not referenced. > > Signed-off-by: Arnd Bergmann > --- > drivers/video/fbdev/exynos/s6e8ax0.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 From: k.kozlowski@samsung.com (Krzysztof Kozlowski) Date: Tue, 26 Jan 2016 09:46:26 +0900 Subject: [PATCH] fbdev: s6e8ax0: avoid unused function warnings In-Reply-To: <1453734300-1958304-1-git-send-email-arnd@arndb.de> References: <1453734300-1958304-1-git-send-email-arnd@arndb.de> Message-ID: <56A6C1E2.7060804@samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 26.01.2016 00:04, Arnd Bergmann wrote: > The s6e8ax0 suspend/resume functions are hidden inside of an #ifdef > when CONFIG_PM is set to avoid unused function warnings, but they > call some other functions that nothing else calls, and we get warnings > about those: > > drivers/video/fbdev/exynos/s6e8ax0.c:449:13: error: 's6e8ax0_sleep_in' defined but not used [-Werror=unused-function] > drivers/video/fbdev/exynos/s6e8ax0.c:485:13: error: 's6e8ax0_display_off' defined but not used [-Werror=unused-function] > > This marks the PM functions as __maybe_unused so the compiler can > silently drop them when they are not referenced. > > Signed-off-by: Arnd Bergmann > --- > drivers/video/fbdev/exynos/s6e8ax0.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof