From mboxrd@z Thu Jan 1 00:00:00 1970 From: Yakir Yang Subject: Re: [PATCH v6] drm/rockchip: hdmi: add Innosilicon HDMI support Date: Tue, 26 Jan 2016 10:28:03 +0800 Message-ID: <56A6D9B3.4070006@rock-chips.com> References: <1453686197-20975-1-git-send-email-ykk@rock-chips.com> <1453686430-21470-1-git-send-email-ykk@rock-chips.com> <1453769119.17181.37.camel@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1453769119.17181.37.camel@tiscali.nl> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Paul Bolle , Mark Yao , David Airlie , Heiko Stuebner Cc: Mark Rutland , devicetree@vger.kernel.org, Pawel Moll , Ian Campbell , Ben Chan , Ken Mixte , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Rob Herring , Kumar Gala , Thierry Reding , linux-arm-kernel@lists.infradead.org, Zheng Yang List-Id: linux-rockchip.vger.kernel.org SGkgUGF1bCwKCk9uIDAxLzI2LzIwMTYgMDg6NDUgQU0sIFBhdWwgQm9sbGUgd3JvdGU6Cj4gT24g bWEsIDIwMTYtMDEtMjUgYXQgMDk6NDcgKzA4MDAsIFlha2lyIFlhbmcgd3JvdGU6Cj4+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9LY29uZmlnCj4+ICsrKyBiL2RyaXZlcnMvZ3B1L2Ry bS9yb2NrY2hpcC9LY29uZmlnCj4+ICtjb25maWcgUk9DS0NISVBfSU5OT19IRE1JCj4+ICsJdHJp c3RhdGUgIlJvY2tjaGlwIHNwZWNpZmljIGV4dGVuc2lvbnMgZm9yIElubm9zaWxpY29uIEhETUki Cj4+ICsgICAgICAgIGRlcGVuZHMgb24gRFJNX1JPQ0tDSElQCj4+ICsgICAgICAgIGhlbHAKPj4g KwkgIFRoaXMgc2VsZWN0cyBzdXBwb3J0IGZvciBSb2NrY2hpcCBTb0Mgc3BlY2lmaWMgZXh0ZW5z aW9ucwo+PiArCSAgZm9yIHRoZSBJbm5vc2lsaWNvbiBIRE1JIGRyaXZlci4gSWYgeW91IHdhbnQg dG8gZW5hYmxlCj4+ICsJICBIRE1JIG9uIFJLMzAzNiBiYXNlZCBTb0MsIHlvdSBzaG91bGQgc2Vs ZXQgdGhpcyBvcHRpb24uCj4gKFJlYWxseSB0cml2aWFsOiBzdGFydCBpbmRlbnRhdGlvbiB3aXRo IHRhYnMgb25seSwgcGxlYXNlLiBBbmQKPiBzL3NlbGV0L3NlbGVjdC8uKQpHb3QgaXQKPj4gLS0t IC9kZXYvbnVsbAo+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvaW5ub19oZG1pLmMK Pj4gKyAqIFRoaXMgc29mdHdhcmUgaXMgbGljZW5zZWQgdW5kZXIgdGhlIHRlcm1zIG9mIHRoZSBH TlUgR2VuZXJhbAo+PiBQdWJsaWMKPj4gKyAqIExpY2Vuc2UgdmVyc2lvbiAyLCBhcyBwdWJsaXNo ZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbiwKPj4gYW5kCj4+ICsgKiBtYXkgYmUg Y29waWVkLCBkaXN0cmlidXRlZCwgYW5kIG1vZGlmaWVkIHVuZGVyIHRob3NlIHRlcm1zLgo+IFRo aXMgc3RhdGVzIHRoaXMgZmlsZSBpcyBsaWNlbnNlZCBHUEwgdjIgb25seS4KPgo+PiArTU9EVUxF X0xJQ0VOU0UoIkdQTCIpOwo+IEFuZCwgYWNjb3JkaW5nIHRvIGluY2x1ZGUvbGludXgvbW9kdWxl LmgsIHRoaXMgbWVhbnMgIkdOVSBQdWJsaWMgTGljZW5zZQo+IHYyIG9yIGxhdGVyIi4KPgo+IFNv IEkgdGhpbmsgdGhlcmUncyBhIChzdWJ0bGUpIG1pc21hdGNoIGJldHdlZW4gdGhlIGxpY2Vuc2Ug aWRlbnQgdXNlZAo+IGZvciB0aGlzIGRyaXZlciBhbmQgdGhlIGNvbW1lbnQgYWJvdmUuCgpBaCwg dGhhbmtzLgoKLSBZYWtpcgoKPiBUaGFua3MsCj4KPgo+IFBhdWwgQm9sbGUKPgo+Cj4KCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: ykk@rock-chips.com (Yakir Yang) Date: Tue, 26 Jan 2016 10:28:03 +0800 Subject: [PATCH v6] drm/rockchip: hdmi: add Innosilicon HDMI support In-Reply-To: <1453769119.17181.37.camel@tiscali.nl> References: <1453686197-20975-1-git-send-email-ykk@rock-chips.com> <1453686430-21470-1-git-send-email-ykk@rock-chips.com> <1453769119.17181.37.camel@tiscali.nl> Message-ID: <56A6D9B3.4070006@rock-chips.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Paul, On 01/26/2016 08:45 AM, Paul Bolle wrote: > On ma, 2016-01-25 at 09:47 +0800, Yakir Yang wrote: >> --- a/drivers/gpu/drm/rockchip/Kconfig >> +++ b/drivers/gpu/drm/rockchip/Kconfig >> +config ROCKCHIP_INNO_HDMI >> + tristate "Rockchip specific extensions for Innosilicon HDMI" >> + depends on DRM_ROCKCHIP >> + help >> + This selects support for Rockchip SoC specific extensions >> + for the Innosilicon HDMI driver. If you want to enable >> + HDMI on RK3036 based SoC, you should selet this option. > (Really trivial: start indentation with tabs only, please. And > s/selet/select/.) Got it >> --- /dev/null >> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c >> + * This software is licensed under the terms of the GNU General >> Public >> + * License version 2, as published by the Free Software Foundation, >> and >> + * may be copied, distributed, and modified under those terms. > This states this file is licensed GPL v2 only. > >> +MODULE_LICENSE("GPL"); > And, according to include/linux/module.h, this means "GNU Public License > v2 or later". > > So I think there's a (subtle) mismatch between the license ident used > for this driver and the comment above. Ah, thanks. - Yakir > Thanks, > > > Paul Bolle > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756837AbcAZC2N (ORCPT ); Mon, 25 Jan 2016 21:28:13 -0500 Received: from lucky1.263xmail.com ([211.157.147.131]:42213 "EHLO lucky1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755703AbcAZC15 (ORCPT ); Mon, 25 Jan 2016 21:27:57 -0500 X-263anti-spam: KSV:0; X-MAIL-GRAY: 1 X-MAIL-DELIVERY: 0 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: ykk@rock-chips.com X-FST-TO: linux-arm-kernel@lists.infradead.org X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: ykk@rock-chips.com X-UNIQUE-TAG: <962af727245be1c4912d3aa4447fc7ae> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v6] drm/rockchip: hdmi: add Innosilicon HDMI support To: Paul Bolle , Mark Yao , David Airlie , Heiko Stuebner References: <1453686197-20975-1-git-send-email-ykk@rock-chips.com> <1453686430-21470-1-git-send-email-ykk@rock-chips.com> <1453769119.17181.37.camel@tiscali.nl> Cc: Thierry Reding , Rob Herring , Ken Mixte , Ben Chan , Zheng Yang , Kumar Gala , Ian Campbell , Pawel Moll , Mark Rutland , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org From: Yakir Yang Message-ID: <56A6D9B3.4070006@rock-chips.com> Date: Tue, 26 Jan 2016 10:28:03 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1453769119.17181.37.camel@tiscali.nl> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul, On 01/26/2016 08:45 AM, Paul Bolle wrote: > On ma, 2016-01-25 at 09:47 +0800, Yakir Yang wrote: >> --- a/drivers/gpu/drm/rockchip/Kconfig >> +++ b/drivers/gpu/drm/rockchip/Kconfig >> +config ROCKCHIP_INNO_HDMI >> + tristate "Rockchip specific extensions for Innosilicon HDMI" >> + depends on DRM_ROCKCHIP >> + help >> + This selects support for Rockchip SoC specific extensions >> + for the Innosilicon HDMI driver. If you want to enable >> + HDMI on RK3036 based SoC, you should selet this option. > (Really trivial: start indentation with tabs only, please. And > s/selet/select/.) Got it >> --- /dev/null >> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c >> + * This software is licensed under the terms of the GNU General >> Public >> + * License version 2, as published by the Free Software Foundation, >> and >> + * may be copied, distributed, and modified under those terms. > This states this file is licensed GPL v2 only. > >> +MODULE_LICENSE("GPL"); > And, according to include/linux/module.h, this means "GNU Public License > v2 or later". > > So I think there's a (subtle) mismatch between the license ident used > for this driver and the comment above. Ah, thanks. - Yakir > Thanks, > > > Paul Bolle > > >