From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNuPH-0007bv-CU for qemu-devel@nongnu.org; Mon, 25 Jan 2016 22:35:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aNuPE-0000Px-4a for qemu-devel@nongnu.org; Mon, 25 Jan 2016 22:35:03 -0500 Received: from szxga02-in.huawei.com ([119.145.14.65]:21500) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aNuPD-0000Pt-EN for qemu-devel@nongnu.org; Mon, 25 Jan 2016 22:35:00 -0500 References: <1453451811-11860-1-git-send-email-zhang.zhanghailiang@huawei.com> <1453451811-11860-2-git-send-email-zhang.zhanghailiang@huawei.com> <56A5AC40.3040905@redhat.com> <56A5B98B.8060609@huawei.com> <56A6E283.7050906@redhat.com> From: Hailiang Zhang Message-ID: <56A6E949.3030502@huawei.com> Date: Tue, 26 Jan 2016 11:34:33 +0800 MIME-Version: 1.0 In-Reply-To: <56A6E283.7050906@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 1/7] net/filter: Fix the output information for command 'info network' List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang , qemu-devel@nongnu.org Cc: peter.huangpeng@huawei.com, zhangchen.fnst@cn.fujitsu.com, hongyang.yang@easystack.cn On 2016/1/26 11:05, Jason Wang wrote: > > > On 01/25/2016 01:58 PM, Hailiang Zhang wrote: >> On 2016/1/25 13:01, Jason Wang wrote: >>> >>> >>> On 01/22/2016 04:36 PM, zhanghailiang wrote: >>>> The properties of netfilter object could be changed by 'qom-set' >>>> command, but the output of 'info network' command is not updated, >>>> because it got the old information through nf->info_str, it will >>>> not be updated while we change the value of netfilter's property. >>>> >>>> Here we split a the helper function that could colletct the output >>>> information for filter, and also remove the useless member >>>> 'info_str' from struct NetFilterState. >>>> >>>> Signed-off-by: zhanghailiang >>>> --- >>> >>> Looks like a bug fix. Please send as a independent formal patch and >>> better cc Markus and Eric for better reviewing. >>> >> >> OK, by the way, i didn't see there was a corresponding qmp command >> for 'info network', is the hmp_info_network just an experimental >> command ? > > It's for debugging I think , and if you want it to be used by > management, probably need a qmp version. Got it, the management does not need it for now, thanks. > . >