From: Hans de Goede <hdegoede@redhat.com>
To: "Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
linux-input <linux-input@vger.kernel.org>,
"Sean Cross" <xobs@kosagi.com>,
"Noralf Trønnes" <noralf@tronnes.or>
Cc: Bertrik Sikken <bertrik@sikken.nl>
Subject: Re: New FocalTech FT6236 touchscreen driver is a duplicate with the existing edt-ft5x06.c driver
Date: Tue, 26 Jan 2016 10:16:25 +0100 [thread overview]
Message-ID: <56A73969.5000100@redhat.com> (raw)
In-Reply-To: <5675B852.5060308@redhat.com>
Hi,
On 19-12-15 21:04, Hans de Goede wrote:
> Hi All,
>
> While looking into getting a focaltech touchscreen on a tablet working I noticed
> that we've 2 overlapping drivers, the ft6236.c and the edt-ft5x06.c driver both
> support the exact same i2c touchscreen protocol. In the latter the code for the
> "M09" variant offers identical functionality to the ft6236.c code.
>
> Since the edt-ft5x06.c code seems more complete wrt advanced features and has
> been around much longer, I would like to suggest to add the ft6236.c compatible
> and i2c-ids to the edt-ft5x06.c driver and to drop the duplicate ft6236.c driver.
>
> I've tested both drivers on a Chuwi_V7_CW0825 tablet with a ft5302fe4 touchscreen
> controller (not 100% sure on the model I may be mixing up touchscreen models here,
> but it definitely is a focaltech controller), and both drivers work identically.
Ping ? We really need to fix this and the sooner the better, so that we do not
get more and more devices depending on the new duplicate ft6236.c driver.
Dmitry, since non of the ft6236.c maintainers has responded / has tested there devices
with edt-ft5x06.c, shall I just go ahead and send a patch to add the i2c-id +
compatibles from ft6236.c to edt-ft5x06.c and remove ft6236.c ?
Regards,
Hans
next prev parent reply other threads:[~2016-01-26 9:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-19 20:04 New FocalTech FT6236 touchscreen driver is a duplicate with the existing edt-ft5x06.c driver Hans de Goede
2016-01-26 9:16 ` Hans de Goede [this message]
2016-08-01 8:11 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A73969.5000100@redhat.com \
--to=hdegoede@redhat.com \
--cc=bertrik@sikken.nl \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=noralf@tronnes.or \
--cc=xobs@kosagi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.