All of lore.kernel.org
 help / color / mirror / Atom feed
From: xuejiufei <xuejiufei@huawei.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] ocfs2/dlm: fix a race between refmap setting and clearing
Date: Tue, 26 Jan 2016 17:39:36 +0800	[thread overview]
Message-ID: <56A73ED8.6000908@huawei.com> (raw)

Hi,
This serial of patches is to fix the dis-order issue of
setting/clearing refmap bit described below.

Node 1                               Node 2(master)
dlmlock
dlm_do_master_request
                                dlm_master_request_handler
                                -> dlm_lockres_set_refmap_bit
dlmlock succeed
dlmunlock succeed

dlm_purge_lockres
                                dlm_deref_handler
                                -> find lock resource is in
                                   DLM_LOCK_RES_SETREF_INPROG state,
                                   so dispatch a deref work
dlm_purge_lockres succeed.

call dlmlock again
dlm_do_master_request
                                dlm_master_request_handler
                                -> dlm_lockres_set_refmap_bit

                                deref work trigger, call
                                dlm_lockres_clear_refmap_bit
                                to clear Node 1 from refmap

                                dlm_purge_lockres succeed

dlm_send_remote_lock_request
                                return DLM_IVLOCKID because
                                the lockres is not exist
BUG if the lockres is $RECOVERY

This serial of patches add a new message to keep the order of set and
clear. Other nodes can purge the lock resource only after the refmap
bit on master is cleared.

Jiufei Xue (4):
    ocfs2/dlm: add DEREF_DONE message
    ocfs2/dlm: return in progress if master can not clear the refmap
               bit right now
    ocfs2/dlm: clear DROPPING_REF flag when the master down
    ocfs2/dlm: return EINVAL when the lockres on migration target is
               in DROPPING_REF state

 dlmcommon.h   |   17 +++++++
 dlmdomain.c   |   11 ++++-
 dlmmaster.c   |  124 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 dlmrecovery.c |   32 ++++++++++----
 dlmthread.c   |    7 +++
 5 files changed, 178 insertions(+), 13 deletions(-)

Thanks,
Jiufei Xue

             reply	other threads:[~2016-01-26  9:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26  9:39 xuejiufei [this message]
2016-01-27  1:33 ` [Ocfs2-devel] ocfs2/dlm: fix a race between refmap setting and clearing Joseph Qi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A73ED8.6000908@huawei.com \
    --to=xuejiufei@huawei.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.