From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58331) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO1w4-0007Bh-Nw for qemu-devel@nongnu.org; Tue, 26 Jan 2016 06:37:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aO1w1-0003fe-IS for qemu-devel@nongnu.org; Tue, 26 Jan 2016 06:37:24 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aO1w1-0003fK-Cn for qemu-devel@nongnu.org; Tue, 26 Jan 2016 06:37:21 -0500 References: <1453273940-15382-1-git-send-email-den@openvz.org> <1453273940-15382-3-git-send-email-den@openvz.org> From: Paolo Bonzini Message-ID: <56A75A6B.9050308@redhat.com> Date: Tue, 26 Jan 2016 12:37:15 +0100 MIME-Version: 1.0 In-Reply-To: <1453273940-15382-3-git-send-email-den@openvz.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 2/2] nbd: add missed aio_context_acquire in nbd_export_new List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Denis V. Lunev" Cc: Kevin Wolf , qemu-devel@nongnu.org On 20/01/2016 08:12, Denis V. Lunev wrote: > blk_invalidate_cache() can call qcow2_invalidate_cache which performs > IO inside. > > Signed-off-by: Denis V. Lunev > CC: Kevin Wolf > CC: Paolo Bonzini > --- > nbd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/nbd.c b/nbd.c > index b3d9654..b271db5 100644 > --- a/nbd.c > +++ b/nbd.c > @@ -1080,7 +1080,9 @@ NBDExport *nbd_export_new(BlockBackend *blk, off_t dev_offset, off_t size, > * that BDRV_O_INCOMING is cleared and the image is ready for write > * access since the export could be available before migration handover. > */ > + aio_context_acquire(exp->ctx); > blk_invalidate_cache(blk, NULL); > + aio_context_release(exp->ctx); > return exp; > > fail: > Queuing this one myself. Paolo