All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ocean HY1 He <hehy1@lenovo.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: "tj@kernel.org" <tj@kernel.org>,
	"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Let AHCI dirver skip Lenovo SWRAID controller
Date: Tue, 26 Jan 2016 12:42:43 +0000	[thread overview]
Message-ID: <56A76999.8050206@lenovo.com> (raw)
In-Reply-To: <20160125131850.64c5c22a@lxorguk.ukuu.org.uk>

Hi Alan,

Thanks for your comments!

Lenovo SWRAID driver is a closed source driver at this time, I am afraid 
it's not possible to submit it to kernel.

This patch is very important and critical for Lenovo next generation 
Servers. I have tried to make sure this patch only impacts Lenovo 
dedicated hardware and add a on/off boot option to end user who may 
still wants using open source SWRAID(such as MDRAID).

I am a newbie to submit patch to kernel, so I am not so clear about what
my patch breaks. Could you kindly explain that and is there a workaround 
or solution to avoid the break?

Thanks a lot!

Ocean.

On 01/25/2016 09:18 PM, One Thousand Gnomes wrote:
> On Mon, 25 Jan 2016 03:11:40 +0000
> Ocean HY1 He <hehy1@lenovo.com> wrote:
> 
>> Lenovo SWRAID solution is based on Intel Non-RSTE RAID controller which
>> is called Lenovo SWRAID controller by set Lenovo dedicated PCI
>> SVID:SDID.
>>
>> Because AHCI driver now take control this Lenovo SWRAID controller for
>> MDRAID, Lenovo SWRAID driver fails to load later. It's not proper to
>> disable AHCI driver, because system has SATA contoller used for SATA
>> DVD, M.2 etc. There is no chance to load Lenovo SWRAID first, because
>> almost all Linux distros load AHCI driver first during installation.
>>
>> As default, when Lenovo SWRAID controller is detected, let AHCI driver
>> skip it thus MDRAID is disabled. Use the boot option 'ahci.lenovo_swraid=0'
>> could disable Lenovo SWRAID.
> 
> You need to submit the Lenovo SWRAID driver to the kernel first.
> Otherwise this breaks things.
> 
> Alan
> 

  reply	other threads:[~2016-01-26 12:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-25  3:11 [PATCH] Let AHCI dirver skip Lenovo SWRAID controller Ocean HY1 He
2016-01-25  9:56 ` Christoph Hellwig
2016-01-25 13:18 ` One Thousand Gnomes
2016-01-26 12:42   ` Ocean HY1 He [this message]
2016-01-26 13:24     ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A76999.8050206@lenovo.com \
    --to=hehy1@lenovo.com \
    --cc=gnomes@lxorguk.ukuu.org.uk \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.